Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't relate unmatched parameter positions in signatures #41308

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Conversation

ahejlsberg
Copy link
Member

Fixes #40251.

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 28, 2020
@ahejlsberg
Copy link
Member Author

Note that change looks bigger than it is in the file comparison. All that really changes is a switch to tryGetTypeAtPosition and guarding the remaining code against undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllowJs + ES6 lib result in compiler crash
3 participants