Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant accessors #42425

Merged
merged 20 commits into from
Mar 27, 2021
Merged

Variant accessors #42425

merged 20 commits into from
Mar 27, 2021

Commits on Mar 24, 2021

  1. Allow accessors to have different access modifiers and types 

    Fixes microsoft#2845, microsoft#2521
    @RyanCavanaugh
    RyanCavanaugh committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b7f93bb View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Error if an accessor body appears in a type context

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    04170ad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into variantAccessors 

    # Conflicts:
#	src/compiler/checker.ts
#	src/compiler/diagnosticMessages.json
#	tests/baselines/reference/privateNamesAndGenericClasses-2.errors.txt
    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ed8cd99 View commit details
    Browse the repository at this point in the history

  3. Fix indent

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    8086a03 View commit details
    Browse the repository at this point in the history

  4. Remove stray debugger statement

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    0e527c0 View commit details
    Browse the repository at this point in the history

  5. Fix stray error in tst

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    b4c8ff6 View commit details
    Browse the repository at this point in the history

  6. Update src/compiler/utilities.ts 

    Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
    @RyanCavanaugh @sandersn
    RyanCavanaugh and sandersn authored Mar 26, 2021
    Configuration menu
    Copy the full SHA
    17fd8da View commit details
    Browse the repository at this point in the history

  7. Rename param

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    c454435 View commit details
    Browse the repository at this point in the history

  8. CR updates

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    01b32d9 View commit details
    Browse the repository at this point in the history

  9. Provide isWrite args

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e427e8e View commit details
    Browse the repository at this point in the history

  10. Lint

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    738bc56 View commit details
    Browse the repository at this point in the history

  11. Update tests/baselines/reference/divergentAccessorsTypes1.js 

    Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
    @RyanCavanaugh @sandersn
    RyanCavanaugh and sandersn authored Mar 26, 2021
    Configuration menu
    Copy the full SHA
    2a825f5 View commit details
    Browse the repository at this point in the history

  12. Simplify getter vs setter binding

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    23ce1ba View commit details
    Browse the repository at this point in the history

  13. CR updates

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    670d73b View commit details
    Browse the repository at this point in the history

  14. Remove superfluous error

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    102332b View commit details
    Browse the repository at this point in the history

  15. Remove unneeded undefined

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e7b993e View commit details
    Browse the repository at this point in the history

  16. Rename for clarity

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    b38df0d View commit details
    Browse the repository at this point in the history

  17. (Incorrect) baseline for generics

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    69bccdb View commit details
    Browse the repository at this point in the history

  18. Instantiate generic symbols

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    bafd638 View commit details
    Browse the repository at this point in the history

  19. Improve+simplify get/set assignability matching

    @RyanCavanaugh
    RyanCavanaugh committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    131d194 View commit details
    Browse the repository at this point in the history