--inspect can no longer be used as a flag through gulp #42701
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
|
...wait, how did this change? The last publish of |
|
It’s been broken for 8 months. |
|
So, I tested |
|
Maybe we should just rename it to a 3rd name that doesn't conflict? |
|
|
| @@ -453,8 +453,7 @@ task("runtests").flags = { | |||
| "-t --tests=<regex>": "Pattern for tests to run.", | |||
| " --failed": "Runs tests listed in '.failed-tests'.", | |||
| "-r --reporter=<reporter>": "The mocha reporter to use.", | |||
| "-d --debug": "Runs tests in debug mode (NodeJS 6 and earlier)", | |||
| "-i --inspect": "Runs tests in inspector mode (NodeJS 8 and later)", | |||
| "-i --break": "Runs tests in inspector mode (NodeJS 8 and later)", | |||
There was a problem hiding this comment.
Do we really want -i to be the shorthand for `--break?
There was a problem hiding this comment.
🤷 it's backward compatible
There was a problem hiding this comment.
I'd sorta doubt anyone is taking a hard automated dependency on it, so I wouldn't worry about that too much. 😄
Either way I'll leave it up to you
There was a problem hiding this comment.
-b is already taken by --browser despite not being documented in the Gulpfile, so I’m not sure what else to call it.
There was a problem hiding this comment.
Well...who even runs that one? Anyway, it's not a big deal.
gulp-cli removes
--inspectand--inspect-brkfromprocess.argvand passes it straight to the Node process that’s running gulp, which is not the same Node process that runs mocha for us, so our test runner never sees--inspectas a flag. Using-ialso wasn’t working, as that launched node with--inspect-brk=true, so I fixed that, and updated docs.