Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Editor support for link tag (#41877)" #43302

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

sandersn
Copy link
Member

This reverts commit ec77bff.
It makes DT tests run out of memory, so I'm going to revert it to unblock users of the various DT tests.

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@sandersn sandersn merged commit 451d435 into master Mar 18, 2021
@sandersn sandersn deleted the revert-link-tag-support branch March 18, 2021 21:42
sandersn added a commit that referenced this pull request Mar 19, 2021
sandersn added a commit that referenced this pull request Mar 22, 2021
* Revert "Revert "Editor support for link tag (#41877)" (#43302)"

This reverts commit 451d435.

* Fix parsing @link at end of comment

* Parse comments as string when no @link occurs

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants