Fix getTypeFromJSDocVariadicType in callback tag #43562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variadics have never worked there, I think.
typescript-bot
added
Author: Team
For Milestone Bug
weswigham
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this never worked, since
@callbacksupport was added after the last time this code was changed.There is a much more general change to treat callback tags as jsdoc hosts, or at least host signatures, but the tree shape of callbacks is quite different from those of a normal signature. Specifically, parameters and return types are themselves tags, and their types are buried another two levels down their respective trees.
Fixes #43072