Ensure AutoImportProviderProject can share source files with main program #44274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
May 26, 2021
|
Did this PR mean to reference something other than #44295? |
|
Yes, but I no longer recall what 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a duplicate auto-import completions bug I noticed while working on #44295, caused by differing compiler options causing the AutoImportProviderProject not to share source files with its host Project.
It looks like those options (
types,lib, andnoLib) are actually misclassified as affecting module resolution, and @sheetalkamat is opening a PR to fix that (extracting work from #41004). Once that’s fixed, the bug will be fixed, and I can revert the part of this PR that is actually a substantive behavior change. The primary value of this PR is structuring the config in such a way that the overriding options can be tested againstsourceFileAffectingCompilerOptionsand adding that test.