Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the DOM APIs #46080

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Updates the DOM APIs #46080

merged 3 commits into from
Sep 27, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 27, 2021 •
edited
Loading

Re: microsoft/TypeScript-DOM-lib-generator#1143

Most of the diff comes from more whitespace aware commenting.

@types/web

New interfaces

  • ElementInternals

Removed interfaces

Modified

  • CSSStyleDeclaration
    • Added: accentColor
  • Document
    • Removed: elementFromPoint, elementsFromPoint - these live on DocumentOrShadowRoot instead
  • HTMLElement
    • Added: attachInternals
  • HTMLSlotElement
    • Added: assign
  • Navigator
    • Added: canShare
    • Removed: pointerEnabled - removed from spec in 2014
  • ReadableStream
  • Text

Non-value types

  • MediaTrackConstraintSet
    • Added: autoGainControl, noiseSuppression
  • MediaTrackSettings
    • Added: autoGainControl, noiseSuppression
  • MediaTrackSupportedConstraints
    • Added: autoGainControl, noiseSuppression
  • DocumentOrShadowRoot
    • Added: elementFromPoint, elementsFromPoint

index.iterable.d.ts

No changes

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 27, 2021
@orta
Copy link
Contributor Author

orta commented Sep 27, 2021

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 27, 2021 •
edited
Loading

Heya @orta, I've started to run the parallelized community code test suite on this PR at 95b737b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 27, 2021 •
edited
Loading

Heya @orta, I've started to run the extended test suite on this PR at 95b737b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 27, 2021 •
edited
Loading

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 95b737b. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Sep 27, 2021
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@orta
Copy link
Contributor Author

orta commented Sep 27, 2021

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 27, 2021 •
edited
Loading

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 70f7684. You can monitor the build here.

@orta
Copy link
Contributor Author

orta commented Sep 27, 2021

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 27, 2021 •
edited
Loading

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 2a15aed. You can monitor the build here.

@orta
Copy link
Contributor Author

orta commented Sep 27, 2021

DefinitelyTyped/DefinitelyTyped#56013 has covered all the changes to DT

@orta orta merged commit d6cd2c7 into microsoft:main Sep 27, 2021
orta pushed a commit to orta/TypeScript that referenced this pull request Sep 27, 2021
@orta
Updates the DOM APIs (microsoft#46080)
4aaea02 
* Updates the DOM APIs

* Tests

* Remove static abort(): AbortSignal
@orta orta mentioned this pull request Sep 27, 2021
Closed
@MattiasBuelens
Copy link
Contributor

MattiasBuelens commented Oct 2, 2021 •
edited
Loading

ReadableStream

It looks like this faulty forEach() method still appears in lib.dom.d.ts of TypeScript 4.5 beta? It is correctly removed over at TypeScript-DOM-lib-generator, so I'm not sure how it didn't make it into this PR. 😕

Looks like this change to QueuingStrategySize from microsoft/TypeScript-DOM-lib-generator#1141 also didn't make it into 4.5 beta.

@orta
Copy link
Contributor Author

orta commented Oct 4, 2021

Yeah, this feels off to me

@orta orta mentioned this pull request Oct 5, 2021
Merged
@orta
Copy link
Contributor Author

orta commented Oct 5, 2021 •
edited
Loading

Alright, the deploy to TypeScript process is now completely automated which mostly drops human error from the process. #46222 contains the up-to-date DOM changes which are mentioned above (and I've updated the README table in the DOM-lib-generator to reflect the actual version shipped)

@cameron-martin cameron-martin mentioned this pull request Oct 27, 2021
Closed
@jakebailey jakebailey mentioned this pull request Jul 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@orta orta

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orta @typescript-bot @MattiasBuelens @sandersn