-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in
operator typeguard can widen types
#46403
Conversation
in
operator typeguard now can widen typesin
operator typeguard can widen types
I have signed the CLA, however, I have no idea what to do with the code that is not my own - my layman's interpretation of the CLA is that if @ShuiRuTian signed the CLA as well, than it should all be OK. However, I can't check that he did. |
Hi, @weswigham |
superseded by #50666 ? |
Yes, superseded. For some (unsolicited) feedback, it's a pretty demotivating contributor experience to have a PR sit and wait for feedback/merge for half a year only to be re-implemented and superseded by a different PR from a project member. With that said, the other PR is pretty clearly much more expansive and definitely an improvement over this one... |
Fixes #21732
This PR is a continuation of #39746 - thanks @ShuiRuTian for his work. I have made the branch up-to-date with
main
and fixed new test breakages. As I am not the original author of most of the changes, I would greatly appreciate a review either from @ShuiRuTian or the maintainers of TS.Submission containing materials of a third party: @ShuiRuTian
Please verify that:
Backlog
milestone (required)main
branchgulp runtests
locally