Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: make colon always terminate in conditional expression on true side #48792

Closed

Conversation

jakebailey
Copy link
Member

This is #48791 but we only do this when we're on the true side of a conditional expression.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 20, 2022
@jakebailey

This comment was marked as outdated.

@typescript-bot

This comment was marked as outdated.

@jakebailey jakebailey added the Experiment A fork with an experimental idea which might not make it into master label Apr 20, 2022
@jakebailey jakebailey force-pushed the strict-conditional-parens-2 branch from 47afffd to 805a61d Compare April 20, 2022 23:19
@jakebailey
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 20, 2022

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 805a61d. You can monitor the build here.

@typescript-bot

This comment was marked as outdated.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 20, 2022

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/124814/artifacts?artifactName=tgz&fileId=983BA5D8104421CC16F122353A66CA81CB1ACEC564815EA4E9C1A05B5EE1379602&fileName=/typescript-4.7.0-insiders.20220420.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.7.0-pr-48792-5".;

@jakebailey
Copy link
Member Author

Demo: Playground Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team Experiment A fork with an experimental idea which might not make it into master For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants