Add tests case for function check type being correctly paranthesized in quick info #48836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #48729
I've noticed that this already works in nightly and narrowed it down to
4.7.0-dev.20220406
, see the playground.Then I was able to bisect this to 7da80d7 introduced by #48112 . I think that the improvement comes from refactoring common
parenthesizeMemberOfConditionalType
into specialized functions likeparenthesizeCheckTypeOfConditionalType
& co.I didn't see any specific test case added/adjusted in this PR that would be specific to this situation so I've decided to add one, cc @rbuckton