Infer rest type without using assignContextualParameterTypes #49740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
commented
Jun 29, 2022
jakebailey
commented
Jun 29, 2022
tests/baselines/reference/lambdaParameterWithTupleArgsHasCorrectAssignability.types
Outdated
Show resolved
Hide resolved
jakebailey
commented
Jun 29, 2022
tests/baselines/reference/lambdaParameterWithTupleArgsHasCorrectAssignability.types
Outdated
Show resolved
Hide resolved
weswigham
approved these changes
Jun 29, 2022
|
Huh, fails in ci for some reason |
|
Oh, because it's wrong and I didn't notice because I was debugging one test and forgot to run the whole suite :( |
|
Okay, I think it's better now; all of the other changes disappeared. |
aroramrinaal
approved these changes
Jun 30, 2022
weswigham
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49383
It was suspicious to me that
assignContextualParameterTypeswas being called here wheninferFromAnnotatedParameters's only caller will always immediately callassignContextualParameterTypesagain, which means you're pretty much guaranteed to hit the debug assert for a duplicateassignParameterType.It looks like all that this was doing was assigning the rest type to the signature, then picking it back out again to pass toinferTypes, so just don't do that, instead obtaining the type directly. The caller will callassignContextualParameterTypesto eventually assign it, and the code surrounding this manages just fine withoutassignContextualParameterTypes.Move the code entirely out of
inferFromAnnotatedParametersand don't callassignContextualParameterTypes; the code that was added in #30114 has nothing to do with annotated parameters.