More did-you-mean errors on classes in plain JS

[sandersn]

Classes

• that are declared with class declarations or expressions, but not
  constructor functions
• and which have nothing in their heritage clauses

Now provide spelling suggestions on misspelled property accesses.

Because of JS support for assignment-as-declaration, it's still easy to mistakenly declare a property with a typo and not get any suggestions.

I'm not sure this is a great idea; I'm going to run user tests and see how they look.

Fixes #45479

[sandersn]

@typescript-bot run dt
@typescript-bot user test this

[typescript-bot]

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at c850390. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at c850390. You can monitor the build here.

[typescript-bot]

@sandersn
Great news! no new errors were found between main..refs/pull/49827/merge

[sandersn]

TODO: This should probably skip decorated classes too

[sandersn]

@typescript-bot test top100
@typescript-bot user test this

[typescript-bot]

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at ce47269. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at ce47269. You can monitor the build here.

Update: The results are in!

[sandersn]

I think this is ready to review, but unless I can think of a better way to test it, I don't want to put it in 5.2 beta; right now my testing plan is to have real people to use and complain if the errors are too much.

Any other ideas? I guess I could artificially turn this on for more file types, but I don't know of any good source of code with typos in it. Maybe I could download random npm packages.

[typescript-bot]

@sandersn Here are the results of running the user test suite comparing main and refs/pull/49827/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Unknown failure"
• 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

• [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-49827/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
• [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

[andrewbranch]

This seems fairly conservative, and I can’t think of a great way to test it on real code, since typos tend to get fixed eventually.

[typescript-bot]

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/49827/merge:

Everything looks good!

[sandersn]

Yeah, I agree. I'll merge it when 5.3 development starts.

[sandersn]

Later: Or, it turns out, just before it ends.