lib Fix Part 5/6 – Function.{apply, bind}

[graphemecluster]

General Information

PR separated out from #49855, because there might be some members expecting smaller PRs. As mentioned in the comments from the big PR, whether to review a single, large PR or 6 smaller PRs is up to the TypeScript Team to decide. I couldn't have found a better way for this; hopefully this will not bring any trouble to the Team.

This PR partially addresses #49773.
For details and the track list about the changes, please see #49773.

Part 5/6, Function.{apply, bind}

The checker is now able to handle tuple with multiple variadics, thus this change.

[sandersn]

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test top100

[typescript-bot]

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 793adeb. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 793adeb. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 793adeb. You can monitor the build here.

[typescript-bot]

@sandersn Here are the results of running the user test suite comparing main and refs/pull/50453/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

• [NEW] error TS2345: Argument of type 'Node | undefined' is not assignable to parameter of type 'Node'.
  • lib/MultiCompiler.js#L472
• [NEW] error TS2345: Argument of type 'ServerOptions | ServerOptions | undefined' is not assignable to parameter of type 'ServerOptions'.
  • lib/hmr/lazyCompilationBackend.js#L39
• [MISSING] error TS2769: No overload matches this call.
  • lib/MultiCompiler.js#L472
  • lib/hmr/lazyCompilationBackend.js#L39

[typescript-bot]

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/50453/merge:

Everything looks good!

[sandersn]

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test top100

[typescript-bot]

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at f435fad. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at f435fad. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at f435fad. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@sandersn Here are the results of running the user test suite comparing main and refs/pull/50453/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

• [NEW] error TS2345: Argument of type 'Node | undefined' is not assignable to parameter of type 'Node'.
  • lib/MultiCompiler.js#L472
• [NEW] error TS2345: Argument of type 'ServerOptions<...> | ServerOptions<...> | undefined' is not assignable to parameter of type 'ServerOptions<typeof IncomingMessage, typeof ServerResponse>'.
  • lib/hmr/lazyCompilationBackend.js#L39
• [MISSING] error TS2769: No overload matches this call.
  • lib/MultiCompiler.js#L472
  • lib/hmr/lazyCompilationBackend.js#L39

[typescript-bot]

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/50453/merge:

Everything looks good!

[typescript-bot]

Hey @sandersn, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[sandersn]

The webpack failures are just a diff in the error message; the new message is better because there are fewer overloads.

[sandersn]

Addresses #52956

I think this looks good enough to ship without a design meeting discussion. One more test though:

@typescript-bot run dt

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at f435fad. You can monitor the build here.

Update: The results are in!

[sandersn]

Argh I meant @typescript-bot test this

[typescript-bot]

Heya @sandersn, I've started to run the extended test suite on this PR at f435fad. You can monitor the build here.

[typescript-bot]

Hey @sandersn, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[sandersn]

Hm, I guess RWC didn't work. I think I'll merge this anyway.