Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc Type Annotations @typedef Codefix #51428

Closed
wants to merge 108 commits into from
Closed

JSDoc Type Annotations @typedef Codefix #51428

wants to merge 108 commits into from

Conversation

brendaHuang
Copy link
Contributor

@brendaHuang brendaHuang commented Nov 7, 2022

Fixes #
#50644

typescript-bot and others added 30 commits October 3, 2022 06:13
…xtual typing position causes language service error on all literal type references (#50757)

* fix(50750): skip unbound symbols from JSDoc tags in typescript

* skip contextual type checking in JsDoc for TypeScript files
* Fix crash in goto-def on `@override`

When the base type is not defined, getDefinitionFromOverriddenMember
will have its type as errorType, which has no symbol. The error handling
previously only handled the case of no baseType at all -- which I'm not
sure ever actually happens.

* Improve checking

1. getTypeAtLocation never returns undefined, only errorType, so check for that.
2. Return directly after missing baseTypeNode instead of continuing to return later.

* Experiment with making goto-def on `override` more consistent

* Unify static/instance node->symbol->type path

* Make getSymbolAtLocation support class expressions

and parenthesized expressions

* Revert "Make getSymbolAtLocation support class expressions"

This reverts commit 4c1b031.

* fix semicolon lint
…unctionality of Date.now() (#50630)

* Adding a JSDoc comment to the es5 type declarations to describe the functionality of Date.now() & updating baselines (50565)

* Update the Date.now() type declaration description

Updating the Date.now() type declaration description to make it clearer and more accurate.

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
…51063)

* Baseline config tests for easy validation

* Refactor

* Fix incorrect pick

* Dont print unnecessary plugin host not implemented msg in logs
)

* Add test where current plugins dont get reset when reloading config file

* Reset loaded plugins when reloading configured project and closing project
…51050)

* Fix isGenericMappedType, getTemplateLiteralType, getStringMappingType

* Accept new baselines

* Add regression tests

* Fix comment
* add option to exclude lineText from the response

* add comments

* update baseline
…51107)

* fix(51100): ensure tsserver shuts down when parent process is killed

When using IPC channel (`--useNodeIpc`) for communicating with tsserver,
the child tsserver process did not shut down on parent process disconnecting
(for example due to it being killed).

Call exit() on IPC disconnect, same as stdio-based communication did
when pipe to parent process was destroyed.

* don't duplicate inherited method
… info (#50904)

* Add test case to check for the propogation of @Deprecation tag to multiple overloads

* Implement filter to only include @deprecated tag in first signature after JSDoc comment
* Fix isExhaustiveSwitchStatement to better handle circularities

* Add regression test
…51140)

* Check nested weak types in intersections on target side of relation

* Add regression tests

* Move logic from isRelatedTo to structuredTypeRelatedTo

* Fix lint error

* Add additional test
typescript-bot and others added 26 commits October 29, 2022 06:07
…xpecting to find libFile and remove incorrect affects flag from listFilesOnly (#51243)

* Fix the existing test

* Remove affectsEmit from listFilesOnly
…eld is set correctly (#50977)

* Add test that fails

* Handle impliedNodeFormat when handling sourceFileCache
Fixes #50872

* Revert the fix

* Make sure impliedNodeFormat is set for the sourceFile

* Revert "Make sure impliedNodeFormat is set for the sourceFile"

This reverts commit 651a47f.

* Revert "Revert the fix"

This reverts commit 5c98b9c.

* Swap the keys for map
…meters (#50976)

* Fix #50869, only cache calculated type for non-context sensitive parameters

* Simplify check, update comment
* fix services' type's isLiteral

* update literal completions tests

* remove booleans from literals
…g incorrectly assignable to shorter variadic tuples (#50218)
* Fix enum classification and evaluation

* References in literal enums must be to other enum members

* Accept new baselines

* Unify enum types + template literal constant expressions

* Accept new baselines

* Fix fourslash tests

* Fix new compiler errors

* Fix lint error

* Accept new API baselines

* Fix test

* Better error message + consistently check enum initializers

* Accept new baselines
…ed anyways (#51379)

* Convert some of the tests to baselines

* There is no use of creating reference map with --out since its not used anyways.
The changes to affectedFileList returned should be intended since --out needs saving just one file for correct output and not both
* Change criteria for reducing intersections in type inference

* Add regression test
…in --build scenario) and some reporting cleanup (#51403)

* Emit diagnostics when just manipuating bundle at that time itself
[4:04:42 PM] Updating output of project '/TypeScript/src/tsserver/tsconfig.json'...

Memory used:        581215K
transformTime time:   0.01s
Source Map time:      0.35s
commentTime time:     0.00s
printTime time:       0.58s
Emit time:            0.90s
I/O Write time:       0.01s
Total time:           0.90s

* Pull out getSourceFile and writeFile in a function

* Fix incorrect solutionPerformance reporting in watch mode

* Remove unnecessary build info read when host can give cached buildInfo

* Simplify overloads

* Accept API change
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 7, 2022
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@brendaHuang brendaHuang marked this pull request as draft November 7, 2022 17:28
@brendaHuang brendaHuang closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.