-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSDoc Type Annotations @typedef Codefix #51428
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtual typing position causes language service error on all literal type references (#50757) * fix(50750): skip unbound symbols from JSDoc tags in typescript * skip contextual type checking in JsDoc for TypeScript files
* Fix crash in goto-def on `@override` When the base type is not defined, getDefinitionFromOverriddenMember will have its type as errorType, which has no symbol. The error handling previously only handled the case of no baseType at all -- which I'm not sure ever actually happens. * Improve checking 1. getTypeAtLocation never returns undefined, only errorType, so check for that. 2. Return directly after missing baseTypeNode instead of continuing to return later. * Experiment with making goto-def on `override` more consistent * Unify static/instance node->symbol->type path * Make getSymbolAtLocation support class expressions and parenthesized expressions * Revert "Make getSymbolAtLocation support class expressions" This reverts commit 4c1b031. * fix semicolon lint
…unctionality of Date.now() (#50630) * Adding a JSDoc comment to the es5 type declarations to describe the functionality of Date.now() & updating baselines (50565) * Update the Date.now() type declaration description Updating the Date.now() type declaration description to make it clearer and more accurate. Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
…t for tsserver and tsc (#51044)
…51063) * Baseline config tests for easy validation * Refactor * Fix incorrect pick * Dont print unnecessary plugin host not implemented msg in logs
* add option to exclude lineText from the response * add comments * update baseline
…onditional expression with template strings (#51082)
…51107) * fix(51100): ensure tsserver shuts down when parent process is killed When using IPC channel (`--useNodeIpc`) for communicating with tsserver, the child tsserver process did not shut down on parent process disconnecting (for example due to it being killed). Call exit() on IPC disconnect, same as stdio-based communication did when pipe to parent process was destroyed. * don't duplicate inherited method
… info (#50904) * Add test case to check for the propogation of @Deprecation tag to multiple overloads * Implement filter to only include @deprecated tag in first signature after JSDoc comment
* Fix isExhaustiveSwitchStatement to better handle circularities * Add regression test
…51140) * Check nested weak types in intersections on target side of relation * Add regression tests * Move logic from isRelatedTo to structuredTypeRelatedTo * Fix lint error * Add additional test
…opefully is no longer required (#51151)
…xpecting to find libFile and remove incorrect affects flag from listFilesOnly (#51243) * Fix the existing test * Remove affectsEmit from listFilesOnly
…eld is set correctly (#50977) * Add test that fails * Handle impliedNodeFormat when handling sourceFileCache Fixes #50872 * Revert the fix * Make sure impliedNodeFormat is set for the sourceFile * Revert "Make sure impliedNodeFormat is set for the sourceFile" This reverts commit 651a47f. * Revert "Revert the fix" This reverts commit 5c98b9c. * Swap the keys for map
* fix services' type's isLiteral * update literal completions tests * remove booleans from literals
…g incorrectly assignable to shorter variadic tuples (#50218)
…e in readable baseline (#51391)
* Fix enum classification and evaluation * References in literal enums must be to other enum members * Accept new baselines * Unify enum types + template literal constant expressions * Accept new baselines * Fix fourslash tests * Fix new compiler errors * Fix lint error * Accept new API baselines * Fix test * Better error message + consistently check enum initializers * Accept new baselines
…ed anyways (#51379) * Convert some of the tests to baselines * There is no use of creating reference map with --out since its not used anyways. The changes to affectedFileList returned should be intended since --out needs saving just one file for correct output and not both
* Change criteria for reducing intersections in type inference * Add regression test
…in --build scenario) and some reporting cleanup (#51403) * Emit diagnostics when just manipuating bundle at that time itself [4:04:42 PM] Updating output of project '/TypeScript/src/tsserver/tsconfig.json'... Memory used: 581215K transformTime time: 0.01s Source Map time: 0.35s commentTime time: 0.00s printTime time: 0.58s Emit time: 0.90s I/O Write time: 0.01s Total time: 0.90s * Pull out getSourceFile and writeFile in a function * Fix incorrect solutionPerformance reporting in watch mode * Remove unnecessary build info read when host can give cached buildInfo * Simplify overloads * Accept API change
typescript-bot
added
the
For Uncommitted Bug
PR for untriaged, rejected, closed or missing bug
label
Nov 7, 2022
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#50644