Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visitEachChild not traversing all nodes #51543

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

simllll
Copy link
Contributor

@simllll simllll commented Nov 15, 2022

Fixes #51542

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 15, 2022
@simllll simllll changed the title visitEachChild not traversing all nodes fix: visitEachChild not traversing all nodes Nov 15, 2022
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 15, 2022
@rbuckton rbuckton merged commit f4ddc1a into microsoft:main Nov 15, 2022
@DanielRosenwasser
Copy link
Member

Can this be cherry-picked? Let's see.

@typescript-bot cherry-pick this to release-4.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 16, 2022

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.9 on this PR at 0772963. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.9 manually.

robert-dean added a commit to flexbase-eng/openapi-generator that referenced this pull request Nov 27, 2022
ts 4.9 has regression for microsoft/TypeScript#51543 so roll back until fix is released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.9 regression for visitEachChild
4 participants