Do not infer to mapped types from implied index signatures created by rest bindings #52632

Andarist · 2023-02-06T14:21:10Z

cc @andrewbranch , it might be interesting to you given your work on #49086

… rest bindings

jakebailey · 2023-02-07T04:41:26Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 8470be3. You can monitor the build here.

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 8470be3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 8470be3. You can monitor the build here.

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the perf test suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 8470be3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T04:41:28Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 8470be3. You can monitor the build here.

typescript-bot · 2023-02-07T04:43:26Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/145835/artifacts?artifactName=tgz&fileId=3CE1E7CDF60C71EDE447ECB5C939B7AE544A6B62E19AE2611ABD11C9EE21DAAB02&fileName=/typescript-5.0.0-insiders.20230207.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52632-9".;

typescript-bot · 2023-02-07T04:51:16Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52632/merge:

Everything looks good!

typescript-bot · 2023-02-07T04:52:35Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52632/merge:

Everything looks good!

typescript-bot · 2023-02-07T04:56:23Z

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-02-07T06:08:49Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52632

_Metric	_main	₅₂₆₃₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,868k (± 0.02%)}	_{359,905k (± 0.02%)}	_~	_359,789k	_359,962k	_{p=0.229 n=6}
_{Parse Time}	_{4.01s (± 0.79%)}	_{3.96s (± 1.22%)}	_~	_3.88s	_4.01s	_{p=0.126 n=6}
_{Bind Time}	_{1.18s (± 0.71%)}	_{1.18s (± 0.44%)}	_~	_1.17s	_1.18s	_{p=0.070 n=6}
_{Check Time}	_{8.74s (± 0.64%)}	_{8.67s (± 0.27%)}	_{-0.07s (- 0.86%)}	_8.63s	_8.69s	_{p=0.044 n=6}
_{Emit Time}	_{7.68s (± 0.94%)}	_{7.61s (± 0.64%)}	_~	_7.57s	_7.70s	_{p=0.145 n=6}
_{Total Time}	_{21.61s (± 0.65%)}	_{21.42s (± 0.38%)}	_{-0.19s (- 0.86%)}	_21.30s	_21.51s	_{p=0.037 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,249k (± 1.16%)}	_{195,124k (± 1.61%)}	_~	_192,157k	_198,093k	_{p=0.689 n=6}
_{Parse Time}	_{1.62s (± 2.08%)}	_{1.63s (± 2.03%)}	_~	_1.59s	_1.67s	_{p=0.803 n=6}
_{Bind Time}	_{0.80s (± 1.05%)}	_{0.79s (± 0.52%)}	_~	_0.79s	_0.80s	_{p=0.285 n=6}
_{Check Time}	_{9.78s (± 0.74%)}	_{9.73s (± 1.02%)}	_~	_9.61s	_9.90s	_{p=0.334 n=6}
_{Emit Time}	_{2.88s (± 4.68%)}	_{2.80s (± 0.57%)}	_~	_2.79s	_2.83s	_{p=0.086 n=6}
_{Total Time}	_{15.07s (± 1.12%)}	_{14.96s (± 0.63%)}	_~	_14.84s	_15.08s	_{p=0.128 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,999k (± 0.01%)}	_{343,986k (± 0.01%)}	_~	_343,931k	_344,058k	_{p=0.689 n=6}
_{Parse Time}	_{2.96s (± 1.10%)}	_{2.96s (± 1.08%)}	_~	_2.90s	_2.99s	_{p=1.000 n=6}
_{Bind Time}	_{1.04s (± 0.61%)}	_{1.04s (± 0.86%)}	_~	_1.03s	_1.05s	_{p=1.000 n=6}
_{Check Time}	_{7.05s (± 0.34%)}	_{7.04s (± 0.34%)}	_~	_7.00s	_7.07s	_{p=0.935 n=6}
_{Emit Time}	_{4.32s (± 0.62%)}	_{4.33s (± 0.68%)}	_~	_4.29s	_4.37s	_{p=0.294 n=6}
_{Total Time}	_{15.37s (± 0.42%)}	_{15.38s (± 0.45%)}	_~	_15.25s	_15.44s	_{p=0.688 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,395k (± 0.01%)}	_{300,408k (± 0.00%)}	_~	_300,399k	_300,424k	_{p=0.170 n=6}
_{Parse Time}	_{2.28s (± 1.56%)}	_{2.26s (± 2.25%)}	_~	_2.22s	_2.34s	_{p=0.332 n=6}
_{Bind Time}	_{1.17s (± 0.47%)}	_{1.17s (± 0.64%)}	_~	_1.16s	_1.18s	_{p=0.476 n=6}
_{Check Time}	_{6.54s (± 0.97%)}	_{6.59s (± 0.21%)}	_~	_6.57s	_6.61s	_{p=0.125 n=6}
_{Emit Time}	_{3.93s (± 0.62%)}	_{3.94s (± 0.55%)}	_~	_3.91s	_3.96s	_{p=0.677 n=6}
_{Total Time}	_{13.93s (± 0.32%)}	_{13.96s (± 0.41%)}	_~	_13.91s	_14.05s	_{p=0.571 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,861k (± 0.01%)}	_{476,854k (± 0.00%)}	_~	_476,823k	_476,890k	_{p=0.521 n=6}
_{Parse Time}	_{3.57s (± 0.71%)}	_{3.55s (± 0.85%)}	_~	_3.50s	_3.59s	_{p=0.466 n=6}
_{Bind Time}	_{0.97s (± 0.56%)}	_{0.97s (± 0.84%)}	_~	_0.96s	_0.98s	_{p=0.088 n=6}
_{Check Time}	_{17.28s (± 0.64%)}	_{17.19s (± 0.36%)}	_~	_17.13s	_17.30s	_{p=0.148 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.83s (± 0.50%)}	_{21.71s (± 0.36%)}	_~	_21.62s	_21.83s	_{p=0.128 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{549,038k (± 0.01%)}	_{549,179k (± 0.03%)}	_{+141k (+ 0.03%)}	_548,960k	_549,399k	_{p=0.045 n=6}
_{Parse Time}	_{4.56s (± 0.24%)}	_{4.56s (± 0.31%)}	_~	_4.54s	_4.58s	_{p=0.868 n=6}
_{Bind Time}	_{1.71s (± 0.71%)}	_{1.72s (± 1.13%)}	_~	_1.70s	_1.75s	_{p=0.567 n=6}
_{Check Time}	_{2.84s (± 0.69%)}	_{2.84s (± 1.11%)}	_~	_2.79s	_2.87s	_{p=0.936 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{9.20s (± 0.31%)}	_{9.20s (± 0.46%)}	_~	_9.15s	_9.26s	_{p=1.000 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,206k (± 0.01%)}	_{359,227k (± 0.01%)}	_~	_359,188k	_359,263k	_{p=0.689 n=6}
_{Parse Time}	_{4.18s (± 0.36%)}	_{4.18s (± 0.19%)}	_~	_4.17s	_4.19s	_{p=0.797 n=6}
_{Bind Time}	_{1.23s (± 0.42%)}	_{1.22s (± 0.67%)}	_~	_1.21s	_1.23s	_{p=0.523 n=6}
_{Check Time}	_{9.48s (± 0.74%)}	_{9.47s (± 0.40%)}	_~	_9.41s	_9.53s	_{p=1.000 n=6}
_{Emit Time}	_{8.08s (± 0.49%)}	_{8.06s (± 0.43%)}	_~	_8.02s	_8.10s	_{p=0.627 n=6}
_{Total Time}	_{22.98s (± 0.37%)}	_{22.93s (± 0.31%)}	_~	_22.85s	_23.02s	_{p=0.573 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,901k (± 0.04%)}	_{194,507k (± 0.67%)}	_~	_193,925k	_197,179k	_{p=0.065 n=6}
_{Parse Time}	_{1.80s (± 0.23%)}	_{1.81s (± 0.57%)}	_~	_1.79s	_1.82s	_{p=0.101 n=6}
_{Bind Time}	_{0.85s (± 1.16%)}	_{0.84s (± 1.24%)}	_~	_0.83s	_0.86s	_{p=0.673 n=6}
_{Check Time}	_{10.42s (± 0.82%)}	_{10.43s (± 0.75%)}	_~	_10.32s	_10.56s	_{p=0.810 n=6}
_{Emit Time}	_{3.07s (± 0.81%)}	_{3.06s (± 0.86%)}	_~	_3.03s	_3.10s	_{p=0.747 n=6}
_{Total Time}	_{16.14s (± 0.54%)}	_{16.14s (± 0.62%)}	_~	_15.99s	_16.30s	_{p=1.000 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,278k (± 0.01%)}	_{343,281k (± 0.01%)}	_~	_343,243k	_343,323k	_{p=0.873 n=6}
_{Parse Time}	_{3.18s (± 1.07%)}	_{3.18s (± 1.59%)}	_~	_3.09s	_3.23s	_{p=0.809 n=6}
_{Bind Time}	_{1.12s (± 0.88%)}	_{1.11s (± 0.00%)}	_~	_1.11s	_1.11s	_{p=0.073 n=6}
_{Check Time}	_{7.72s (± 0.41%)}	_{7.73s (± 0.54%)}	_~	_7.67s	_7.79s	_{p=1.000 n=6}
_{Emit Time}	_{4.53s (± 0.43%)}	_{4.55s (± 0.74%)}	_~	_4.52s	_4.61s	_{p=0.211 n=6}
_{Total Time}	_{16.55s (± 0.25%)}	_{16.57s (± 0.49%)}	_~	_16.48s	_16.68s	_{p=1.000 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,763k (± 0.00%)}	_{299,749k (± 0.00%)}	_~	_299,733k	_299,764k	_{p=0.053 n=6}
_{Parse Time}	_{2.48s (± 1.54%)}	_{2.47s (± 0.86%)}	_~	_2.44s	_2.49s	_{p=0.869 n=6}
_{Bind Time}	_{1.26s (± 0.50%)}	_{1.25s (± 0.67%)}	_~	_1.25s	_1.27s	_{p=0.226 n=6}
_{Check Time}	_{7.22s (± 0.44%)}	_{7.19s (± 0.72%)}	_~	_7.14s	_7.28s	_{p=0.335 n=6}
_{Emit Time}	_{4.23s (± 0.41%)}	_{4.23s (± 0.69%)}	_~	_4.20s	_4.27s	_{p=0.747 n=6}
_{Total Time}	_{15.18s (± 0.32%)}	_{15.14s (± 0.44%)}	_~	_15.05s	_15.22s	_{p=0.521 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,111k (± 0.00%)}	_{476,129k (± 0.01%)}	_~	_476,086k	_476,202k	_{p=0.689 n=6}
_{Parse Time}	_{3.72s (± 0.24%)}	_{3.72s (± 0.28%)}	_~	_3.70s	_3.73s	_{p=0.673 n=6}
_{Bind Time}	_{1.02s (± 0.50%)}	_{1.02s (± 0.00%)}	_~	_1.02s	_1.02s	_{p=0.174 n=6}
_{Check Time}	_{18.17s (± 0.68%)}	_{18.11s (± 0.15%)}	_~	_18.07s	_18.15s	_{p=0.226 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.92s (± 0.54%)}	_{22.85s (± 0.15%)}	_~	_22.79s	_22.89s	_{p=0.297 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,780k (± 0.03%)}	_{546,873k (± 0.01%)}	_~	_546,820k	_546,991k	_{p=0.378 n=6}
_{Parse Time}	_{4.76s (± 0.57%)}	_{4.76s (± 0.52%)}	_~	_4.73s	_4.79s	_{p=0.935 n=6}
_{Bind Time}	_{1.79s (± 5.30%)}	_{1.81s (± 4.05%)}	_~	_1.66s	_1.85s	_{p=0.803 n=6}
_{Check Time}	_{3.15s (± 3.68%)}	_{3.10s (± 2.83%)}	_~	_3.04s	_3.28s	_{p=0.360 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{9.79s (± 0.49%)}	_{9.76s (± 0.37%)}	_~	_9.72s	_9.81s	_{p=0.377 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,855k (± 0.00%)}	_{352,861k (± 0.00%)}	_~	_352,849k	_352,875k	_{p=0.375 n=6}
_{Parse Time}	_{4.25s (± 0.38%)}	_{4.25s (± 0.12%)}	_~	_4.24s	_4.25s	_{p=0.666 n=6}
_{Bind Time}	_{1.29s (± 0.40%)}	_{1.29s (± 0.63%)}	_~	_1.28s	_1.30s	_{p=0.929 n=6}
_{Check Time}	_{9.76s (± 0.68%)}	_{9.75s (± 0.42%)}	_~	_9.68s	_9.79s	_{p=0.688 n=6}
_{Emit Time}	_{8.39s (± 0.61%)}	_{8.37s (± 0.80%)}	_~	_8.29s	_8.45s	_{p=0.686 n=6}
_{Total Time}	_{23.68s (± 0.51%)}	_{23.65s (± 0.46%)}	_~	_23.49s	_23.78s	_{p=0.574 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{189,370k (± 0.76%)}	_{188,951k (± 0.08%)}	_~	_188,763k	_189,085k	_{p=0.378 n=6}
_{Parse Time}	_{1.85s (± 0.74%)}	_{1.84s (± 0.59%)}	_~	_1.82s	_1.85s	_{p=0.554 n=6}
_{Bind Time}	_{0.87s (± 1.40%)}	_{0.86s (± 0.47%)}	_~	_0.86s	_0.87s	_{p=0.527 n=6}
_{Check Time}	_{10.54s (± 0.49%)}	_{10.55s (± 0.40%)}	_~	_10.49s	_10.60s	_{p=0.870 n=6}
_{Emit Time}	_{3.44s (± 3.76%)}	_{3.26s (± 5.16%)}	_~	_3.14s	_3.50s	_{p=0.053 n=6}
_{Total Time}	_{16.70s (± 0.81%)}	_{16.51s (± 1.14%)}	_~	_16.34s	_16.76s	_{p=0.090 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,017k (± 0.00%)}	_{338,027k (± 0.01%)}	_~	_337,996k	_338,057k	_{p=0.336 n=6}
_{Parse Time}	_{3.22s (± 0.85%)}	_{3.24s (± 1.72%)}	_~	_3.19s	_3.35s	_{p=0.627 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.595 n=6}
_{Check Time}	_{8.07s (± 0.42%)}	_{8.07s (± 0.43%)}	_~	_8.02s	_8.12s	_{p=0.747 n=6}
_{Emit Time}	_{4.79s (± 0.96%)}	_{4.77s (± 0.34%)}	_~	_4.74s	_4.78s	_{p=0.369 n=6}
_{Total Time}	_{17.19s (± 0.43%)}	_{17.20s (± 0.52%)}	_~	_17.09s	_17.36s	_{p=1.000 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,572k (± 0.00%)}	_{294,597k (± 0.01%)}	_{+25k (+ 0.01%)}	_294,578k	_294,627k	_{p=0.006 n=6}
_{Parse Time}	_{2.75s (± 1.16%)}	_{2.76s (± 0.36%)}	_~	_2.75s	_2.77s	_{p=0.801 n=6}
_{Bind Time}	_{1.11s (± 0.73%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.929 n=6}
_{Check Time}	_{7.53s (± 0.50%)}	_{7.52s (± 0.41%)}	_~	_7.49s	_7.57s	_{p=0.936 n=6}
_{Emit Time}	_{4.65s (± 0.54%)}	_{4.62s (± 0.49%)}	_~	_4.60s	_4.65s	_{p=0.062 n=6}
_{Total Time}	_{16.04s (± 0.26%)}	_{16.02s (± 0.18%)}	_~	_15.99s	_16.06s	_{p=0.421 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,631k (± 0.00%)}	_{471,633k (± 0.00%)}	_~	_471,624k	_471,640k	_{p=0.936 n=6}
_{Parse Time}	_{3.96s (± 0.72%)}	_{3.93s (± 0.41%)}	_~	_3.91s	_3.96s	_{p=0.086 n=6}
_{Bind Time}	_{1.04s (± 0.39%)}	_{1.04s (± 0.53%)}	_~	_1.03s	_1.04s	_{p=0.054 n=6}
_{Check Time}	_{19.18s (± 0.55%)}	_{19.10s (± 0.51%)}	_~	_19.00s	_19.27s	_{p=0.261 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{24.18s (± 0.47%)}	_{24.07s (± 0.48%)}	_~	_23.95s	_24.28s	_{p=0.149 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,854k (± 0.01%)}	_{534,861k (± 0.01%)}	_~	_534,800k	_534,901k	_{p=0.810 n=6}
_{Parse Time}	_{5.15s (± 0.80%)}	_{5.16s (± 1.00%)}	_~	_5.10s	_5.24s	_{p=0.936 n=6}
_{Bind Time}	_{1.73s (± 0.52%)}	_{1.72s (± 0.82%)}	_~	_1.70s	_1.74s	_{p=0.250 n=6}
_{Check Time}	_{3.14s (± 0.71%)}	_{3.14s (± 0.31%)}	_~	_3.12s	_3.15s	_{p=0.866 n=6}
_{Emit Time}	_{0.10s (± 0.00%)}	_{0.10s (± 4.01%)}	_~	_0.10s	_0.11s	_{p=0.405 n=6}
_{Total Time}	_{10.12s (± 0.61%)}	_{10.12s (± 0.44%)}	_~	_10.08s	_10.19s	_{p=0.573 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₃₂	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52632

_Metric	_main	₅₂₆₃₂	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,538ms (± 1.70%)}	_{2,508ms (± 1.51%)}	_~	_2,480ms	_2,573ms	_{p=0.226 n=6}
_{Req 2 - geterr}	_{5,556ms (± 0.54%)}	_{5,562ms (± 0.27%)}	_~	_5,541ms	_5,585ms	_{p=0.378 n=6}
_{Req 3 - references}	_{370ms (± 0.77%)}	_{368ms (± 0.50%)}	_~	_365ms	_370ms	_{p=0.369 n=6}
_{Req 4 - navto}	_{284ms (± 0.36%)}	_{285ms (± 0.61%)}	_~	_282ms	_287ms	_{p=0.279 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{71ms (± 0.72%)}	_{75ms (± 4.88%)}	_{+4ms (+ 4.91%)}	_72ms	_82ms	_{p=0.007 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,752ms (± 1.42%)}	_{2,708ms (± 1.15%)}	_~	_2,661ms	_2,743ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{4,042ms (± 0.58%)}	_{4,054ms (± 0.51%)}	_~	_4,023ms	_4,087ms	_{p=0.471 n=6}
_{Req 3 - references}	_{368ms (± 1.37%)}	_{369ms (± 0.75%)}	_~	_364ms	_371ms	_{p=0.744 n=6}
_{Req 4 - navto}	_{293ms (± 0.91%)}	_{294ms (± 0.76%)}	_~	_291ms	_297ms	_{p=0.418 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{66ms (± 0.78%)}	_{66ms (± 0.62%)}	_~	_66ms	_67ms	_{p=0.595 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,489ms (± 0.64%)}	_{3,487ms (± 0.69%)}	_~	_3,465ms	_3,530ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,646ms (± 0.69%)}	_{1,650ms (± 0.72%)}	_~	_1,640ms	_1,671ms	_{p=0.688 n=6}
_{Req 3 - references}	_{104ms (± 1.61%)}	_{104ms (± 2.09%)}	_~	_101ms	_106ms	_{p=0.805 n=6}
_{Req 4 - navto}	_{360ms (± 1.11%)}	_{356ms (± 0.58%)}	_{-4ms (- 1.20%)}	_353ms	_358ms	_{p=0.036 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{445ms (± 0.95%)}	_{446ms (± 1.21%)}	_~	_439ms	_452ms	_{p=0.628 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,774ms (± 0.53%)}	_{2,778ms (± 1.00%)}	_~	_2,726ms	_2,801ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{5,923ms (± 0.72%)}	_{5,928ms (± 0.51%)}	_~	_5,883ms	_5,962ms	_{p=0.689 n=6}
_{Req 3 - references}	_{381ms (± 0.95%)}	_{380ms (± 0.96%)}	_~	_377ms	_387ms	_{p=0.685 n=6}
_{Req 4 - navto}	_{278ms (± 1.01%)}	_{278ms (± 0.90%)}	_~	_276ms	_283ms	_{p=0.936 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 1.89%)}	_{78ms (± 1.50%)}	_~	_76ms	_79ms	_{p=0.933 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,941ms (± 0.46%)}	_{2,953ms (± 0.80%)}	_~	_2,934ms	_2,996ms	_{p=0.688 n=6}
_{Req 2 - geterr}	_{4,416ms (± 0.57%)}	_{4,422ms (± 0.23%)}	_~	_4,411ms	_4,440ms	_{p=0.873 n=6}
_{Req 3 - references}	_{382ms (± 1.06%)}	_{379ms (± 0.79%)}	_~	_377ms	_385ms	_{p=0.257 n=6}
_{Req 4 - navto}	_{288ms (± 0.81%)}	_{288ms (± 0.36%)}	_~	_287ms	_290ms	_{p=0.512 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{72ms (± 1.05%)}	_{72ms (± 1.24%)}	_~	_71ms	_73ms	_{p=0.798 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,637ms (± 0.24%)}	_{3,626ms (± 0.30%)}	_~	_3,609ms	_3,637ms	_{p=0.092 n=6}
_{Req 2 - geterr}	_{1,819ms (± 1.29%)}	_{1,825ms (± 0.74%)}	_~	_1,809ms	_1,838ms	_{p=0.520 n=6}
_{Req 3 - references}	_{113ms (± 1.42%)}	_{114ms (± 0.55%)}	_~	_113ms	_115ms	_{p=0.152 n=6}
_{Req 4 - navto}	_{347ms (± 1.36%)}	_{342ms (± 1.03%)}	_{-5ms (- 1.35%)}	_339ms	_349ms	_{p=0.044 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{456ms (± 1.40%)}	_{456ms (± 0.49%)}	_~	_452ms	_458ms	_{p=0.686 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,906ms (± 0.67%)}	_{2,903ms (± 0.33%)}	_~	_2,894ms	_2,920ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{6,343ms (± 1.03%)}	_{6,322ms (± 1.16%)}	_~	_6,265ms	_6,428ms	_{p=0.748 n=6}
_{Req 3 - references}	_{390ms (± 1.04%)}	_{391ms (± 0.64%)}	_~	_387ms	_394ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{285ms (± 2.11%)}	_{285ms (± 1.47%)}	_~	_278ms	_290ms	_{p=0.809 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{93ms (± 8.64%)}	_{89ms (±11.89%)}	_~	_81ms	_107ms	_{p=0.567 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,116ms (± 0.72%)}	_{3,076ms (± 0.63%)}	_{-40ms (- 1.29%)}	_3,053ms	_3,104ms	_{p=0.008 n=6}
_{Req 2 - geterr}	_{4,723ms (± 0.51%)}	_{4,711ms (± 0.22%)}	_~	_4,691ms	_4,720ms	_{p=0.298 n=6}
_{Req 3 - references}	_{408ms (± 1.04%)}	_{410ms (± 0.97%)}	_~	_406ms	_416ms	_{p=0.332 n=6}
_{Req 4 - navto}	_{297ms (± 0.51%)}	_{295ms (± 0.55%)}	_~	_294ms	_298ms	_{p=0.185 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 3.29%)}	_{86ms (± 4.70%)}	_~	_80ms	_89ms	_{p=0.924 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,988ms (± 0.91%)}	_{3,992ms (± 0.34%)}	_~	_3,976ms	_4,010ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,809ms (± 1.11%)}	_{1,803ms (± 1.98%)}	_~	_1,768ms	_1,855ms	_{p=0.575 n=6}
_{Req 3 - references}	_{131ms (± 3.01%)}	_{129ms (± 3.03%)}	_~	_124ms	_136ms	_{p=0.687 n=6}
_{Req 4 - navto}	_{378ms (± 0.55%)}	_{375ms (± 0.26%)}	_{-3ms (- 0.66%)}	_374ms	_377ms	_{p=0.028 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{476ms (± 1.81%)}	_{467ms (± 2.58%)}	_~	_454ms	_482ms	_{p=0.145 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₃₂	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52632

_Metric	_main	₅₂₆₃₂	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.26ms (± 0.20%)}	_{142.68ms (± 0.17%)}	_{+0.42ms (+ 0.30%)}	_141.80ms	_144.92ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.84ms (± 0.17%)}	_{227.63ms (± 0.26%)}	_{+0.79ms (+ 0.35%)}	_226.16ms	_233.31ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.85ms (± 0.19%)}	_{229.16ms (± 0.22%)}	_{+0.30ms (+ 0.13%)}	_227.83ms	_236.17ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.52ms (± 0.19%)}	_{209.60ms (± 0.18%)}	_{+0.08ms (+ 0.04%)}	_208.69ms	_214.99ms	_{p=0.009 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₃₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-02-07T06:22:34Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52632/merge:

Everything looks good!

typescript-bot · 2023-02-07T06:33:17Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52632/merge:

Something interesting changed - please have a look.

Details

apache/echarts

⚠️ Note that built also had errors ⚠️

Req #21489 - completionInfo
    at getTextOfPropertyName (/typescript-main/built/local/tsserver.js:15718:16)
    at Object.getMemberOverrideModifierStatus (/typescript-main/built/local/tsserver.js:81902:51)
    at /typescript-main/built/local/tsserver.js:148417:43
    at Object.addNewNodeForMemberSymbol (/typescript-main/built/local/tsserver.js:145975:7)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148398:22)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148295:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148834:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147962:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147784:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #21489 - completionInfo
    at getTextOfPropertyName (/typescript-52632/built/local/tsserver.js:15718:16)
    at Object.getMemberOverrideModifierStatus (/typescript-52632/built/local/tsserver.js:81908:51)
    at /typescript-52632/built/local/tsserver.js:148423:43
    at Object.addNewNodeForMemberSymbol (/typescript-52632/built/local/tsserver.js:145981:7)
    at getEntryForMemberCompletion (/typescript-52632/built/local/tsserver.js:148404:22)
    at createCompletionEntry (/typescript-52632/built/local/tsserver.js:148301:64)
    at getCompletionEntriesFromSymbols (/typescript-52632/built/local/tsserver.js:148840:19)
    at completionInfoFromData (/typescript-52632/built/local/tsserver.js:147968:23)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147790:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/apache.echarts.rawError.txt in the artifact folder

Last few requests

{"seq":21486,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":124,"offset":8,"entryNames":["@abstract"]}}
{"seq":21487,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":132,"offset":49,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":21488,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":132,"offset":49,"entryNames":["readonly"]}}
{"seq":21489,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":151,"offset":45,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

git clone https://github.com/apache/echarts --recurse-submodules
In dir echarts, run git reset --hard 8120aaba4b523e8dee1aca0f8089d36c5096f0e5
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir echarts, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
2. In dir echarts/test/runTest, run npm install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
Back in the initial folder, download RepoResults1/apache.echarts.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./echarts ./apache.echarts.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

balena-io/etcher

⚠️ Note that built also had errors ⚠️

Req #744 - completionInfo
    at getMembersOfSymbol (/typescript-main/built/local/tsserver.js:56507:19)
    at getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode (/typescript-main/built/local/tsserver.js:61285:11)
    at getTypeFromTypeNodeWorker (/typescript-main/built/local/tsserver.js:61653:16)
    at getTypeFromTypeNode (/typescript-main/built/local/tsserver.js:61579:41)
    at map (/typescript-main/built/local/tsserver.js:2512:19)
    at typeArgumentsFromTypeReferenceNode (/typescript-main/built/local/tsserver.js:59111:12)
    at getTypeFromClassOrInterfaceReference (/typescript-main/built/local/tsserver.js:58796:92)
    at getTypeReferenceType (/typescript-main/built/local/tsserver.js:58922:14)
    at getTypeFromTypeReference (/typescript-main/built/local/tsserver.js:59098:18)
    at getTypeParametersForTypeReference (/typescript-main/built/local/tsserver.js:78432:18)
    at getTypeArgumentConstraint (/typescript-main/built/local/tsserver.js:78476:28)
    at Object.getTypeArgumentConstraint (/typescript-main/built/local/tsserver.js:47127:22)
    at getConstraintOfTypeArgumentProperty (/typescript-main/built/local/tsserver.js:150796:20)
    at tryGetObjectTypeLiteralInTypeArgumentCompletionSymbols (/typescript-main/built/local/tsserver.js:150011:35)
    at tryGetGlobalSymbols (/typescript-main/built/local/tsserver.js:149654:20)
    at getCompletionData (/typescript-main/built/local/tsserver.js:149421:10)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147766:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #744 - completionInfo
    at getMembersOfSymbol (/typescript-52632/built/local/tsserver.js:56507:19)
    at getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode (/typescript-52632/built/local/tsserver.js:61285:11)
    at getTypeFromTypeNodeWorker (/typescript-52632/built/local/tsserver.js:61653:16)
    at getTypeFromTypeNode (/typescript-52632/built/local/tsserver.js:61579:41)
    at map (/typescript-52632/built/local/tsserver.js:2512:19)
    at typeArgumentsFromTypeReferenceNode (/typescript-52632/built/local/tsserver.js:59111:12)
    at getTypeFromClassOrInterfaceReference (/typescript-52632/built/local/tsserver.js:58796:92)
    at getTypeReferenceType (/typescript-52632/built/local/tsserver.js:58922:14)
    at getTypeFromTypeReference (/typescript-52632/built/local/tsserver.js:59098:18)
    at getTypeParametersForTypeReference (/typescript-52632/built/local/tsserver.js:78438:18)
    at getTypeArgumentConstraint (/typescript-52632/built/local/tsserver.js:78482:28)
    at Object.getTypeArgumentConstraint (/typescript-52632/built/local/tsserver.js:47127:22)
    at getConstraintOfTypeArgumentProperty (/typescript-52632/built/local/tsserver.js:150802:20)
    at tryGetObjectTypeLiteralInTypeArgumentCompletionSymbols (/typescript-52632/built/local/tsserver.js:150017:35)
    at tryGetGlobalSymbols (/typescript-52632/built/local/tsserver.js:149660:20)
    at getCompletionData (/typescript-52632/built/local/tsserver.js:149427:10)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147772:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults3/balena-io.etcher.rawError.txt in the artifact folder

Last few requests

{"seq":741,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":116,"offset":4,"entryNames":["@abstract"]}}
{"seq":742,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":117,"offset":4}}
{"seq":743,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":118,"offset":4}}
{"seq":744,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":118,"offset":53,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

git clone https://github.com/balena-io/etcher --recurse-submodules
In dir etcher, run git reset --hard 748f9d9147a8f9a4983142f53a9e5c721336b8c0
In dir etcher, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
Back in the initial folder, download RepoResults3/balena-io.etcher.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./etcher ./balena-io.etcher.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

codex-team/editor.js

⚠️ Note that built also had errors ⚠️

Req #3336 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-main/built/local/tsserver.js:140805:13)
    at /typescript-main/built/local/tsserver.js:146539:38
    at importSymbols (/typescript-main/built/local/tsserver.js:146539:11)
    at Object.addNewNodeForMemberSymbol (/typescript-main/built/local/tsserver.js:145972:11)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148398:22)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148295:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148834:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147962:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147784:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #3336 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-52632/built/local/tsserver.js:140811:13)
    at /typescript-52632/built/local/tsserver.js:146545:38
    at importSymbols (/typescript-52632/built/local/tsserver.js:146545:11)
    at Object.addNewNodeForMemberSymbol (/typescript-52632/built/local/tsserver.js:145978:11)
    at getEntryForMemberCompletion (/typescript-52632/built/local/tsserver.js:148404:22)
    at createCompletionEntry (/typescript-52632/built/local/tsserver.js:148301:64)
    at getCompletionEntriesFromSymbols (/typescript-52632/built/local/tsserver.js:148840:19)
    at completionInfoFromData (/typescript-52632/built/local/tsserver.js:147968:23)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147790:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/codex-team.editor.js.rawError.txt in the artifact folder

Last few requests

{"seq":3333,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":30,"offset":6}}
{"seq":3334,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":30,"offset":6,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":3335,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":30,"offset":6,"entryNames":["@abstract"]}}
{"seq":3336,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":40,"offset":5,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

git clone https://github.com/codex-team/editor.js --recurse-submodules
In dir editor.js, run git reset --hard 551e3f10b92cf5f5bb4fbd95ac504a815526dc18
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir editor.js/example/tools/checklist, run yarn install --ignore-engines --ignore-scripts --silent
2. In dir editor.js/example/tools/code, run yarn install --ignore-engines --ignore-scripts --silent
3. In dir editor.js/example/tools/delimiter, run yarn install --ignore-engines --ignore-scripts --silent
4. In dir editor.js/example/tools/embed, run yarn install --ignore-engines --ignore-scripts --silent
5. In dir editor.js/example/tools/header, run yarn install --ignore-engines --ignore-scripts --silent
6. In dir editor.js/example/tools/image, run yarn install --ignore-engines --ignore-scripts --silent
7. In dir editor.js/example/tools/inline-code, run yarn install --ignore-engines --ignore-scripts --silent
8. In dir editor.js/example/tools/link, run yarn install --ignore-engines --ignore-scripts --silent
9. In dir editor.js/example/tools/list, run yarn install --ignore-engines --ignore-scripts --silent
10. In dir editor.js/example/tools/marker, run yarn install --ignore-engines --ignore-scripts --silent
11. In dir editor.js/example/tools/nested-list, run yarn install --ignore-engines --ignore-scripts --silent
12. In dir editor.js/example/tools/quote, run yarn install --ignore-engines --ignore-scripts --silent
13. In dir editor.js/example/tools/raw, run yarn install --ignore-engines --ignore-scripts --silent
14. In dir editor.js/example/tools/simple-image, run yarn install --ignore-engines --ignore-scripts --silent
15. In dir editor.js/example/tools/table, run yarn install --ignore-engines --ignore-scripts --silent
16. In dir editor.js/example/tools/text-variant-tune, run yarn install --ignore-engines --ignore-scripts --silent
17. In dir editor.js/example/tools/warning, run yarn install --ignore-engines --ignore-scripts --silent
18. In dir editor.js, run yarn install --ignore-engines --ignore-scripts --silent
19. In dir editor.js/src/tools/paragraph, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/codex-team.editor.js.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./editor.js ./codex-team.editor.js.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

facebook/jest

⚠️ Note that built also had errors ⚠️

Req #6611 - references
    at getSymbolForProgram (/typescript-main/built/local/tsserver.js:134828:19)
    at Object.updateIsDefinitionOfReferencedSymbols (/typescript-main/built/local/tsserver.js:134803:20)
    at /typescript-main/built/local/tsserver.js:176354:54
    at getReferencesWorker (/typescript-main/built/local/tsserver.js:176351:25)
    at IOSession.getReferences (/typescript-main/built/local/tsserver.js:178192:24)
    at references (/typescript-main/built/local/tsserver.js:176736:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #6611 - references
    at getSymbolForProgram (/typescript-52632/built/local/tsserver.js:134834:19)
    at Object.updateIsDefinitionOfReferencedSymbols (/typescript-52632/built/local/tsserver.js:134809:20)
    at /typescript-52632/built/local/tsserver.js:176360:54
    at getReferencesWorker (/typescript-52632/built/local/tsserver.js:176357:25)
    at IOSession.getReferences (/typescript-52632/built/local/tsserver.js:178198:24)
    at references (/typescript-52632/built/local/tsserver.js:176742:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/facebook.jest.rawError.txt in the artifact folder

Last few requests

{"seq":6608,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":46,"offset":19}}
{"seq":6609,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":68,"offset":83,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":6610,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":83,"offset":52}}
{"seq":6611,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":119,"offset":8}}

Repro Steps

git clone https://github.com/facebook/jest --recurse-submodules
In dir jest, run git reset --hard be501e1029c86f9da539e13798f8da77bb71211d
Back in the initial folder, download RepoResults1/facebook.jest.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./jest ./facebook.jest.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typeorm/typeorm

⚠️ Note that built also had errors ⚠️

Req #4739 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-main/built/local/tsserver.js:166004:13)
    at processChildNode (/typescript-main/built/local/tsserver.js:165913:9)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29433:133)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInArrayType (/typescript-main/built/local/tsserver.js:29408:12)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInConditionalType (/typescript-main/built/local/tsserver.js:29416:90)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-main/built/local/tsserver.js:29754:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165971:32)
    at /typescript-main/built/local/tsserver.js:165865:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29433:175)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165971:32)
    at /typescript-main/built/local/tsserver.js:165865:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInParameter (/typescript-main/built/local/tsserver.js:29340:177)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165971:32)
    at /typescript-main/built/local/tsserver.js:165865:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29295:14)
    at forEachChildInMethodDeclaration (/typescript-main/built/local/tsserver.js:29369:273)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at formatSpanWorker (/typescript-main/built/local/tsserver.js:165657:5)
    at /typescript-main/built/local/tsserver.js:165597:105
    at getFormattingScanner (/typescript-main/built/local/tsserver.js:164413:15)
    at Object.formatNodeGivenIndentation (/typescript-main/built/local/tsserver.js:165597:10)
    at /typescript-main/built/local/tsserver.js:148666:36
    at flatMap (/typescript-main/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-main/built/local/tsserver.js:148664:21)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148434:28)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148295:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148834:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147962:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147784:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #4739 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-52632/built/local/tsserver.js:166010:13)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165919:9)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-52632/built/local/tsserver.js:29433:133)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInArrayType (/typescript-52632/built/local/tsserver.js:29408:12)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInConditionalType (/typescript-52632/built/local/tsserver.js:29416:90)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-52632/built/local/tsserver.js:29754:10)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at processChildNodes (/typescript-52632/built/local/tsserver.js:165977:32)
    at /typescript-52632/built/local/tsserver.js:165871:9
    at visitNodes (/typescript-52632/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52632/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-52632/built/local/tsserver.js:29433:175)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at processChildNodes (/typescript-52632/built/local/tsserver.js:165977:32)
    at /typescript-52632/built/local/tsserver.js:165871:9
    at visitNodes (/typescript-52632/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52632/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInParameter (/typescript-52632/built/local/tsserver.js:29340:177)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at processChildNodes (/typescript-52632/built/local/tsserver.js:165977:32)
    at /typescript-52632/built/local/tsserver.js:165871:9
    at visitNodes (/typescript-52632/built/local/tsserver.js:29295:14)
    at forEachChildInMethodDeclaration (/typescript-52632/built/local/tsserver.js:29369:273)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at formatSpanWorker (/typescript-52632/built/local/tsserver.js:165663:5)
    at /typescript-52632/built/local/tsserver.js:165603:105
    at getFormattingScanner (/typescript-52632/built/local/tsserver.js:164419:15)
    at Object.formatNodeGivenIndentation (/typescript-52632/built/local/tsserver.js:165603:10)
    at /typescript-52632/built/local/tsserver.js:148672:36
    at flatMap (/typescript-52632/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-52632/built/local/tsserver.js:148670:21)
    at getEntryForMemberCompletion (/typescript-52632/built/local/tsserver.js:148440:28)
    at createCompletionEntry (/typescript-52632/built/local/tsserver.js:148301:64)
    at getCompletionEntriesFromSymbols (/typescript-52632/built/local/tsserver.js:148840:19)
    at completionInfoFromData (/typescript-52632/built/local/tsserver.js:147968:23)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147790:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/typeorm.typeorm.rawError.txt in the artifact folder

Last few requests

{"seq":4736,"type":"request","command":"updateOpen","arguments":{"changedFiles":[{"fileName":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","textChanges":[{"newText":" //comment","start":{"line":1,"offset":46},"end":{"line":1,"offset":46}}]}],"closedFiles":[],"openFiles":[]}}
{"seq":4737,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":7,"offset":18,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":" "}}
{"seq":4738,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":9,"offset":45,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":" "}}
{"seq":4739,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":17,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

git clone https://github.com/typeorm/typeorm --recurse-submodules
In dir typeorm, run git reset --hard 7df2ccf69d13f8f0769e614638d8badd89c181b0
Back in the initial folder, download RepoResults2/typeorm.typeorm.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./typeorm ./typeorm.typeorm.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

weswigham · 2023-03-16T17:50:03Z

@typescript-bot test top100
@typescript-bot run dt

typescript-bot · 2023-03-16T17:50:06Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-16T17:50:06Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 8470be3. You can monitor the build here.

typescript-bot · 2023-03-16T18:01:44Z

Hey @weswigham, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

jakebailey · 2023-03-16T18:02:55Z

Hm, looks like there's a conflict with main?

weswigham · 2023-03-16T18:07:46Z

Looks like it, yep.

…om-implied-index-infos-to-mapped-types

Andarist · 2023-03-19T17:29:45Z

resolved the said conflict, @jakebailey could you re-run the requested jobs?

jakebailey · 2023-03-19T17:32:51Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-03-19T17:32:53Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T17:32:53Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T17:32:53Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T17:32:53Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T17:32:53Z

Heya @jakebailey, I've started to run the extended test suite on this PR at af648b8. You can monitor the build here.

typescript-bot · 2023-03-19T17:46:29Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52632/merge:

Everything looks good!

typescript-bot · 2023-03-19T18:43:01Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52632

_Metric	_main	₅₂₆₃₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,043k (± 0.01%)}	_{361,063k (± 0.01%)}	_~	_361,009k	_361,092k	_{p=0.109 n=6}
_{Parse Time}	_{3.53s (± 0.87%)}	_{3.53s (± 0.64%)}	_~	_3.51s	_3.57s	_{p=0.685 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.19s (± 0.53%)}	_~	_1.18s	_1.20s	_{p=0.201 n=6}
_{Check Time}	_{9.48s (± 0.49%)}	_{9.45s (± 0.53%)}	_~	_9.38s	_9.50s	_{p=0.332 n=6}
_{Emit Time}	_{7.93s (± 0.82%)}	_{7.91s (± 0.97%)}	_~	_7.81s	_8.02s	_{p=0.629 n=6}
_{Total Time}	_{22.13s (± 0.53%)}	_{22.08s (± 0.43%)}	_~	_21.97s	_22.22s	_{p=0.574 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,558k (± 0.02%)}	_{193,090k (± 0.66%)}	_~	_192,494k	_195,699k	_{p=0.298 n=6}
_{Parse Time}	_{1.59s (± 0.86%)}	_{1.59s (± 0.94%)}	_~	_1.57s	_1.61s	_{p=0.933 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.784 n=6}
_{Check Time}	_{10.15s (± 0.87%)}	_{10.10s (± 0.35%)}	_~	_10.04s	_10.14s	_{p=0.259 n=6}
_{Emit Time}	_{3.00s (± 0.25%)}	_{3.01s (± 1.12%)}	_~	_2.95s	_3.05s	_{p=0.319 n=6}
_{Total Time}	_{15.56s (± 0.51%)}	_{15.52s (± 0.20%)}	_~	_15.49s	_15.56s	_{p=0.332 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,570k (± 0.01%)}	_{345,567k (± 0.01%)}	_~	_345,544k	_345,607k	_{p=0.471 n=6}
_{Parse Time}	_{2.73s (± 0.60%)}	_{2.72s (± 0.30%)}	_~	_2.71s	_2.73s	_{p=0.284 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.37%)}	_~	_1.08s	_1.09s	_{p=0.114 n=6}
_{Check Time}	_{7.70s (± 0.41%)}	_{7.70s (± 0.29%)}	_~	_7.67s	_7.73s	_{p=0.872 n=6}
_{Emit Time}	_{4.46s (± 0.49%)}	_{4.44s (± 0.70%)}	_~	_4.39s	_4.47s	_{p=0.515 n=6}
_{Total Time}	_{15.98s (± 0.35%)}	_{15.96s (± 0.25%)}	_~	_15.91s	_16.01s	_{p=0.421 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,797k (± 0.01%)}	_~	_299,768k	_299,824k	_{p=0.521 n=6}
_{Parse Time}	_{2.17s (± 0.54%)}	_{2.16s (± 0.24%)}	_~	_2.16s	_2.17s	_{p=0.191 n=6}
_{Bind Time}	_{1.24s (± 0.97%)}	_{1.23s (± 0.61%)}	_~	_1.22s	_1.24s	_{p=0.111 n=6}
_{Check Time}	_{7.17s (± 0.54%)}	_{7.15s (± 0.23%)}	_~	_7.13s	_7.17s	_{p=0.572 n=6}
_{Emit Time}	_{4.34s (± 0.63%)}	_{4.34s (± 0.42%)}	_~	_4.32s	_4.37s	_{p=1.000 n=6}
_{Total Time}	_{14.93s (± 0.24%)}	_{14.89s (± 0.23%)}	_~	_14.85s	_14.95s	_{p=0.108 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,408k (± 0.01%)}	_{476,401k (± 0.01%)}	_~	_476,348k	_476,471k	_{p=0.630 n=6}
_{Parse Time}	_{3.21s (± 0.61%)}	_{3.23s (± 0.64%)}	_~	_3.20s	_3.26s	_{p=0.413 n=6}
_{Bind Time}	_{0.95s (± 0.43%)}	_{0.95s (± 0.86%)}	_~	_0.94s	_0.96s	_{p=0.584 n=6}
_{Check Time}	_{17.91s (± 0.86%)}	_{17.90s (± 0.59%)}	_~	_17.82s	_18.08s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.08s (± 0.62%)}	_{22.08s (± 0.56%)}	_~	_21.97s	_22.29s	_{p=0.574 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,624k (± 0.02%)}	_{550,671k (± 0.02%)}	_~	_550,520k	_550,807k	_{p=0.298 n=6}
_{Parse Time}	_{3.95s (± 0.16%)}	_{3.94s (± 0.49%)}	_~	_3.92s	_3.97s	_{p=0.191 n=6}
_{Bind Time}	_{1.80s (± 0.29%)}	_{1.80s (± 0.55%)}	_~	_1.79s	_1.81s	_{p=0.348 n=6}
_{Check Time}	_{3.04s (± 0.34%)}	_{3.03s (± 0.50%)}	_~	_3.02s	_3.06s	_{p=0.565 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.88s (± 0.17%)}	_{8.87s (± 0.44%)}	_~	_8.83s	_8.92s	_{p=0.809 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₃₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-19T19:09:52Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52632/merge:

Everything looks good!

typescript-bot · 2023-03-19T19:37:59Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Do not infer to mapped types from implied index signatures created by…

8470be3

… rest bindings

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 6, 2023

andrewbranch requested a review from ahejlsberg February 7, 2023 17:19

sandersn assigned ahejlsberg Mar 7, 2023

sandersn requested a review from weswigham March 7, 2023 23:36

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 7, 2023

jakebailey closed this Mar 16, 2023

jakebailey reopened this Mar 16, 2023

Merge remote-tracking branch 'origin/main' into fix/stop-inferring-fr…

af648b8

…om-implied-index-infos-to-mapped-types

weswigham approved these changes Mar 20, 2023

View reviewed changes

weswigham merged commit a5e6dee into microsoft:main Mar 20, 2023

Do not infer to mapped types from implied index signatures created by rest bindings #52632

Do not infer to mapped types from implied index signatures created by rest bindings #52632

Conversation

Andarist commented Feb 6, 2023

jakebailey commented Feb 7, 2023

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023 • edited Loading

typescript-bot commented Feb 7, 2023

typescript-bot commented Feb 7, 2023

typescript-bot commented Feb 7, 2023

typescript-bot commented Feb 7, 2023

Compiler

TSServer

Startup

typescript-bot commented Feb 7, 2023

typescript-bot commented Feb 7, 2023

apache/echarts

Last few requests

Repro Steps

balena-io/etcher

Last few requests

Repro Steps

codex-team/editor.js

Last few requests

Repro Steps

facebook/jest

Last few requests

Repro Steps

typeorm/typeorm

Last few requests

Repro Steps

weswigham commented Mar 16, 2023

typescript-bot commented Mar 16, 2023 • edited Loading

typescript-bot commented Mar 16, 2023 • edited Loading

typescript-bot commented Mar 16, 2023

jakebailey commented Mar 16, 2023

weswigham commented Mar 16, 2023

Andarist commented Mar 19, 2023

jakebailey commented Mar 19, 2023

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023 • edited Loading

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Mar 19, 2023

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Mar 16, 2023 •

edited

Loading

typescript-bot commented Mar 16, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading