DOM update 2023-03-07 #53133

sandersn · 2023-03-07T16:23:18Z

Adds many things that are now available in Safari, but were previously Chrome-only. Unlikely to break anybody except those using shim packages from DT, and I'll update those after merging this.

Since there is a lot of new stuff here, I wanted to get it into 5.1 as early as possible.

Adds many things that are now available in Safari, but were previously Chrome-only. Unlikely to break anybody except those using shim packages from DT, and I'll update those after merging this.

sandersn · 2023-03-07T16:29:22Z

@typescript-bot run dt

typescript-bot · 2023-03-07T16:29:26Z

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 29914d4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-07T18:29:43Z

Hey @sandersn, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: dom-mediacapture-transform
Error:

Error: Errors in typescript@local for external dependencies:
../dom-webcodecs/webcodecs.generated.d.ts(132,5): error TS2687: All declarations of 'config' must have identical modifiers.
../dom-webcodecs/webcodecs.generated.d.ts(132,5): error TS2717: Subsequent property declarations must have the same type.  Property 'config' must be of type 'VideoDecoderConfig | undefined', but here has type 'VideoDecoderConfig'.
../dom-webcodecs/webcodecs.generated.d.ts(133,5): error TS2687: All declarations of 'supported' must have identical modifiers.
../dom-webcodecs/webcodecs.generated.d.ts(133,5): error TS2717: Subsequent property declarations must have the same type.  Property 'supported' must be of type 'boolean | undefined', but here has type 'boolean'.
../dom-webcodecs/webcodecs.generated.d.ts(153,5): error TS2717: Subsequent property declarations must have the same type.  Property 'keyFrame' must be of type 'boolean | undefined', but here has type 'boolean | null | undefined'.
../dom-webcodecs/webcodecs.generated.d.ts(162,5): error TS2687: All declarations of 'config' must have identical modifiers.
../dom-webcodecs/webcodecs.generated.d.ts(162,5): error TS2717: Subsequent property declarations must have the same type.  Property 'config' must be of type 'VideoEncoderConfig | undefined', but here has type 'VideoEncoderConfig'.
../dom-webcodecs/webcodecs.generated.d.ts(163,5): error TS2687: All declarations of 'supported' must have identical modifiers.
../dom-webcodecs/webcodecs.generated.d.ts(163,5): error TS2717: Subsequent property declarations must have the same type.  Property 'supported' must be of type 'boolean | undefined', but here has type 'boolean'.
../dom-webcodecs/webcodecs.generated.d.ts(369,14): error TS2717: Subsequent property declarations must have the same type.  Property 'timestamp' must be of type 'number', but here has type 'number | null'.
../dom-webcodecs/webcodecs.generated.d.ts(404,6): error TS2300: Duplicate identifier 'BitrateMode'.
../dom-webcodecs/webcodecs.generated.d.ts(406,6): error TS2300: Duplicate identifier 'AlphaOption'.
../dom-webcodecs/webcodecs.generated.d.ts(408,6): error TS2300: Duplicate identifier 'AvcBitstreamFormat'.
../dom-webcodecs/webcodecs.generated.d.ts(409,6): error TS2300: Duplicate identifier 'CodecState'.
../dom-webcodecs/webcodecs.generated.d.ts(411,6): error TS2300: Duplicate identifier 'EncodedVideoChunkType'.
../dom-webcodecs/webcodecs.generated.d.ts(413,6): error TS2300: Duplicate identifier 'LatencyMode'.
../dom-webcodecs/webcodecs.generated.d.ts(416,6): error TS2300: Duplicate identifier 'VideoPixelFormat'.
../../../../../../built/local/lib.dom.d.ts(2010,5): error TS2687: All declarations of 'config' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(2011,5): error TS2687: All declarations of 'supported' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(2040,5): error TS2687: All declarations of 'config' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(2041,5): error TS2687: All declarations of 'supported' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(19284,6): error TS2300: Duplicate identifier 'AlphaOption'.
../../../../../../built/local/lib.dom.d.ts(19295,6): error TS2300: Duplicate identifier 'AvcBitstreamFormat'.
../../../../../../built/local/lib.dom.d.ts(19298,6): error TS2300: Duplicate identifier 'BitrateMode'.
../../../../../../built/local/lib.dom.d.ts(19315,6): error TS2300: Duplicate identifier 'CodecState'.
../../../../../../built/local/lib.dom.d.ts(19327,6): error TS2300: Duplicate identifier 'EncodedVideoChunkType'.
../../../../../../built/local/lib.dom.d.ts(19354,6): error TS2300: Duplicate identifier 'LatencyMode'.
../../../../../../built/local/lib.dom.d.ts(19448,6): error TS2300: Duplicate identifier 'VideoPixelFormat'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: dom-screen-wake-lock
Error:

Error: Errors in typescript@local for external dependencies:
../../../../../../built/local/lib.dom.d.ts(19450,6): error TS2300: Duplicate identifier 'WakeLockType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: w3c-css-typed-object-model-level-1
Error:

Error: Errors in typescript@local for external dependencies:
../../../../../../built/local/lib.dom.d.ts(23,1): error TS6200: Definitions of the following identifiers conflict with those in another file: CSSStyleValue, CSSVariableReferenceValue, CSSUnparsedSegment, CSSUnparsedValue, CSSKeywordValue, CSSNumericValue, CSSUnitValue, CSSMathValue, CSSMathSum, CSSMathProduct, CSSMathNegate, CSSMathInvert, CSSMathMin, CSSMathMax, CSSNumericArray, CSSTransformValue, CSSTransformComponent, CSSTranslate, CSSRotate, CSSScale, CSSSkew, CSSSkewX, CSSSkewY, CSSPerspective, CSSMatrixComponent, CSSImageValue, StylePropertyMapReadOnly, StylePropertyMap
../../../../../../built/local/lib.dom.d.ts(177,5): error TS2687: All declarations of 'is2D' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(181,5): error TS2687: All declarations of 'angle' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(182,5): error TS2687: All declarations of 'flex' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(183,5): error TS2687: All declarations of 'frequency' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(184,5): error TS2687: All declarations of 'length' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(185,5): error TS2687: All declarations of 'percent' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(186,5): error TS2687: All declarations of 'percentHint' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(187,5): error TS2687: All declarations of 'resolution' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(188,5): error TS2687: All declarations of 'time' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(19299,6): error TS2567: Enum declarations can only merge with namespace or other enum declarations.
../../../../../../built/local/lib.dom.d.ts(19300,6): error TS2567: Enum declarations can only merge with namespace or other enum declarations.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: dom-webcodecs
Error:

Error: Errors in typescript@local for external dependencies:
../../../../../../built/local/lib.dom.d.ts(2010,5): error TS2687: All declarations of 'config' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(2011,5): error TS2687: All declarations of 'supported' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(2040,5): error TS2687: All declarations of 'config' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(2041,5): error TS2687: All declarations of 'supported' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(19284,6): error TS2300: Duplicate identifier 'AlphaOption'.
../../../../../../built/local/lib.dom.d.ts(19295,6): error TS2300: Duplicate identifier 'AvcBitstreamFormat'.
../../../../../../built/local/lib.dom.d.ts(19298,6): error TS2300: Duplicate identifier 'BitrateMode'.
../../../../../../built/local/lib.dom.d.ts(19315,6): error TS2300: Duplicate identifier 'CodecState'.
../../../../../../built/local/lib.dom.d.ts(19327,6): error TS2300: Duplicate identifier 'EncodedVideoChunkType'.
../../../../../../built/local/lib.dom.d.ts(19354,6): error TS2300: Duplicate identifier 'LatencyMode'.
../../../../../../built/local/lib.dom.d.ts(19448,6): error TS2300: Duplicate identifier 'VideoPixelFormat'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: use-color-scheme
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/use-color-scheme/use-color-scheme-tests.ts:8:1
ERROR: 8:1  expect  TypeScript@local expected type to be:
  "dark" | "light" | "no-preference"
got:
  "no-preference" | "dark" | "light"

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: dom-mediacapture-record
Error:

Error: Errors in typescript@local for external dependencies:
../../../../../../built/local/lib.dom.d.ts(19298,6): error TS2300: Duplicate identifier 'BitrateMode'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: web-animations-js
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/web-animations-js/index.d.ts:11:14
ERROR: 11:14  expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'currentTime' must be of type 'CSSNumberish | null', but here has type 'number | null'.
ERROR: 12:14  expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'timelineTime' must be of type 'CSSNumberish | null', but here has type 'number | null'.
ERROR: 23:5   expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'currentTime' must be of type 'CSSNumberish | null | undefined', but here has type 'number | null | undefined'.
ERROR: 24:5   expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'timelineTime' must be of type 'CSSNumberish | null | undefined', but here has type 'number | null | undefined'.
ERROR: 41:14  expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'currentTime' must be of type 'CSSNumberish | null', but here has type 'number | null'.
ERROR: 73:5   expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'currentTime' must be of type 'CSSNumberish | null', but here has type 'number | null'.
ERROR: 79:5   expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'startTime' must be of type 'CSSNumberish | null', but here has type 'number | null'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: webappsec-credential-management
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/webappsec-credential-management/index.d.ts:309:5
ERROR: 309:5  expect  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'mediation' must be of type 'CredentialMediationRequirement | undefined', but here has type '"required" | "optional" | "silent" | undefined'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

sandersn · 2023-03-07T21:46:08Z

Looks like the shims that are broken are:

dom-screen-wake-lock
w3c-css-typed-object-model-level-1
dom-webcodecs
dom-mediacapture-record
web-animations-js
webappsec-credential-management

Plus an $ExpectType in use-color-scheme's tests changes order because a type alias to a union of strings changes order.

DanielRosenwasser · 2023-03-09T07:41:57Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this

sandersn · 2023-03-09T16:41:09Z

Since this is additive-only, I doubt there will be any unexpected breaks. I think it's more effective to estimate the size of the break by looking at number of downloads per month for the packages:

dom-screen-wake-lock: 36,825
w3c-css-typed-object-model-level-1: 6,090
dom-webcodecs: 410,281
dom-mediacapture-record: 295,838
web-animations-js: 30,075
webappsec-credential-management: 506,854

Anybody that upgrades to 5.1 will also need to update these packages. That's a lot of downloads put all together.

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this

(I predict that we'll be disappointed with the perf results, since adding this much code is a visible drag on performance.)

typescript-bot · 2023-03-09T16:41:13Z

Heya @sandersn, I've started to run the perf test suite on this PR at 29914d4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-09T16:41:13Z

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 29914d4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-09T16:41:13Z

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 29914d4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-09T16:41:13Z

Heya @sandersn, I've started to run the extended test suite on this PR at 29914d4. You can monitor the build here.

typescript-bot · 2023-03-09T16:53:49Z

@sandersn Here are the results of running the user test suite comparing main and refs/pull/53133/merge:

Something interesting changed - please have a look.

Details

puppeteer

packages/puppeteer-core/tsconfig.json

[NEW] error TS2578: Unused '@ts-expect-error' directive.
- packages/puppeteer-core/src/common/ElementHandle.ts#L274 in packages/puppeteer-core/src/tsconfig.esm.json
- packages/puppeteer-core/src/common/ElementHandle.ts#L274 in packages/puppeteer-core/src/tsconfig.cjs.json

sandersn · 2023-03-09T17:15:58Z

user test suite failures: puppeteer has a ts-expect-error where they wanted to use a Chrome-only feature that is now available in Safari.

typescript-bot · 2023-03-09T17:37:42Z

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53133

_Metric	_main	₅₃₁₃₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{362,608k (± 0.01%)}	_{363,446k (± 0.01%)}	_{+838k (+ 0.23%)}	_363,414k	_363,470k	_{p=0.005 n=6}
_{Parse Time}	_{3.39s (± 1.03%)}	_{3.37s (± 0.86%)}	_~	_3.32s	_3.39s	_{p=0.280 n=6}
_{Bind Time}	_{1.13s (± 0.79%)}	_{1.13s (± 0.56%)}	_~	_1.12s	_1.14s	_{p=1.000 n=6}
_{Check Time}	_{8.71s (± 0.70%)}	_{8.68s (± 0.48%)}	_~	_8.62s	_8.72s	_{p=0.468 n=6}
_{Emit Time}	_{7.52s (± 0.96%)}	_{7.46s (± 0.57%)}	_~	_7.41s	_7.50s	_{p=0.064 n=6}
_{Total Time}	_{20.76s (± 0.74%)}	_{20.64s (± 0.35%)}	_~	_20.54s	_20.73s	_{p=0.170 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{190,936k (± 0.01%)}	_{192,893k (± 1.53%)}	_{+1,957k (+ 1.02%)}	_190,949k	_196,783k	_{p=0.031 n=6}
_{Parse Time}	_{1.50s (± 0.69%)}	_{1.50s (± 0.36%)}	_~	_1.50s	_1.51s	_{p=0.138 n=6}
_{Bind Time}	_{0.77s (± 0.97%)}	_{0.77s (± 0.67%)}	_~	_0.77s	_0.78s	_{p=0.784 n=6}
_{Check Time}	_{9.38s (± 0.78%)}	_{9.41s (± 0.74%)}	_~	_9.31s	_9.49s	_{p=0.573 n=6}
_{Emit Time}	_{2.72s (± 1.22%)}	_{2.72s (± 0.78%)}	_~	_2.69s	_2.75s	_{p=0.936 n=6}
_{Total Time}	_{14.38s (± 0.37%)}	_{14.41s (± 0.60%)}	_~	_14.28s	_14.51s	_{p=0.423 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{347,460k (± 0.01%)}	_{347,436k (± 0.01%)}	_~	_347,384k	_347,472k	_{p=0.298 n=6}
_{Parse Time}	_{2.58s (± 1.09%)}	_{2.59s (± 0.38%)}	_~	_2.58s	_2.60s	_{p=0.511 n=6}
_{Bind Time}	_{1.01s (± 0.63%)}	_{1.01s (± 0.63%)}	_~	_1.00s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{7.08s (± 0.46%)}	_{7.04s (± 0.64%)}	_~	_6.96s	_7.09s	_{p=0.126 n=6}
_{Emit Time}	_{4.25s (± 0.75%)}	_{4.24s (± 0.97%)}	_~	_4.19s	_4.28s	_{p=0.629 n=6}
_{Total Time}	_{14.92s (± 0.52%)}	_{14.88s (± 0.42%)}	_~	_14.78s	_14.94s	_{p=0.568 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,767k (± 0.01%)}	_{300,789k (± 0.01%)}	_~	_300,770k	_300,810k	_{p=0.093 n=6}
_{Parse Time}	_{2.06s (± 1.09%)}	_{2.06s (± 1.59%)}	_~	_2.00s	_2.09s	_{p=1.000 n=6}
_{Bind Time}	_{1.14s (± 0.66%)}	_{1.14s (± 0.71%)}	_~	_1.13s	_1.15s	_{p=0.729 n=6}
_{Check Time}	_{6.54s (± 0.25%)}	_{6.55s (± 0.44%)}	_~	_6.52s	_6.59s	_{p=0.685 n=6}
_{Emit Time}	_{3.88s (± 0.78%)}	_{3.88s (± 1.01%)}	_~	_3.82s	_3.91s	_{p=0.872 n=6}
_{Total Time}	_{13.62s (± 0.46%)}	_{13.63s (± 0.58%)}	_~	_13.49s	_13.70s	_{p=0.688 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{477,551k (± 0.02%)}	_{478,387k (± 0.00%)}	_{+836k (+ 0.18%)}	_478,356k	_478,409k	_{p=0.005 n=6}
_{Parse Time}	_{2.97s (± 2.01%)}	_{2.98s (± 2.71%)}	_~	_2.91s	_3.08s	_{p=1.000 n=6}
_{Bind Time}	_{1.01s (± 8.06%)}	_{1.00s (± 7.97%)}	_~	_0.90s	_1.08s	_{p=0.517 n=6}
_{Check Time}	_{17.22s (± 0.98%)}	_{17.04s (± 0.48%)}	_~	_16.92s	_17.16s	_{p=0.065 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.21s (± 0.81%)}	_{21.02s (± 0.40%)}	_~	_20.88s	_21.13s	_{p=0.065 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{550,416k (± 0.03%)}	_{553,233k (± 0.03%)}	_{+2,817k (+ 0.51%)}	_553,006k	_553,362k	_{p=0.005 n=6}
_{Parse Time}	_{3.79s (± 0.73%)}	_{3.77s (± 0.51%)}	_~	_3.74s	_3.79s	_{p=0.295 n=6}
_{Bind Time}	_{1.69s (± 0.71%)}	_{1.68s (± 0.45%)}	_~	_1.67s	_1.69s	_{p=0.111 n=6}
_{Check Time}	_{2.79s (± 0.63%)}	_{2.76s (± 0.53%)}	_{-0.03s (- 1.13%)}	_2.75s	_2.78s	_{p=0.018 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.36s (± 0.44%)}	_{8.30s (± 0.37%)}	_{-0.06s (- 0.74%)}	_8.27s	_8.35s	_{p=0.020 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,934k (± 0.01%)}	_{362,816k (± 0.01%)}	_{+882k (+ 0.24%)}	_362,783k	_362,857k	_{p=0.005 n=6}
_{Parse Time}	_{3.52s (± 0.34%)}	_{3.52s (± 0.70%)}	_~	_3.49s	_3.56s	_{p=0.684 n=6}
_{Bind Time}	_{1.19s (± 0.69%)}	_{1.18s (± 0.54%)}	_~	_1.17s	_1.19s	_{p=0.177 n=6}
_{Check Time}	_{9.49s (± 0.39%)}	_{9.42s (± 0.48%)}	_{-0.07s (- 0.75%)}	_9.38s	_9.50s	_{p=0.030 n=6}
_{Emit Time}	_{7.91s (± 0.30%)}	_{7.91s (± 0.36%)}	_~	_7.87s	_7.95s	_{p=0.808 n=6}
_{Total Time}	_{22.12s (± 0.12%)}	_{22.03s (± 0.31%)}	_{-0.08s (- 0.38%)}	_21.94s	_22.13s	_{p=0.036 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,284k (± 0.87%)}	_{193,798k (± 0.85%)}	_~	_192,622k	_196,046k	_{p=0.378 n=6}
_{Parse Time}	_{1.58s (± 1.01%)}	_{1.57s (± 1.04%)}	_~	_1.55s	_1.59s	_{p=0.616 n=6}
_{Bind Time}	_{0.82s (± 0.92%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.487 n=6}
_{Check Time}	_{10.14s (± 0.41%)}	_{10.11s (± 0.91%)}	_~	_10.01s	_10.24s	_{p=0.378 n=6}
_{Emit Time}	_{2.99s (± 1.03%)}	_{3.04s (± 4.17%)}	_~	_2.96s	_3.29s	_{p=1.000 n=6}
_{Total Time}	_{15.53s (± 0.26%)}	_{15.54s (± 0.79%)}	_~	_15.40s	_15.71s	_{p=1.000 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,681k (± 0.00%)}	_{346,692k (± 0.00%)}	_~	_346,671k	_346,715k	_{p=0.199 n=6}
_{Parse Time}	_{2.73s (± 0.38%)}	_{2.72s (± 0.43%)}	_~	_2.71s	_2.74s	_{p=0.117 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.47%)}	_~	_1.09s	_1.10s	_{p=1.000 n=6}
_{Check Time}	_{7.74s (± 0.34%)}	_{7.75s (± 0.35%)}	_~	_7.71s	_7.79s	_{p=0.628 n=6}
_{Emit Time}	_{4.45s (± 0.70%)}	_{4.47s (± 0.24%)}	_~	_4.45s	_4.48s	_{p=0.188 n=6}
_{Total Time}	_{16.02s (± 0.20%)}	_{16.04s (± 0.25%)}	_~	_15.99s	_16.10s	_{p=0.570 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,133k (± 0.01%)}	_{300,139k (± 0.01%)}	_~	_300,110k	_300,186k	_{p=0.936 n=6}
_{Parse Time}	_{2.17s (± 0.63%)}	_{2.17s (± 0.63%)}	_~	_2.16s	_2.20s	_{p=0.933 n=6}
_{Bind Time}	_{1.24s (± 1.14%)}	_{1.24s (± 1.74%)}	_~	_1.22s	_1.28s	_{p=0.870 n=6}
_{Check Time}	_{7.19s (± 0.33%)}	_{7.20s (± 0.41%)}	_~	_7.15s	_7.24s	_{p=0.809 n=6}
_{Emit Time}	_{4.35s (± 0.84%)}	_{4.33s (± 0.65%)}	_~	_4.31s	_4.39s	_{p=0.195 n=6}
_{Total Time}	_{14.96s (± 0.32%)}	_{14.95s (± 0.25%)}	_~	_14.90s	_14.99s	_{p=0.627 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,810k (± 0.01%)}	_{477,712k (± 0.01%)}	_{+903k (+ 0.19%)}	_477,604k	_477,762k	_{p=0.005 n=6}
_{Parse Time}	_{3.20s (± 1.36%)}	_{3.23s (± 0.66%)}	_~	_3.21s	_3.26s	_{p=0.220 n=6}
_{Bind Time}	_{0.97s (± 1.65%)}	_{0.95s (± 0.79%)}	_{-0.02s (- 2.06%)}	_0.94s	_0.96s	_{p=0.015 n=6}
_{Check Time}	_{18.21s (± 1.61%)}	_{18.10s (± 0.55%)}	_~	_18.03s	_18.30s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.39s (± 1.37%)}	_{22.28s (± 0.53%)}	_~	_22.22s	_22.52s	_{p=0.936 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{547,961k (± 0.01%)}	_{550,662k (± 0.01%)}	_{+2,702k (+ 0.49%)}	_550,566k	_550,744k	_{p=0.005 n=6}
_{Parse Time}	_{3.95s (± 0.51%)}	_{3.95s (± 0.19%)}	_~	_3.94s	_3.96s	_{p=0.935 n=6}
_{Bind Time}	_{1.79s (± 0.47%)}	_{1.79s (± 0.55%)}	_~	_1.78s	_1.81s	_{p=0.396 n=6}
_{Check Time}	_{3.00s (± 0.60%)}	_{2.99s (± 0.47%)}	_~	_2.97s	_3.01s	_{p=0.370 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.83s (± 0.46%)}	_{8.83s (± 0.30%)}	_~	_8.80s	_8.87s	_{p=1.000 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{355,748k (± 0.00%)}	_{356,647k (± 0.00%)}	_{+899k (+ 0.25%)}	_356,626k	_356,671k	_{p=0.005 n=6}
_{Parse Time}	_{3.60s (± 0.69%)}	_{3.58s (± 0.60%)}	_~	_3.56s	_3.62s	_{p=0.188 n=6}
_{Bind Time}	_{1.23s (± 0.42%)}	_{1.24s (± 0.42%)}	_{+0.01s (+ 0.82%)}	_1.23s	_1.24s	_{p=0.018 n=6}
_{Check Time}	_{9.79s (± 0.22%)}	_{9.76s (± 0.36%)}	_~	_9.69s	_9.79s	_{p=0.089 n=6}
_{Emit Time}	_{8.37s (± 0.52%)}	_{8.33s (± 0.58%)}	_~	_8.28s	_8.40s	_{p=0.293 n=6}
_{Total Time}	_{22.98s (± 0.26%)}	_{22.91s (± 0.26%)}	_~	_22.82s	_22.98s	_{p=0.077 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,937k (± 0.02%)}	_{187,946k (± 0.02%)}	_~	_187,879k	_187,967k	_{p=0.470 n=6}
_{Parse Time}	_{1.61s (± 0.39%)}	_{1.60s (± 0.39%)}	_{-0.01s (- 0.62%)}	_1.59s	_1.61s	_{p=0.031 n=6}
_{Bind Time}	_{0.85s (± 0.48%)}	_{0.85s (± 0.96%)}	_~	_0.84s	_0.86s	_{p=0.584 n=6}
_{Check Time}	_{10.21s (± 0.21%)}	_{10.19s (± 0.47%)}	_~	_10.14s	_10.25s	_{p=0.572 n=6}
_{Emit Time}	_{3.13s (± 0.79%)}	_{3.12s (± 0.72%)}	_~	_3.09s	_3.15s	_{p=0.373 n=6}
_{Total Time}	_{15.79s (± 0.15%)}	_{15.76s (± 0.36%)}	_~	_15.69s	_15.85s	_{p=0.148 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{341,702k (± 0.01%)}	_{341,695k (± 0.00%)}	_~	_341,686k	_341,709k	_{p=0.336 n=6}
_{Parse Time}	_{2.84s (± 0.65%)}	_{2.84s (± 0.81%)}	_~	_2.81s	_2.88s	_{p=1.000 n=6}
_{Bind Time}	_{1.10s (± 0.68%)}	_{1.10s (± 0.68%)}	_~	_1.09s	_1.11s	_{p=1.000 n=6}
_{Check Time}	_{8.12s (± 0.68%)}	_{8.13s (± 0.39%)}	_~	_8.07s	_8.15s	_{p=0.332 n=6}
_{Emit Time}	_{4.71s (± 0.94%)}	_{4.67s (± 0.86%)}	_~	_4.63s	_4.73s	_{p=0.170 n=6}
_{Total Time}	_{16.78s (± 0.50%)}	_{16.75s (± 0.48%)}	_~	_16.66s	_16.87s	_{p=0.520 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{295,226k (± 0.00%)}	_{295,235k (± 0.00%)}	_~	_295,227k	_295,240k	_{p=0.295 n=6}
_{Parse Time}	_{2.41s (± 1.41%)}	_{2.38s (± 0.57%)}	_~	_2.36s	_2.40s	_{p=0.462 n=6}
_{Bind Time}	_{1.07s (± 0.59%)}	_{1.07s (± 0.76%)}	_~	_1.06s	_1.08s	_{p=0.432 n=6}
_{Check Time}	_{7.49s (± 0.40%)}	_{7.50s (± 0.52%)}	_~	_7.46s	_7.54s	_{p=0.466 n=6}
_{Emit Time}	_{4.29s (± 0.64%)}	_{4.29s (± 0.61%)}	_~	_4.26s	_4.32s	_{p=1.000 n=6}
_{Total Time}	_{15.26s (± 0.42%)}	_{15.25s (± 0.30%)}	_~	_15.18s	_15.29s	_{p=0.808 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{472,427k (± 0.01%)}	_{473,284k (± 0.00%)}	_{+858k (+ 0.18%)}	_473,266k	_473,306k	_{p=0.005 n=6}
_{Parse Time}	_{3.35s (± 0.51%)}	_{3.35s (± 0.88%)}	_~	_3.32s	_3.40s	_{p=0.507 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.112 n=6}
_{Check Time}	_{19.10s (± 0.80%)}	_{19.13s (± 0.56%)}	_~	_19.03s	_19.25s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.46s (± 0.67%)}	_{23.49s (± 0.50%)}	_~	_23.38s	_23.65s	_{p=0.810 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{536,721k (± 0.00%)}	_{539,287k (± 0.00%)}	_{+2,566k (+ 0.48%)}	_539,260k	_539,322k	_{p=0.005 n=6}
_{Parse Time}	_{4.24s (± 1.11%)}	_{4.17s (± 1.98%)}	_~	_4.10s	_4.29s	_{p=0.172 n=6}
_{Bind Time}	_{1.69s (± 2.23%)}	_{1.73s (± 1.89%)}	_~	_1.68s	_1.75s	_{p=0.112 n=6}
_{Check Time}	_{3.19s (± 0.76%)}	_{3.16s (± 0.74%)}	_~	_3.13s	_3.19s	_{p=0.106 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.21s (± 0.23%)}	_{9.14s (± 0.66%)}	_~	_9.07s	_9.22s	_{p=0.054 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₁₃₃	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53133

_Metric	_main	₅₃₁₃₃	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,390ms (± 0.67%)}	_{2,383ms (± 0.58%)}	_~	_2,367ms	_2,406ms	_{p=0.296 n=6}
_{Req 2 - geterr}	_{5,366ms (± 0.35%)}	_{5,350ms (± 1.11%)}	_~	_5,285ms	_5,446ms	_{p=0.572 n=6}
_{Req 3 - references}	_{336ms (± 0.64%)}	_{337ms (± 0.51%)}	_~	_335ms	_339ms	_{p=0.366 n=6}
_{Req 4 - navto}	_{280ms (± 0.73%)}	_{281ms (± 0.42%)}	_~	_280ms	_283ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 2.63%)}	_{83ms (± 5.11%)}	_~	_77ms	_90ms	_{p=0.677 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,514ms (± 1.38%)}	_{2,514ms (± 0.81%)}	_~	_2,485ms	_2,536ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,006ms (± 0.82%)}	_{4,006ms (± 0.85%)}	_~	_3,975ms	_4,050ms	_{p=1.000 n=6}
_{Req 3 - references}	_{350ms (± 1.72%)}	_{350ms (± 1.90%)}	_~	_341ms	_357ms	_{p=0.687 n=6}
_{Req 4 - navto}	_{293ms (± 0.90%)}	_{292ms (± 0.29%)}	_~	_290ms	_292ms	_{p=0.114 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (±12.38%)}	_{78ms (± 7.76%)}	_~	_70ms	_86ms	_{p=0.872 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,041ms (± 0.98%)}	_{3,055ms (± 0.50%)}	_~	_3,030ms	_3,070ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{1,593ms (± 1.27%)}	_{1,605ms (± 1.13%)}	_~	_1,584ms	_1,631ms	_{p=0.471 n=6}
_{Req 3 - references}	_{106ms (± 1.95%)}	_{110ms (± 2.49%)}	_{+4ms (+ 3.79%)}	_108ms	_115ms	_{p=0.016 n=6}
_{Req 4 - navto}	_{359ms (± 0.72%)}	_{359ms (± 0.21%)}	_~	_358ms	_360ms	_{p=0.683 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,177 (± 0.00%)}	_{+41 (+ 1.31%)}	_3,177	_3,177	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{423ms (± 0.98%)}	_{422ms (± 1.03%)}	_~	_415ms	_427ms	_{p=0.747 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,515ms (± 0.80%)}	_{2,511ms (± 0.67%)}	_~	_2,485ms	_2,532ms	_{p=0.687 n=6}
_{Req 2 - geterr}	_{5,741ms (± 0.47%)}	_{5,765ms (± 0.59%)}	_~	_5,716ms	_5,797ms	_{p=0.230 n=6}
_{Req 3 - references}	_{347ms (± 0.54%)}	_{348ms (± 0.62%)}	_~	_345ms	_350ms	_{p=0.512 n=6}
_{Req 4 - navto}	_{278ms (± 0.96%)}	_{279ms (± 1.31%)}	_~	_275ms	_286ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 0.70%)}	_{74ms (± 1.58%)}	_~	_73ms	_76ms	_{p=0.523 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,699ms (± 0.71%)}	_{2,682ms (± 0.72%)}	_~	_2,661ms	_2,714ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{4,365ms (± 0.49%)}	_{4,379ms (± 0.35%)}	_~	_4,359ms	_4,404ms	_{p=0.423 n=6}
_{Req 3 - references}	_{358ms (± 0.58%)}	_{362ms (± 1.62%)}	_~	_357ms	_370ms	_{p=0.193 n=6}
_{Req 4 - navto}	_{290ms (± 0.89%)}	_{290ms (± 0.36%)}	_~	_289ms	_292ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 5.05%)}	_{77ms (± 3.76%)}	_~	_74ms	_81ms	_{p=0.418 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,178ms (± 0.64%)}	_{3,213ms (± 0.66%)}	_{+35ms (+ 1.09%)}	_3,190ms	_3,252ms	_{p=0.031 n=6}
_{Req 2 - geterr}	_{1,745ms (± 1.12%)}	_{1,744ms (± 0.57%)}	_~	_1,733ms	_1,756ms	_{p=0.936 n=6}
_{Req 3 - references}	_{115ms (± 1.35%)}	_{118ms (± 1.02%)}	_{+3ms (+ 2.90%)}	_117ms	_120ms	_{p=0.007 n=6}
_{Req 4 - navto}	_{344ms (± 0.66%)}	_{345ms (± 0.32%)}	_~	_343ms	_346ms	_{p=0.219 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,177 (± 0.00%)}	_{+41 (+ 1.31%)}	_3,177	_3,177	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{434ms (± 1.21%)}	_{431ms (± 1.41%)}	_~	_422ms	_438ms	_{p=0.517 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,593ms (± 0.77%)}	_{2,597ms (± 0.39%)}	_~	_2,579ms	_2,607ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{6,134ms (± 0.52%)}	_{6,142ms (± 0.44%)}	_~	_6,112ms	_6,181ms	_{p=0.936 n=6}
_{Req 3 - references}	_{367ms (± 0.90%)}	_{363ms (± 0.50%)}	_{-4ms (- 1.00%)}	_361ms	_366ms	_{p=0.043 n=6}
_{Req 4 - navto}	_{278ms (± 0.55%)}	_{283ms (± 1.26%)}	_{+5ms (+ 1.80%)}	_277ms	_287ms	_{p=0.029 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{102ms (± 1.19%)}	_{96ms (± 6.14%)}	_~	_89ms	_103ms	_{p=0.104 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,816ms (± 0.39%)}	_{2,814ms (± 0.55%)}	_~	_2,800ms	_2,837ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,625ms (± 2.64%)}	_{4,598ms (± 2.68%)}	_~	_4,425ms	_4,686ms	_{p=0.230 n=6}
_{Req 3 - references}	_{392ms (± 7.55%)}	_{390ms (± 7.86%)}	_~	_367ms	_431ms	_{p=0.375 n=6}
_{Req 4 - navto}	_{291ms (± 0.67%)}	_{290ms (± 0.72%)}	_~	_286ms	_291ms	_{p=0.191 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 8.41%)}	_{88ms (±11.06%)}	_~	_81ms	_100ms	_{p=1.000 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,506ms (± 0.64%)}	_{3,518ms (± 0.48%)}	_~	_3,489ms	_3,532ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{1,859ms (± 0.44%)}	_{1,858ms (± 0.79%)}	_~	_1,829ms	_1,870ms	_{p=1.000 n=6}
_{Req 3 - references}	_{125ms (± 1.18%)}	_{125ms (± 0.51%)}	_~	_124ms	_126ms	_{p=0.737 n=6}
_{Req 4 - navto}	_{374ms (± 0.47%)}	_{368ms (± 0.36%)}	_{-7ms (- 1.74%)}	_366ms	_370ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,177 (± 0.00%)}	_{+41 (+ 1.31%)}	_3,177	_3,177	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{452ms (± 1.11%)}	_{450ms (± 1.35%)}	_~	_443ms	_457ms	_{p=0.810 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₁₃₃	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53133

_Metric	_main	₅₃₁₃₃	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.42ms (± 0.22%)}	_{141.90ms (± 0.23%)}	_{+0.48ms (+ 0.34%)}	_140.96ms	_144.98ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.79ms (± 0.33%)}	_{227.23ms (± 0.21%)}	_{+0.43ms (+ 0.19%)}	_225.98ms	_232.81ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{229.76ms (± 0.34%)}	_{229.31ms (± 0.24%)}	_{-0.44ms (- 0.19%)}	_227.96ms	_235.25ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{210.64ms (± 0.33%)}	_{210.25ms (± 0.28%)}	_{-0.38ms (- 0.18%)}	_208.81ms	_219.24ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₁₃₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

sandersn · 2023-03-09T17:49:10Z

xstate check time gets 1% better on a change that should not affect checking at all.

jakebailey · 2023-03-09T17:51:20Z

Random noise is still possible, I'm afraid :(

@typescript-bot test this

jakebailey · 2023-03-09T18:03:31Z

@typescript-bot test this

typescript-bot · 2023-03-09T18:03:34Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 29914d4. You can monitor the build here.

typescript-bot · 2023-03-09T18:17:17Z

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/53133/merge:

Everything looks good!

jakebailey · 2023-03-09T18:21:21Z

@typescript-bot test this

typescript-bot · 2023-03-09T18:21:23Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 29914d4. You can monitor the build here.

sandersn · 2023-03-09T19:00:05Z

RWC tests are fine -- no new failures, just some messages about missing even more properties.

sandersn · 2023-03-09T19:36:18Z

@saschanaz Thanks so much for your work in making these types available to Typescript.

saschanaz · 2023-03-09T20:23:11Z

Yay, and also thanks to the people who maintain the data in BCD! @queengooborg @gsnedders

This change was added in microsoft/TypeScript#53133

DOM update 2023-03-07

29914d4

Adds many things that are now available in Safari, but were previously Chrome-only. Unlikely to break anybody except those using shim packages from DT, and I'll update those after merging this.

typescript-bot assigned sandersn Mar 7, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 7, 2023

sandersn requested a review from DanielRosenwasser March 7, 2023 16:29

This comment was marked as outdated.

Sign in to view

sandersn merged commit bb566f9 into microsoft:main Mar 9, 2023

sandersn deleted the dom-update-2023-03-07 branch March 9, 2023 19:01

DanielRosenwasser mentioned this pull request Mar 9, 2023

lib.d.ts Updates for TypeScript 5.1 #52956

Closed

jakebailey mentioned this pull request Mar 17, 2023

Fix use-color-scheme test for TS 5.1 DefinitelyTyped/DefinitelyTyped#64794

Merged

Teamop mentioned this pull request Apr 19, 2023

ScrollBehavior definition is missing 'instant' for window.scrollTo #47441

Closed

swissspidy added a commit to GoogleForCreators/web-stories-wp that referenced this pull request Jun 15, 2023

Ignore remaining type error

64f6a0c

This change was added in microsoft/TypeScript#53133

jakebailey mentioned this pull request Jul 9, 2023

TS 3.9+ missing registerProperty method in CSS #38593

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOM update 2023-03-07 #53133

DOM update 2023-03-07 #53133

sandersn commented Mar 7, 2023

sandersn commented Mar 7, 2023

typescript-bot commented Mar 7, 2023 •

edited

Loading

typescript-bot commented Mar 7, 2023

sandersn commented Mar 7, 2023

DanielRosenwasser commented Mar 9, 2023

sandersn commented Mar 9, 2023

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023

puppeteer

packages/puppeteer-core/tsconfig.json

This comment was marked as outdated.

This comment was marked as outdated.

sandersn commented Mar 9, 2023

This comment was marked as outdated.

This comment was marked as outdated.

typescript-bot commented Mar 9, 2023

Compiler

TSServer

Startup

sandersn commented Mar 9, 2023

jakebailey commented Mar 9, 2023

This comment was marked as outdated.

jakebailey commented Mar 9, 2023

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023

jakebailey commented Mar 9, 2023

typescript-bot commented Mar 9, 2023 •

edited

Loading

sandersn commented Mar 9, 2023

sandersn commented Mar 9, 2023

saschanaz commented Mar 9, 2023

DOM update 2023-03-07 #53133

DOM update 2023-03-07 #53133

Conversation

sandersn commented Mar 7, 2023

sandersn commented Mar 7, 2023

typescript-bot commented Mar 7, 2023 • edited Loading

typescript-bot commented Mar 7, 2023

sandersn commented Mar 7, 2023

DanielRosenwasser commented Mar 9, 2023

sandersn commented Mar 9, 2023

typescript-bot commented Mar 9, 2023 • edited Loading

typescript-bot commented Mar 9, 2023 • edited Loading

typescript-bot commented Mar 9, 2023 • edited Loading

typescript-bot commented Mar 9, 2023 • edited Loading

typescript-bot commented Mar 9, 2023

puppeteer

packages/puppeteer-core/tsconfig.json

This comment was marked as outdated.

This comment was marked as outdated.

sandersn commented Mar 9, 2023

This comment was marked as outdated.

This comment was marked as outdated.

typescript-bot commented Mar 9, 2023

Compiler

TSServer

Startup

sandersn commented Mar 9, 2023

jakebailey commented Mar 9, 2023

This comment was marked as outdated.

jakebailey commented Mar 9, 2023

typescript-bot commented Mar 9, 2023 • edited Loading

typescript-bot commented Mar 9, 2023

jakebailey commented Mar 9, 2023

typescript-bot commented Mar 9, 2023 • edited Loading

sandersn commented Mar 9, 2023

sandersn commented Mar 9, 2023

saschanaz commented Mar 9, 2023

typescript-bot commented Mar 7, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading

typescript-bot commented Mar 9, 2023 •

edited

Loading