Improve detection of type variables in instantiated object types #53246

ahejlsberg · 2023-03-14T16:01:09Z

When an object type that references type parameters is instantiated, it is often the case that the resulting instantiated type doesn't reference type parameters (because it is often the case that all type arguments are non-generic types). With this PR we improve our detection of such object types in order to short-circuit further pointless type instantiation and type inference involving those types.

The optimizations in this PR reduces the check time for the material-ui project by over 50%. (Note that the reduction isn't nearly as dramatic with the very old version of material-ui we use in our performance test suite.)

ahejlsberg · 2023-03-14T16:04:43Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-03-14T16:04:47Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at e3b542b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-14T16:04:47Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at e3b542b. You can monitor the build here.

typescript-bot · 2023-03-14T16:04:47Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at e3b542b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-14T16:04:47Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at e3b542b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-14T16:04:47Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at e3b542b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-14T16:16:12Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53246/merge:

Everything looks good!

typescript-bot · 2023-03-14T16:41:54Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53246

_Metric	_main	₅₃₂₄₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,443k (± 0.01%)}	_{361,468k (± 0.02%)}	_~	_361,406k	_361,538k	_{p=0.575 n=6}
_{Parse Time}	_{3.51s (± 0.42%)}	_{3.52s (± 0.33%)}	_~	_3.50s	_3.53s	_{p=0.309 n=6}
_{Bind Time}	_{1.18s (± 0.35%)}	_{1.18s (± 0.35%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.48s (± 0.56%)}	_{9.51s (± 0.38%)}	_~	_9.45s	_9.54s	_{p=0.255 n=6}
_{Emit Time}	_{7.91s (± 0.41%)}	_{7.94s (± 0.63%)}	_~	_7.86s	_8.01s	_{p=0.258 n=6}
_{Total Time}	_{22.08s (± 0.28%)}	_{22.16s (± 0.37%)}	_~	_22.01s	_22.25s	_{p=0.076 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,743k (± 0.03%)}	_{192,729k (± 0.03%)}	_~	_192,671k	_192,820k	_{p=0.689 n=6}
_{Parse Time}	_{1.59s (± 0.86%)}	_{1.58s (± 0.96%)}	_~	_1.56s	_1.60s	_{p=0.934 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.77%)}	_~	_0.81s	_0.83s	_{p=0.673 n=6}
_{Check Time}	_{10.11s (± 0.63%)}	_{10.07s (± 0.41%)}	_~	_10.01s	_10.13s	_{p=0.295 n=6}
_{Emit Time}	_{3.01s (± 0.66%)}	_{3.00s (± 0.47%)}	_~	_2.98s	_3.02s	_{p=0.507 n=6}
_{Total Time}	_{15.52s (± 0.36%)}	_{15.47s (± 0.22%)}	_~	_15.43s	_15.52s	_{p=0.228 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,715k (± 0.01%)}	_{346,751k (± 0.00%)}	_{+36k (+ 0.01%)}	_346,737k	_346,776k	_{p=0.045 n=6}
_{Parse Time}	_{2.73s (± 0.28%)}	_{2.72s (± 0.38%)}	_{-0.02s (- 0.55%)}	_2.70s	_2.73s	_{p=0.025 n=6}
_{Bind Time}	_{1.09s (± 0.58%)}	_{1.09s (± 0.37%)}	_~	_1.09s	_1.10s	_{p=0.673 n=6}
_{Check Time}	_{7.77s (± 0.27%)}	_{7.76s (± 0.36%)}	_~	_7.73s	_7.79s	_{p=1.000 n=6}
_{Emit Time}	_{4.49s (± 0.96%)}	_{4.46s (± 0.68%)}	_~	_4.41s	_4.49s	_{p=0.318 n=6}
_{Total Time}	_{16.07s (± 0.34%)}	_{16.03s (± 0.21%)}	_~	_15.99s	_16.09s	_{p=0.121 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,111k (± 0.01%)}	_{300,122k (± 0.01%)}	_~	_300,090k	_300,155k	_{p=0.423 n=6}
_{Parse Time}	_{2.17s (± 0.74%)}	_{2.18s (± 0.68%)}	_~	_2.16s	_2.20s	_{p=0.511 n=6}
_{Bind Time}	_{1.23s (± 0.95%)}	_{1.24s (± 0.94%)}	_~	_1.23s	_1.26s	_{p=0.187 n=6}
_{Check Time}	_{7.18s (± 0.24%)}	_{7.20s (± 0.39%)}	_~	_7.16s	_7.23s	_{p=0.292 n=6}
_{Emit Time}	_{4.35s (± 0.91%)}	_{4.35s (± 0.49%)}	_~	_4.33s	_4.38s	_{p=0.870 n=6}
_{Total Time}	_{14.93s (± 0.24%)}	_{14.97s (± 0.21%)}	_~	_14.92s	_15.00s	_{p=0.106 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{477,725k (± 0.01%)}	_{476,649k (± 0.01%)}	_{-1,076k (- 0.23%)}	_476,592k	_476,752k	_{p=0.005 n=6}
_{Parse Time}	_{3.22s (± 0.23%)}	_{3.21s (± 0.75%)}	_~	_3.18s	_3.24s	_{p=1.000 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.95s (± 0.94%)}	_~	_0.94s	_0.96s	_{p=0.541 n=6}
_{Check Time}	_{18.14s (± 0.82%)}	_{17.95s (± 0.19%)}	_{-0.19s (- 1.05%)}	_17.91s	_18.00s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.31s (± 0.67%)}	_{22.11s (± 0.18%)}	_{-0.20s (- 0.88%)}	_22.05s	_22.17s	_{p=0.005 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,669k (± 0.01%)}	_{550,576k (± 0.01%)}	_{-93k (- 0.02%)}	_550,502k	_550,652k	_{p=0.045 n=6}
_{Parse Time}	_{3.94s (± 0.21%)}	_{3.95s (± 0.42%)}	_~	_3.93s	_3.97s	_{p=0.226 n=6}
_{Bind Time}	_{1.79s (± 0.55%)}	_{1.80s (± 0.84%)}	_~	_1.78s	_1.82s	_{p=0.498 n=6}
_{Check Time}	_{3.00s (± 0.57%)}	_{3.01s (± 0.64%)}	_~	_2.98s	_3.03s	_{p=0.747 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.82s (± 0.18%)}	_{8.85s (± 0.41%)}	_~	_8.81s	_8.89s	_{p=0.198 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₂₄₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-14T17:44:13Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53246/merge:

Everything looks good!

typescript-bot · 2023-03-14T17:51:56Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

oliviertassinari · 2023-03-15T00:36:41Z

Oh wow, @mnajdova you might want to run your TypeScript benchmark against this change, see if we can measure the impact.

weswigham

We can tighten these checks even further, when we want to, now that we're willing to rely on there not being any sneaky type variables outside the object's mapper (which, iirc, is what we've worried about when I've mentioned doing this in the past). Since mappers have inspectable sources and targets (where possible) nowadays, we can rig them to actually keep a set of which type parameters remain unmapped for a given stack of mappers after instantiation when we compose them, and then use that to check if any of the inference targets are actually still present in the target type (thus, allowing us to skip inference on arguments or parts of types which only contain type parameters for outer calls).

jakebailey · 2023-03-15T17:50:39Z

On material-ui's docs project:

Benchmark 1: 4.9
  Time (mean ± σ):     85.634 s ±  0.332 s    [User: 82.993 s, System: 2.638 s]
  Range (min … max):   85.384 s … 86.006 s    5 runs
 
Benchmark 2: 5.0
  Time (mean ± σ):     77.467 s ±  1.111 s    [User: 74.444 s, System: 3.016 s]
  Range (min … max):   76.656 s … 79.313 s    5 runs
 
Benchmark 3: PR 53246
  Time (mean ± σ):     49.761 s ±  0.355 s    [User: 47.202 s, System: 2.552 s]
  Range (min … max):   49.439 s … 50.297 s    5 runs
 
Summary
  'PR 53246' ran
    1.56 ± 0.02 times faster than '5.0'
    1.72 ± 0.01 times faster than '4.9'

☺️

jakebailey · 2023-03-15T18:11:13Z

Just in case anyone was confused as to why I'm not getting quite the great number, the above is the total time end-to-end measured via hyperfine + tsc, so includes parse/bind/emit as well as check, whereas the PR description mentions specifically check time.

tomaszs · 2023-04-22T06:40:26Z

Hello, I was browsing that MR and the source code but have trouble understanding what is it about. It would be great to read a description for mortal human being because it's interesting. Great work BTW. Congrats on the results!

Improve detection of type variables in instantiated object types

e3b542b

typescript-bot assigned ahejlsberg Mar 14, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 14, 2023

ahejlsberg added this to the TypeScript 5.1.0 milestone Mar 14, 2023

ahejlsberg requested review from DanielRosenwasser, RyanCavanaugh and weswigham March 14, 2023 21:14

weswigham approved these changes Mar 15, 2023

View reviewed changes

ahejlsberg merged commit b70784e into main Mar 19, 2023

ahejlsberg deleted the improveTypeVariableDetection branch March 19, 2023 15:13

Andarist mentioned this pull request Mar 31, 2023

5.0: An opaque type from other modules isn't inferred correctly #53581

Open

juanrgm mentioned this pull request May 11, 2023

SUID types makes typescript indexation too slow. swordev/suid#207

Closed

jacoobes mentioned this pull request May 20, 2023

If you add to much dependencies it gives "Type instantiation is excessively deep and possibly infinite" molszanski/iti#42

Open

Andarist mentioned this pull request May 31, 2023

Allow non-generic return types to be read from single generic call signatures #54477

Merged

jakebailey mentioned this pull request Jun 2, 2023

Return early on intrinsics in couldContainTypeVariables #54377

Closed

This was referenced Jun 2, 2023

TS 5.1.1-rc: RangeError: Maximum call stack size exceeded #54348

Closed

Ensure we don't overwrite computed CouldContainTypeVariables in new optimization #54507

Merged

weswigham mentioned this pull request Jun 5, 2023

Optimize eagerly calculating CouldContainTypeVariables during object type instantiation #54538

Merged

a-tarasyuk mentioned this pull request Jun 29, 2023

[WIP] fix(54655): Regression: bug in emitted declarations involving branded types since 5.1 #54833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve detection of type variables in instantiated object types #53246

Improve detection of type variables in instantiated object types #53246

ahejlsberg commented Mar 14, 2023 •

edited

Loading

ahejlsberg commented Mar 14, 2023

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023

typescript-bot commented Mar 14, 2023

typescript-bot commented Mar 14, 2023

typescript-bot commented Mar 14, 2023

oliviertassinari commented Mar 15, 2023

weswigham left a comment

jakebailey commented Mar 15, 2023 •

edited

Loading

jakebailey commented Mar 15, 2023

tomaszs commented Apr 22, 2023

Improve detection of type variables in instantiated object types #53246

Improve detection of type variables in instantiated object types #53246

Conversation

ahejlsberg commented Mar 14, 2023 • edited Loading

ahejlsberg commented Mar 14, 2023

typescript-bot commented Mar 14, 2023 • edited Loading

typescript-bot commented Mar 14, 2023 • edited Loading

typescript-bot commented Mar 14, 2023 • edited Loading

typescript-bot commented Mar 14, 2023 • edited Loading

typescript-bot commented Mar 14, 2023 • edited Loading

typescript-bot commented Mar 14, 2023

typescript-bot commented Mar 14, 2023

typescript-bot commented Mar 14, 2023

typescript-bot commented Mar 14, 2023

oliviertassinari commented Mar 15, 2023

weswigham left a comment

Choose a reason for hiding this comment

jakebailey commented Mar 15, 2023 • edited Loading

jakebailey commented Mar 15, 2023

tomaszs commented Apr 22, 2023

ahejlsberg commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

jakebailey commented Mar 15, 2023 •

edited

Loading