DOM update 2023-04-23

[sandersn]

Addresses #52956, at least for the DOM part.

I'm scrolling through all 10,000 lines of additions, but so far there are only or two minor changes besides the addition of MDN links to everything.
After seeing how slow jsdoc parsing is, I'm not 100% happy about this, but I think we should (1) run perf tests (2) take this for the beta (3) if the perf tests are horrendous or we think of some other reason, consider reverting the typescript-dom-lib-generator PR.

The most interesting non-comment change is the removal of type BitrateMode = "constant" | "variable"; in favour of VideoEncoderBitrateMode. A couple of new types/interfaces got added as well.

[sandersn]

@typescript-bot run dt
@typescript-bot user test this

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 9367197. You can monitor the build here.

[typescript-bot]

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 9367197. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@sandersn Here are the results of running the user test suite comparing main and refs/pull/53652/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Everything looks good!

[DanielRosenwasser]

@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 9367197. You can monitor the build here.

Update: The results are in!

[jakebailey]

You'll want to drop the "fixed" from the description as GitHub will close the issue on merge.

[sandersn]

Swapped in a highfalutin' substitute.

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53652

Metric	main	53652	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	361,744k (± 0.01%)	364,794k (± 0.01%)	+3,050k (+ 0.84%)	364,759k	364,813k	p=0.005 n=6
Parse Time	3.52s (± 0.63%)	3.53s (± 0.66%)	~	3.50s	3.56s	p=0.258 n=6
Bind Time	1.18s (± 0.83%)	1.18s (± 0.88%)	~	1.17s	1.19s	p=0.784 n=6
Check Time	9.52s (± 0.42%)	9.56s (± 0.46%)	~	9.50s	9.63s	p=0.226 n=6
Emit Time	7.94s (± 0.53%)	7.97s (± 0.70%)	~	7.91s	8.06s	p=0.517 n=6
Total Time	22.16s (± 0.39%)	22.24s (± 0.39%)	~	22.13s	22.35s	p=0.149 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,573k (± 0.03%)	193,099k (± 0.67%)	~	192,496k	195,724k	p=0.810 n=6
Parse Time	1.59s (± 0.69%)	1.60s (± 0.51%)	~	1.59s	1.61s	p=0.197 n=6
Bind Time	0.82s (± 0.77%)	0.82s (± 0.00%)	~	0.82s	0.82s	p=1.000 n=6
Check Time	10.30s (± 0.32%)	10.29s (± 0.36%)	~	10.23s	10.33s	p=1.000 n=6
Emit Time	3.00s (± 0.60%)	3.00s (± 1.16%)	~	2.95s	3.04s	p=0.747 n=6
Total Time	15.70s (± 0.28%)	15.71s (± 0.21%)	~	15.67s	15.75s	p=0.686 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,680k (± 0.00%)	345,665k (± 0.00%)	~	345,652k	345,681k	p=0.077 n=6
Parse Time	2.71s (± 0.74%)	2.71s (± 0.28%)	~	2.70s	2.72s	p=0.511 n=6
Bind Time	1.08s (± 0.48%)	1.08s (± 0.70%)	~	1.07s	1.09s	p=0.784 n=6
Check Time	7.77s (± 0.49%)	7.80s (± 0.32%)	~	7.76s	7.83s	p=0.376 n=6
Emit Time	4.46s (± 0.63%)	4.47s (± 0.54%)	~	4.44s	4.50s	p=0.331 n=6
Total Time	16.03s (± 0.37%)	16.07s (± 0.17%)	~	16.04s	16.11s	p=0.260 n=6
TFS - node (v16.17.1, x64)
Memory used	300,055k (± 0.01%)	300,059k (± 0.01%)	~	300,029k	300,101k	p=0.936 n=6
Parse Time	2.16s (± 0.59%)	2.17s (± 0.58%)	~	2.15s	2.19s	p=0.236 n=6
Bind Time	1.24s (± 1.18%)	1.24s (± 1.07%)	~	1.22s	1.26s	p=0.933 n=6
Check Time	7.23s (± 0.19%)	7.22s (± 0.21%)	~	7.20s	7.24s	p=0.804 n=6
Emit Time	4.34s (± 0.79%)	4.32s (± 0.43%)	~	4.30s	4.35s	p=0.573 n=6
Total Time	14.96s (± 0.33%)	14.96s (± 0.22%)	~	14.90s	14.99s	p=0.872 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,482k (± 0.01%)	479,411k (± 0.00%)	+2,929k (+ 0.61%)	479,385k	479,432k	p=0.005 n=6
Parse Time	3.21s (± 0.38%)	3.24s (± 0.32%)	+0.04s (+ 1.20%)	3.23s	3.26s	p=0.005 n=6
Bind Time	0.95s (± 0.43%)	0.95s (± 1.23%)	~	0.93s	0.96s	p=0.858 n=6
Check Time	18.32s (± 1.30%)	18.22s (± 0.33%)	~	18.15s	18.32s	p=0.630 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.48s (± 1.09%)	22.41s (± 0.27%)	~	22.33s	22.51s	p=0.873 n=6
xstate - node (v16.17.1, x64)
Memory used	550,572k (± 0.01%)	559,631k (± 0.02%)	+9,058k (+ 1.65%)	559,525k	559,805k	p=0.005 n=6
Parse Time	3.93s (± 0.30%)	3.98s (± 0.54%)	+0.04s (+ 1.10%)	3.95s	4.01s	p=0.005 n=6
Bind Time	1.74s (± 0.69%)	1.73s (± 0.94%)	~	1.71s	1.75s	p=0.324 n=6
Check Time	3.06s (± 0.57%)	3.06s (± 0.13%)	~	3.06s	3.07s	p=1.000 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 5.53%)	~	0.09s	0.10s	p=0.174 n=6
Total Time	8.83s (± 0.28%)	8.87s (± 0.22%)	+0.04s (+ 0.42%)	8.84s	8.89s	p=0.036 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53652	6
Baseline	main	6

Developer Information:

Download Benchmark

[sandersn]

xstate/material-ui getting only 1% slower is a pretty good outcome actually. I guess my optimisation of parsing of comment text paid off.