-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isGenericReducibleType
to allow HKT technique to function again
#54112
Conversation
@typescript-bot test this |
Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at dd88229. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at dd88229. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at dd88229. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at dd88229. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the extended test suite on this PR at dd88229. You can monitor the build here. |
@ahejlsberg Here they are:Comparison Report - main..54112
System
Hosts
Scenarios
Developer Information: |
@ahejlsberg Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
@typescript-bot pack this |
Heya @jakebailey, I've started to run the tarball bundle task on this PR at dd88229. You can monitor the build here. |
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
@ahejlsberg Here are the results of running the top-repos suite comparing Everything looks good! |
Hey @ahejlsberg, the results of running the DT tests are ready. |
@ahejlsberg nice, i confirm that zodios use case is working again : link to playground |
Amazing thank you! |
isGenericReducibleType
to allow HKT technique to function again
Latest commit reverts the changes to type inference and instead fixes the issue by making |
@typescript-bot test this |
Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 64a864b. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 64a864b. You can monitor the build here. |
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 64a864b. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 64a864b. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 64a864b. You can monitor the build here. Update: The results are in! |
@ahejlsberg Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Hey @ahejlsberg, it looks like the DT test run failed. Please check the log for more details. |
@ahejlsberg Here are the results of running the top-repos suite comparing Everything looks good! |
@typescript-bot pack this |
Heya @jakebailey, I've started to run the tarball bundle task on this PR at 64a864b. You can monitor the build here. |
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Amazing! Looks great |
@weswigham mentioned that this may break a case where two generic litearl I've tried this to no avail. Playground Link |
@ahejlsberg Here they are:Comparison Report - main..54112
System
Hosts
Scenarios
Developer Information: |
@typescript-bot cherry-pick this to release-5.1 |
@typescript-bot cherry-pick this to release-5.1 ... please? |
Heya @jakebailey, I've started to run the task to cherry-pick this into |
Hey @jakebailey, I've opened #54349 for you. |
…e-5.1 (#54349) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
Fixes #53970.