Revert GHA fail-fast for OpenSSF workflow #54382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Okay, now that I'm actually at my real machine to look hard, yes, my PR did break it. The 500 message doesn't say anything about this, but the actual answer here is that the scorecard system verifies the workflow to ensure it contains the right thing, and otherwise will fail the submission. Apparently editing the default shell was enough to break it. So, this PR is indeed the right fix and it's not a server problem. See also:
cc @pnacht |
jakebailey
changed the title
andrewbranch
approved these changes
May 25, 2023
weswigham
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not convinced that the failures of this pipeline are anything but a problem with the scorecard server, but it started failing around this change so might as well revert and see if it helps.