Stateless function components in JSX #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/compiler/checker.ts # src/harness/harness.ts
| @@ -203,12 +200,17 @@ namespace ts { | |||
| } | |||
| }; | |||
|
|
|||
| let jsxElementType: ObjectType; | |||
| /** Things we lazy load from the JSX namespace */ | |||
| const jsxTypes: {[name: string]: ObjectType} = {}; | |||
| @@ -1115,6 +1117,15 @@ namespace Harness { | |||
| includeBuiltFiles.push({ unitName: builtFileName, content: normalizeLineEndings(IO.readFile(builtFileName), newLine) }); | |||
| } | |||
|
|
|||
| // Files from tests\lib that are requested by "@libFiles" | |||
| if (options.libFiles) { | |||
| ts.forEach(options.libFiles.split(","), filename => { | |||
There was a problem hiding this comment.
fileName, also use a for..of if you don't need a forEach
|
Will this get included in TypeScript 1.7? Alternatively, any ETA? |
|
This is slated for TypeScript 1.8. TypeScript 1.7 should be coming out fairly soon. |
RyanCavanaugh
added a commit
that referenced
this pull request
Dec 1, 2015
Stateless function components in JSX
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
refandkey(see Design preview: Stateless Functional Components in JSX #5478 again)@libfilestest directive so we can test the react.d.ts file (and others) with better fidelity. Use this minimally as it will be much slower than a compact testcaseJsxFlags.ClassElementtoValueElementThere will be a sister PR to this one to DefinitelyTyped to add the new types to react.d.ts