Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 56161 #57853

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Revert PR 56161 #57853

merged 1 commit into from
Mar 19, 2024

Conversation

jakebailey
Copy link
Member

This is a revert of #56161; it was not well-discussed (#56161 (comment)) and has caused some breaks.

We'll come back with a better fix for 5.5.

Fixes #57845
Fixes #57672
Reopens #48956

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 19, 2024
@jakebailey
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 19, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.4 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @jakebailey! I've created #57854 for you.

@jakebailey
Copy link
Member Author

@DanielRosenwasser The release blog post will have to be updated to remove the breaking change.

@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.4.3 milestone Mar 19, 2024
@jakebailey jakebailey merged commit 309fd3d into microsoft:main Mar 19, 2024
25 checks passed
jakebailey added a commit that referenced this pull request Mar 19, 2024
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
@jakebailey jakebailey deleted the revert-56161 branch March 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Infinity, -Infinity and NaN as an enum key name for string enum enum error
3 participants