-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize slashes for paths in watch events #57968
Conversation
@typescript-bot cherry-pick to release-5.4 |
Hey, @DanielRosenwasser! I was unable to cherry-pick this PR. Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/8458595699 |
@@ -93,8 +93,8 @@ describe("unittests:: tsserver:: events:: watchEvents", () => { | |||
function updateFileOnHost(session: TestSession, file: string, log: string, content?: string) { | |||
// Change b.ts | |||
session.logger.log(`${log}: ${file}`); | |||
if (content) session.host.appendFile(file, content); | |||
else session.host.writeFile(file, session.host.readFile("/user/username/projects/myproject/a.ts")!); | |||
if (content && session.host.fileExists(file)) session.host.appendFile(file, content); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just testing, but is there technically an issue here with if content
is an empty string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but its for testing so just simplified it
@DanielRosenwasser conflict for picking up comes because #57967 is not merged |
@typescript-bot cherry-pick to release-5.4 |
Hey, @DanielRosenwasser! I've created #57970 for you. |
…e-5.4 (#57970) Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
No description provided.