Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] playing around with Node/Token/Identifier allocators #58047

Closed
wants to merge 4 commits into from
Closed

[experiment] playing around with Node/Token/Identifier allocators #58047

wants to merge 4 commits into from

Conversation

jakebailey
Copy link
Member

Something I noticed on #58045. I have no proof having not yet tested it, but it sure feels weird that Node gets modifierFlagsCache and original props but Token/Identifier do not. I would have expected those two to have differing shapes such that we stop being monomorphic on some paths.

Technically I can add the props to the others, but, trying out just using Node anyway?

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 2, 2024
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 2, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,658k (± 0.00%) 311,486k (± 0.01%) 🔻+15,829k (+ 5.35%) 311,452k 311,524k p=0.005 n=6
Parse Time 3.17s (± 0.46%) 3.20s (± 0.68%) ~ 3.17s 3.23s p=0.063 n=6
Bind Time 0.99s (± 0.52%) 1.00s (± 0.84%) ~ 0.99s 1.01s p=0.923 n=6
Check Time 9.70s (± 0.57%) 9.68s (± 0.21%) ~ 9.64s 9.70s p=0.686 n=6
Emit Time 8.40s (± 0.52%) 8.34s (± 0.27%) -0.06s (- 0.69%) 8.30s 8.36s p=0.013 n=6
Total Time 22.26s (± 0.37%) 22.21s (± 0.09%) ~ 22.18s 22.23s p=0.573 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 194,588k (± 0.94%) 202,318k (± 0.89%) +7,731k (+ 3.97%) 201,053k 204,653k p=0.005 n=6
Parse Time 1.64s (± 0.99%) 1.65s (± 1.25%) ~ 1.62s 1.68s p=1.000 n=6
Bind Time 0.88s (± 0.72%) 0.88s (± 1.02%) ~ 0.87s 0.89s p=1.000 n=6
Check Time 11.27s (± 0.75%) 11.34s (± 0.72%) ~ 11.20s 11.42s p=0.296 n=6
Emit Time 3.16s (± 0.68%) 3.15s (± 0.52%) ~ 3.14s 3.18s p=0.871 n=6
Total Time 16.95s (± 0.60%) 17.02s (± 0.50%) ~ 16.89s 17.11s p=0.173 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,428k (± 0.01%) 366,358k (± 0.00%) 🔻+18,930k (+ 5.45%) 366,336k 366,385k p=0.005 n=6
Parse Time 3.71s (± 0.55%) 3.73s (± 0.39%) ~ 3.71s 3.75s p=0.056 n=6
Bind Time 1.38s (± 0.59%) 1.37s (± 0.80%) ~ 1.35s 1.38s p=0.177 n=6
Check Time 10.19s (± 0.31%) 10.18s (± 0.39%) ~ 10.11s 10.21s p=0.871 n=6
Emit Time 6.00s (± 0.39%) 6.00s (± 0.39%) ~ 5.97s 6.03s p=0.746 n=6
Total Time 21.28s (± 0.27%) 21.29s (± 0.32%) ~ 21.17s 21.36s p=0.630 n=6
TFS - node (v18.15.0, x64)
Memory used 302,843k (± 0.01%) 322,259k (± 0.01%) 🔻+19,416k (+ 6.41%) 322,234k 322,307k p=0.005 n=6
Parse Time 2.40s (± 0.57%) 2.41s (± 1.47%) ~ 2.38s 2.48s p=0.413 n=6
Bind Time 1.20s (± 0.43%) 1.19s (± 0.34%) ~ 1.19s 1.20s p=0.112 n=6
Check Time 7.55s (± 0.35%) 7.54s (± 0.22%) ~ 7.51s 7.55s p=0.192 n=6
Emit Time 4.27s (± 0.61%) 4.26s (± 0.42%) ~ 4.23s 4.28s p=1.000 n=6
Total Time 15.40s (± 0.29%) 15.40s (± 0.21%) ~ 15.35s 15.44s p=0.872 n=6
material-ui - node (v18.15.0, x64)
Memory used 510,185k (± 0.01%) 523,461k (± 0.01%) +13,276k (+ 2.60%) 523,418k 523,511k p=0.005 n=6
Parse Time 3.92s (± 0.28%) 3.94s (± 0.74%) ~ 3.90s 3.97s p=0.367 n=6
Bind Time 1.46s (± 0.57%) 1.40s (± 1.08%) 🟩-0.05s (- 3.44%) 1.39s 1.43s p=0.004 n=6
Check Time 25.44s (± 0.30%) 25.36s (± 0.40%) ~ 25.23s 25.52s p=0.259 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 30.81s (± 0.25%) 30.71s (± 0.40%) ~ 30.54s 30.88s p=0.128 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,745,006k (± 0.00%) 1,786,843k (± 0.00%) +41,837k (+ 2.40%) 1,786,807k 1,786,868k p=0.005 n=6
Parse Time 9.63s (± 0.50%) 9.66s (± 0.61%) ~ 9.60s 9.77s p=0.468 n=6
Bind Time 3.48s (± 0.31%) 3.39s (± 0.43%) -0.09s (- 2.54%) 3.37s 3.41s p=0.005 n=6
Check Time 82.16s (± 0.51%) 82.03s (± 0.27%) ~ 81.67s 82.30s p=0.748 n=6
Emit Time 0.19s (± 0.00%) 0.19s (± 2.81%) ~ 0.19s 0.20s p=0.071 n=6
Total Time 95.47s (± 0.46%) 95.28s (± 0.27%) ~ 94.89s 95.58s p=0.575 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,400,233k (± 0.03%) 2,530,109k (± 0.02%) 🔻+129,877k (+ 5.41%) 2,529,229k 2,530,910k p=0.005 n=6
Parse Time 6.04s (± 0.92%) 6.09s (± 0.74%) ~ 6.05s 6.15s p=0.093 n=6
Bind Time 2.23s (± 1.26%) 2.26s (± 0.79%) +0.03s (+ 1.57%) 2.23s 2.28s p=0.036 n=6
Check Time 40.04s (± 0.32%) 39.83s (± 0.30%) -0.21s (- 0.53%) 39.61s 39.96s p=0.013 n=6
Emit Time 3.21s (± 1.50%) 3.15s (± 1.90%) ~ 3.07s 3.22s p=0.128 n=6
Total Time 51.54s (± 0.20%) 51.34s (± 0.15%) -0.20s (- 0.39%) 51.21s 51.42s p=0.008 n=6
self-compiler - node (v18.15.0, x64)
Memory used 416,124k (± 0.01%) 439,394k (± 0.01%) 🔻+23,270k (+ 5.59%) 439,359k 439,436k p=0.005 n=6
Parse Time 2.75s (± 0.51%) 2.75s (± 0.48%) ~ 2.74s 2.77s p=0.934 n=6
Bind Time 1.07s (± 1.13%) 1.08s (± 0.77%) ~ 1.07s 1.09s p=0.062 n=6
Check Time 15.40s (± 0.26%) 15.42s (± 0.37%) ~ 15.37s 15.53s p=1.000 n=6
Emit Time 1.12s (± 1.26%) 1.09s (± 1.96%) -0.03s (- 2.53%) 1.07s 1.13s p=0.044 n=6
Total Time 20.35s (± 0.25%) 20.35s (± 0.41%) ~ 20.27s 20.51s p=0.687 n=6
vscode - node (v18.15.0, x64)
Memory used 2,899,654k (± 0.00%) 3,035,317k (± 0.00%) 🔻+135,664k (+ 4.68%) 3,035,135k 3,035,487k p=0.005 n=6
Parse Time 15.94s (± 0.31%) 16.03s (± 0.53%) ~ 15.94s 16.17s p=0.126 n=6
Bind Time 5.07s (± 0.55%) 5.11s (± 0.27%) +0.04s (+ 0.82%) 5.09s 5.13s p=0.007 n=6
Check Time 87.50s (± 0.36%) 88.49s (± 2.34%) ~ 87.29s 92.67s p=0.471 n=6
Emit Time 23.68s (± 0.67%) 27.59s (± 6.84%) 🔻+3.91s (+16.52%) 23.75s 28.66s p=0.013 n=6
Total Time 132.17s (± 0.24%) 137.21s (± 0.17%) +5.03s (+ 3.81%) 136.96s 137.53s p=0.005 n=6
webpack - node (v18.15.0, x64)
Memory used 408,889k (± 0.04%) 427,619k (± 0.01%) 🔻+18,730k (+ 4.58%) 427,510k 427,682k p=0.005 n=6
Parse Time 3.23s (± 0.47%) 3.19s (± 0.67%) -0.04s (- 1.29%) 3.17s 3.22s p=0.008 n=6
Bind Time 1.41s (± 0.98%) 1.38s (± 1.25%) -0.02s (- 1.66%) 1.36s 1.40s p=0.028 n=6
Check Time 14.30s (± 0.32%) 14.34s (± 0.14%) ~ 14.31s 14.36s p=0.145 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 18.94s (± 0.22%) 18.91s (± 0.24%) ~ 18.84s 18.96s p=0.169 n=6
xstate - node (v18.15.0, x64)
Memory used 513,394k (± 0.01%) 549,890k (± 0.02%) 🔻+36,497k (+ 7.11%) 549,774k 550,054k p=0.005 n=6
Parse Time 3.96s (± 0.36%) 3.96s (± 0.85%) ~ 3.90s 4.00s p=0.935 n=6
Bind Time 1.87s (± 1.14%) 1.77s (± 1.24%) 🟩-0.10s (- 5.26%) 1.74s 1.80s p=0.005 n=6
Check Time 3.44s (± 0.80%) 3.61s (± 0.55%) 🔻+0.17s (+ 4.80%) 3.57s 3.63s p=0.005 n=6
Emit Time 0.09s (± 5.95%) 0.08s (± 6.19%) ~ 0.08s 0.09s p=0.311 n=6
Total Time 9.36s (± 0.39%) 9.42s (± 0.44%) +0.06s (+ 0.66%) 9.38s 9.50s p=0.030 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,377ms (± 0.78%) 2,368ms (± 0.57%) ~ 2,353ms 2,381ms p=0.171 n=6
Req 2 - geterr 5,616ms (± 0.41%) 5,608ms (± 0.64%) ~ 5,559ms 5,665ms p=0.748 n=6
Req 3 - references 320ms (± 1.39%) 318ms (± 0.17%) ~ 317ms 318ms p=0.866 n=6
Req 4 - navto 272ms (± 0.23%) 272ms (± 0.23%) ~ 271ms 273ms p=1.000 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 87ms (± 0.93%) 87ms (± 0.73%) ~ 86ms 88ms p=0.432 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,720ms (± 0.84%) 3,093ms (± 9.31%) 🟩-628ms (-16.88%) 2,960ms 3,680ms p=0.008 n=6
Req 2 - geterr 6,110ms (± 0.42%) 5,531ms (±11.84%) ~ 4,924ms 6,165ms p=0.298 n=6
Req 3 - references 495ms (± 0.40%) 442ms (± 9.59%) ~ 403ms 496ms p=0.060 n=6
Req 4 - navto 443ms (± 1.27%) 422ms (±11.10%) ~ 359ms 467ms p=0.809 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 108ms (± 0.78%) 105ms (± 7.63%) ~ 89ms 109ms p=0.342 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,895ms (± 0.74%) 3,890ms (± 0.53%) ~ 3,857ms 3,911ms p=0.630 n=6
Req 2 - geterr 2,433ms (± 0.98%) 2,466ms (± 1.92%) ~ 2,431ms 2,559ms p=0.228 n=6
Req 3 - references 149ms (± 0.92%) 147ms (± 0.35%) ~ 147ms 148ms p=0.051 n=6
Req 4 - navto 555ms (± 1.33%) 561ms (± 1.12%) ~ 554ms 571ms p=0.065 n=6
Req 5 - completionInfo count 2,079 (± 0.00%) 2,079 (± 0.00%) ~ 2,079 2,079 p=1.000 n=6
Req 5 - completionInfo 451ms (± 1.33%) 457ms (± 2.84%) ~ 442ms 477ms p=0.520 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 154.12ms (± 0.18%) 153.97ms (± 0.19%) -0.15ms (- 0.10%) 152.89ms 158.23ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 339.84ms (± 0.29%) 339.96ms (± 0.31%) +0.12ms (+ 0.04%) 330.98ms 351.37ms p=0.018 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 222.27ms (± 0.16%) 222.14ms (± 0.19%) -0.13ms (- 0.06%) 220.88ms 229.30ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 222.28ms (± 0.16%) 222.01ms (± 0.16%) -0.27ms (- 0.12%) 220.64ms 225.10ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member Author

Ah, yes, memory.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 3, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,639k (± 0.01%) 298,911k (± 0.01%) +3,271k (+ 1.11%) 298,879k 298,946k p=0.005 n=6
Parse Time 3.93s (± 0.27%) 3.96s (± 0.31%) +0.03s (+ 0.81%) 3.94s 3.97s p=0.006 n=6
Bind Time 1.23s (± 0.89%) 1.24s (± 0.61%) ~ 1.23s 1.25s p=0.131 n=6
Check Time 12.03s (± 0.21%) 12.00s (± 0.36%) ~ 11.93s 12.04s p=0.168 n=6
Emit Time 10.47s (± 0.30%) 10.47s (± 0.53%) ~ 10.40s 10.57s p=0.872 n=6
Total Time 27.66s (± 0.14%) 27.67s (± 0.29%) ~ 27.54s 27.79s p=0.573 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,285k (± 0.96%) 195,683k (± 1.01%) ~ 193,827k 197,504k p=0.066 n=6
Parse Time 2.00s (± 1.02%) 2.04s (± 0.48%) +0.04s (+ 2.17%) 2.03s 2.06s p=0.004 n=6
Bind Time 1.08s (± 1.12%) 1.08s (± 1.12%) ~ 1.07s 1.10s p=1.000 n=6
Check Time 13.93s (± 0.40%) 14.04s (± 0.86%) ~ 13.89s 14.17s p=0.229 n=6
Emit Time 3.86s (± 0.99%) 3.86s (± 0.71%) ~ 3.81s 3.89s p=1.000 n=6
Total Time 20.87s (± 0.36%) 21.02s (± 0.61%) ~ 20.86s 21.16s p=0.064 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,424k (± 0.01%) 351,398k (± 0.00%) +3,974k (+ 1.14%) 351,376k 351,415k p=0.005 n=6
Parse Time 3.66s (± 0.98%) 3.74s (± 1.04%) +0.08s (+ 2.05%) 3.67s 3.77s p=0.016 n=6
Bind Time 1.39s (± 1.95%) 1.38s (± 1.35%) ~ 1.35s 1.40s p=0.572 n=6
Check Time 10.17s (± 0.54%) 10.17s (± 0.42%) ~ 10.12s 10.24s p=0.936 n=6
Emit Time 5.99s (± 0.36%) 6.03s (± 0.46%) +0.03s (+ 0.58%) 6.00s 6.08s p=0.043 n=6
Total Time 21.22s (± 0.18%) 21.31s (± 0.19%) +0.09s (+ 0.44%) 21.26s 21.37s p=0.010 n=6
TFS - node (v18.15.0, x64)
Memory used 302,836k (± 0.01%) 306,960k (± 0.00%) +4,124k (+ 1.36%) 306,942k 306,977k p=0.005 n=6
Parse Time 2.02s (± 0.87%) 2.00s (± 1.16%) ~ 1.97s 2.02s p=0.324 n=6
Bind Time 1.00s (± 1.21%) 1.01s (± 0.51%) ~ 1.01s 1.02s p=0.142 n=6
Check Time 6.41s (± 0.16%) 6.40s (± 0.34%) ~ 6.37s 6.43s p=0.326 n=6
Emit Time 3.58s (± 0.57%) 3.60s (± 0.34%) ~ 3.58s 3.61s p=0.121 n=6
Total Time 13.01s (± 0.23%) 13.01s (± 0.27%) ~ 12.94s 13.04s p=0.936 n=6
material-ui - node (v18.15.0, x64)
Memory used 510,235k (± 0.01%) 512,882k (± 0.01%) +2,647k (+ 0.52%) 512,814k 512,915k p=0.005 n=6
Parse Time 3.96s (± 0.42%) 3.95s (± 0.93%) ~ 3.92s 4.02s p=0.459 n=6
Bind Time 1.46s (± 0.51%) 1.48s (± 1.71%) ~ 1.45s 1.51s p=0.216 n=6
Check Time 25.44s (± 0.27%) 25.40s (± 0.27%) ~ 25.32s 25.49s p=0.470 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 30.85s (± 0.21%) 30.83s (± 0.23%) ~ 30.76s 30.94s p=0.572 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,744,997k (± 0.00%) 1,753,450k (± 0.00%) +8,453k (+ 0.48%) 1,753,403k 1,753,512k p=0.005 n=6
Parse Time 6.62s (± 0.50%) 6.65s (± 0.74%) ~ 6.56s 6.70s p=0.090 n=6
Bind Time 2.36s (± 0.69%) 2.34s (± 0.17%) ~ 2.34s 2.35s p=0.074 n=6
Check Time 56.58s (± 0.43%) 56.64s (± 0.33%) ~ 56.42s 56.86s p=0.688 n=6
Emit Time 0.14s (± 4.05%) 0.13s (± 3.10%) ~ 0.13s 0.14s p=0.282 n=6
Total Time 65.69s (± 0.33%) 65.77s (± 0.29%) ~ 65.58s 66.01s p=0.688 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,400,520k (± 0.03%) 2,426,709k (± 0.03%) +26,189k (+ 1.09%) 2,425,843k 2,427,556k p=0.005 n=6
Parse Time 6.01s (± 0.46%) 6.16s (± 0.90%) +0.15s (+ 2.44%) 6.07s 6.22s p=0.005 n=6
Bind Time 2.24s (± 1.63%) 2.25s (± 1.01%) ~ 2.22s 2.27s p=0.936 n=6
Check Time 39.90s (± 0.28%) 39.99s (± 0.38%) ~ 39.83s 40.22s p=0.336 n=6
Emit Time 3.19s (± 1.60%) 3.17s (± 1.54%) ~ 3.12s 3.24s p=0.810 n=6
Total Time 51.37s (± 0.11%) 51.58s (± 0.26%) +0.21s (+ 0.42%) 51.38s 51.77s p=0.008 n=6
self-compiler - node (v18.15.0, x64)
Memory used 416,101k (± 0.00%) 420,798k (± 0.01%) +4,698k (+ 1.13%) 420,763k 420,855k p=0.005 n=6
Parse Time 2.76s (± 0.53%) 2.67s (± 2.48%) ~ 2.62s 2.79s p=0.065 n=6
Bind Time 1.08s (± 0.59%) 1.20s (± 5.61%) 🔻+0.11s (+10.65%) 1.07s 1.26s p=0.050 n=6
Check Time 15.38s (± 0.24%) 15.36s (± 0.34%) ~ 15.28s 15.43s p=0.627 n=6
Emit Time 1.12s (± 1.95%) 1.10s (± 1.24%) -0.02s (- 2.08%) 1.08s 1.12s p=0.042 n=6
Total Time 20.34s (± 0.27%) 20.32s (± 0.23%) ~ 20.25s 20.38s p=0.871 n=6
vscode - node (v18.15.0, x64)
Memory used 2,899,724k (± 0.00%) 2,928,387k (± 0.00%) +28,664k (+ 0.99%) 2,928,266k 2,928,522k p=0.005 n=6
Parse Time 15.93s (± 0.32%) 15.98s (± 0.39%) ~ 15.91s 16.09s p=0.171 n=6
Bind Time 5.03s (± 0.42%) 5.03s (± 0.34%) ~ 5.00s 5.05s p=1.000 n=6
Check Time 87.35s (± 0.35%) 87.08s (± 0.69%) ~ 86.45s 87.96s p=0.423 n=6
Emit Time 26.11s (±10.01%) 24.42s (± 8.16%) ~ 23.42s 28.49s p=0.093 n=6
Total Time 134.42s (± 2.10%) 132.51s (± 1.70%) ~ 130.88s 136.97s p=0.230 n=6
webpack - node (v18.15.0, x64)
Memory used 408,999k (± 0.03%) 412,863k (± 0.02%) +3,864k (+ 0.94%) 412,725k 412,931k p=0.005 n=6
Parse Time 4.78s (± 0.81%) 4.77s (± 0.83%) ~ 4.69s 4.80s p=0.418 n=6
Bind Time 2.06s (± 0.96%) 2.03s (± 0.54%) -0.03s (- 1.22%) 2.01s 2.04s p=0.042 n=6
Check Time 20.85s (± 0.42%) 20.90s (± 0.36%) ~ 20.79s 20.98s p=0.297 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 27.69s (± 0.26%) 27.70s (± 0.30%) ~ 27.58s 27.80s p=0.687 n=6
xstate - node (v18.15.0, x64)
Memory used 513,521k (± 0.01%) 520,772k (± 0.03%) +7,250k (+ 1.41%) 520,638k 521,014k p=0.005 n=6
Parse Time 3.95s (± 0.55%) 3.96s (± 0.74%) ~ 3.91s 3.99s p=0.572 n=6
Bind Time 1.88s (± 1.20%) 1.79s (± 3.27%) 🟩-0.09s (- 4.80%) 1.74s 1.90s p=0.036 n=6
Check Time 3.43s (± 0.68%) 3.56s (± 1.92%) +0.13s (+ 3.74%) 3.43s 3.63s p=0.020 n=6
Emit Time 0.09s (± 5.95%) 0.09s (± 9.83%) ~ 0.08s 0.10s p=0.533 n=6
Total Time 9.35s (± 0.61%) 9.40s (± 0.23%) ~ 9.36s 9.42s p=0.126 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,553ms (± 0.40%) 3,554ms (± 0.31%) ~ 3,533ms 3,563ms p=0.936 n=6
Req 2 - geterr 8,329ms (± 0.35%) 8,300ms (± 0.48%) ~ 8,254ms 8,337ms p=0.378 n=6
Req 3 - references 477ms (± 1.13%) 475ms (± 0.39%) ~ 472ms 477ms p=0.627 n=6
Req 4 - navto 407ms (± 0.10%) 406ms (± 0.74%) ~ 402ms 408ms p=0.604 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 130ms (± 1.36%) 133ms (± 5.25%) ~ 128ms 147ms p=0.279 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,722ms (± 0.78%) 3,691ms (± 0.67%) ~ 3,665ms 3,721ms p=0.173 n=6
Req 2 - geterr 6,103ms (± 0.48%) 6,119ms (± 0.18%) ~ 6,105ms 6,133ms p=0.261 n=6
Req 3 - references 492ms (± 0.54%) 495ms (± 1.33%) ~ 488ms 503ms p=0.570 n=6
Req 4 - navto 447ms (± 0.12%) 445ms (± 0.66%) ~ 441ms 449ms p=0.549 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 108ms (± 0.95%) 108ms (± 0.91%) ~ 107ms 109ms p=0.423 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,634ms (± 0.20%) 2,627ms (± 0.31%) ~ 2,615ms 2,637ms p=0.199 n=6
Req 2 - geterr 1,746ms (± 1.54%) 1,730ms (± 2.01%) ~ 1,692ms 1,773ms p=0.336 n=6
Req 3 - references 121ms (± 6.24%) 125ms (± 0.94%) ~ 124ms 127ms p=0.357 n=6
Req 4 - navto 366ms (± 0.62%) 368ms (± 0.22%) +2ms (+ 0.59%) 367ms 369ms p=0.015 n=6
Req 5 - completionInfo count 2,079 (± 0.00%) 2,079 (± 0.00%) ~ 2,079 2,079 p=1.000 n=6
Req 5 - completionInfo 313ms (± 2.07%) 309ms (± 1.94%) ~ 304ms 320ms p=0.470 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 183.45ms (± 0.17%) 183.61ms (± 0.23%) +0.16ms (+ 0.09%) 181.26ms 193.00ms p=0.001 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 227.50ms (± 0.17%) 227.39ms (± 0.14%) -0.11ms (- 0.05%) 226.13ms 229.76ms p=0.025 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 329.41ms (± 0.31%) 329.18ms (± 0.28%) -0.24ms (- 0.07%) 321.48ms 333.53ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 221.89ms (± 0.17%) 222.11ms (± 0.16%) +0.22ms (+ 0.10%) 220.59ms 224.76ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member Author

aight

@jakebailey jakebailey closed this Apr 3, 2024
@jakebailey jakebailey deleted the modifierFlagsCache branch April 3, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @typescript-bot