Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize path mapping lookups #59048

Merged
merged 14 commits into from
Aug 29, 2024
Merged

Optimize path mapping lookups #59048

merged 14 commits into from
Aug 29, 2024

Commits on Jun 27, 2024

  1. Use a Set and a binary search to find longest-prefix matches more q… 

    …uickly.

This also adds a naive cache for each call, though it is not resilient to being passed the same array of patterns twice with different contents, and could be defeated if the patterns frequently differ.
    @DanielRosenwasser
    DanielRosenwasser committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9de8ff3 View commit details
    Browse the repository at this point in the history

  2. Cache more than one input array at a time to avoid redoing work in a … 

    …ping/pong situation.
    @DanielRosenwasser
    DanielRosenwasser committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    347908c View commit details
    Browse the repository at this point in the history

  3. Format

    @DanielRosenwasser
    DanielRosenwasser committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5b0c17e View commit details
    Browse the repository at this point in the history

  4. Cache calculated pathPatterns to avoid recreating them.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4a88ba6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Move caching to tryParsePatterns, avoid creating an intermediate ar… 

    …ray entirely.
    @DanielRosenwasser
    DanielRosenwasser committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    123b7c3 View commit details
    Browse the repository at this point in the history

  2. Format.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3d4bc20 View commit details
    Browse the repository at this point in the history

  3. Avoid leaning on the WeakMap when we can cache on ConfigFileSpecs.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8919029 View commit details
    Browse the repository at this point in the history

  4. Revert "Avoid leaning on the WeakMap when we can cache on `ConfigFile… 

    …Specs`."

This reverts commit 8919029.
    @DanielRosenwasser
    DanielRosenwasser committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    75835bb View commit details
    Browse the repository at this point in the history

  5. Swap conditions.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    12d1a11 View commit details
    Browse the repository at this point in the history

  6. Always do a linear search.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    012259e View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Just separate patterns into exact strings and maches. Remove all sort… 

    …ing logic.
    @DanielRosenwasser
    DanielRosenwasser committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    94b522a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Addressed feedback.

    @DanielRosenwasser
    DanielRosenwasser authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5342b46 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge remote-tracking branch 'origin/main' into binarySearchAndSetsFo… 

    …rPatterns
    @DanielRosenwasser
    DanielRosenwasser committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7e508d0 View commit details
    Browse the repository at this point in the history

  2. Format.

    @DanielRosenwasser
    DanielRosenwasser committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    88c76ad View commit details
    Browse the repository at this point in the history