Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize scan with a lookup table to reduce branching #59106

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Optimize scan with a lookup table to reduce branching #59106

wants to merge 13 commits into from

Commits on Jul 2, 2024

  1. Create a lookup table on token info to avoid excessive branching.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e6de1d9 View commit details
    Browse the repository at this point in the history

  2. Use an array for common cases.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f438918 View commit details
    Browse the repository at this point in the history

  3. Handle digits.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e8769ca View commit details
    Browse the repository at this point in the history

  4. Fixes.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a087c24 View commit details
    Browse the repository at this point in the history

  5. Moved everything outside of identifier handling to use a lookup.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    811526d View commit details
    Browse the repository at this point in the history

  6. Check for CR, LF, space, and tab before doing the lookup.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9830671 View commit details
    Browse the repository at this point in the history

  7. Flip condition for readabiity (avoids indentation).

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    af340b7 View commit details
    Browse the repository at this point in the history

  8. Use Debug.fail to avoid a call.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d5898b5 View commit details
    Browse the repository at this point in the history

  9. TokenInfo -> TokenCategory

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    11a24a7 View commit details
    Browse the repository at this point in the history

  10. More rename.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9e5e29f View commit details
    Browse the repository at this point in the history

  11. Add missing nextLine entry to whitespace, remove unnecessary branches.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    db10cae View commit details
    Browse the repository at this point in the history

  12. Rename None to IdentifierOrUnknown

    @DanielRosenwasser
    DanielRosenwasser committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3bdfe84 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Hit the table once for whitespace, then tight-loop.

    @DanielRosenwasser
    DanielRosenwasser committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    33ae58d View commit details
    Browse the repository at this point in the history