feat(lib): define TypedArray interface #59202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
For Backlog Bug
|
The TypeScript team hasn't accepted the linked issue #15402. If you can get it accepted, this PR will have a better chance of being reviewed. |
mfulton26
commented
Jul 9, 2024
| @@ -1,31 +1,11 @@ | |||
| bigintWithLib.ts(4,1): error TS2350: Only a void function can be called with the 'new' keyword. | |||
| bigintWithLib.ts(19,33): error TS2769: No overload matches this call. | |||
There was a problem hiding this comment.
I think something is broken here but I'm not sure what yet. A pointer on what is wrong would be appreciated.
Each concrete typed array type and constructor share common interfaces. Library types can be defined extending base interfaces: 1. higher code reuse 2. less duplication 3. easier maintenance (less error prone) Closes microsoft#15402 Fixes microsoft#45198
mfulton26
force-pushed
the
typed-array-interface
branch
from
1b2a0c0
to
a6c56ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each concrete typed array type and constructor share common interfaces.
Library types can be defined extending base interfaces:
Fixes #15402
Fixes #45198