Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the script is only attached to project during createProgram execution #59354

Closed
wants to merge 4 commits into from
Closed

Make sure the script is only attached to project during createProgram execution #59354

wants to merge 4 commits into from

Conversation

johnsoncodehk
Copy link

Fixes #59349

Refer to #59349 (comment).

This should not be called anytime except when creating program and attaching files into the program as this one ensures project and LS are in sync with respect to files and scriptinfos in the program.

This PR adds conditions to attachToProject to cover this assumption.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 19, 2024
@johnsoncodehk johnsoncodehk changed the title Make sure the script is only attached to project during createProgram… Make sure the script is only attached to project during createProgram execution Jul 19, 2024
@johnsoncodehk johnsoncodehk marked this pull request as draft July 19, 2024 10:26
@johnsoncodehk johnsoncodehk marked this pull request as ready for review July 19, 2024 11:38
@sheetalkamat
Copy link
Member

Not the right approach for the fix.

@johnsoncodehk johnsoncodehk mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Could not find source file' with Vue plugin when creating new files and using VS Code's file watcher
3 participants
@johnsoncodehk @sheetalkamat @typescript-bot