Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable in ts transform #59467

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

jakebailey
Copy link
Member

Noticed while reviewing a different PR that currentClassHasParameterProperties is only ever written to.

@jakebailey jakebailey requested a review from rbuckton July 30, 2024 00:05
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 30, 2024
@rbuckton
Copy link
Member

rbuckton commented Aug 8, 2024

@typescript-bot: pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 8, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 8, 2024

Hey @rbuckton, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163189/artifacts?artifactName=tgz&fileId=FC5192397BC86E6DC972A82ACED2969E9B2980937C9B345E9F2FFAEF267A23D202&fileName=/typescript-5.6.0-insiders.20240808.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-59467-2".;

@jakebailey jakebailey merged commit aa8a2c0 into microsoft:main Aug 8, 2024
32 checks passed
@jakebailey jakebailey deleted the ts-cleanup branch August 8, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants