Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Always report useDefineForClassFields-related errors even when disabled #59623

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Aug 13, 2024

This is an experiment to establish a rough estimate of how frequently projects in the wild depend on the initializer order for TypeScript "Parameter Property Initializers" feature when used in conjunction with useDefineForClassFields: false.

Note that this will only catch cases where projects have an ordering dependency that would be reported as a use-before-definition error by the compiler when useDefineForClassFields is enabled.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 13, 2024
@rbuckton
Copy link
Member Author

@typescript-bot test top1000

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top1000 ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59623/merge:

Something interesting changed - please have a look.

Details

google/blockly

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants