make exported destructured discriminated union narrowing work #59673

MichalMarsalek · 2024-08-18T12:01:36Z

Please verify that:

There is an associated issue in the Backlog milestone (required)
Code is up-to-date with the main branch
You've successfully run hereby runtests locally
There are new or updated unit tests validating the change

Fixes #59652

src/compiler/checker.ts

tests/cases/conformance/controlFlow/dependentDestructuredVariables.ts

jakebailey · 2024-08-19T06:38:48Z

@typescript-bot test it

typescript-bot · 2024-08-19T06:38:52Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-19T07:00:46Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-19T07:03:50Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59673/merge:

Everything looks good!

typescript-bot · 2024-08-19T07:22:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,530k (± 0.94%)}	_{194,100k (± 0.97%)}	_~	_192,320k	_195,859k	_{p=0.470 n=6}
_{Parse Time}	_{1.31s (± 0.80%)}	_{1.30s (± 1.23%)}	_~	_1.27s	_1.31s	_{p=0.615 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.55s (± 0.17%)}	_{9.55s (± 0.29%)}	_~	_9.51s	_9.58s	_{p=0.871 n=6}
_{Emit Time}	_{2.71s (± 2.08%)}	_{2.69s (± 1.64%)}	_~	_2.63s	_2.73s	_{p=0.293 n=6}
_{Total Time}	_{14.28s (± 0.34%)}	_{14.24s (± 0.33%)}	_~	_14.16s	_14.29s	_{p=0.229 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,757	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,645k (± 0.00%)}	_{1,222,605k (± 0.00%)}	_~	_1,222,543k	_1,222,669k	_{p=0.298 n=6}
_{Parse Time}	_{6.64s (± 0.32%)}	_{6.67s (± 0.36%)}	_~	_6.64s	_6.71s	_{p=0.104 n=6}
_{Bind Time}	_{1.86s (± 0.22%)}	_{1.86s (± 0.34%)}	_~	_1.85s	_1.87s	_{p=0.673 n=6}
_{Check Time}	_{31.10s (± 0.40%)}	_{31.01s (± 0.26%)}	_~	_30.93s	_31.11s	_{p=0.148 n=6}
_{Emit Time}	_{14.98s (± 0.44%)}	_{14.98s (± 0.44%)}	_~	_14.86s	_15.03s	_{p=1.000 n=6}
_{Total Time}	_{54.59s (± 0.21%)}	_{54.51s (± 0.24%)}	_~	_54.29s	_54.64s	_{p=0.334 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,505,734	_2,505,734	_~	_~	_~	_{p=1.000 n=6}
_Types	_993,039	_993,039	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,376,619k (± 0.00%)}	_{2,376,738k (± 0.00%)}	_~	_2,376,594k	_2,376,860k	_{p=0.065 n=6}
_{Parse Time}	_{9.28s (± 0.21%)}	_{9.30s (± 0.35%)}	_~	_9.26s	_9.34s	_{p=0.296 n=6}
_{Bind Time}	_{2.18s (± 0.34%)}	_{2.19s (± 0.73%)}	_~	_2.16s	_2.20s	_{p=0.247 n=6}
_{Check Time}	_{73.96s (± 0.60%)}	_{74.36s (± 1.52%)}	_~	_73.57s	_76.47s	_{p=0.689 n=6}
_{Emit Time}	_{0.28s (± 2.70%)}	_{0.28s (± 3.49%)}	_~	_0.27s	_0.29s	_{p=0.554 n=6}
_{Total Time}	_{85.70s (± 0.54%)}	_{86.13s (± 1.32%)}	_~	_85.36s	_88.24s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,749	_1,231,749	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,525	_264,525	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,411k (± 6.01%)}	_{2,353,211k (± 0.02%)}	_~	_2,352,546k	_2,353,563k	_{p=0.936 n=6}
_{Parse Time}	_{5.00s (± 0.73%)}	_{4.97s (± 1.23%)}	_~	_4.89s	_5.06s	_{p=0.575 n=6}
_{Bind Time}	_{1.89s (± 1.00%)}	_{1.88s (± 0.80%)}	_~	_1.87s	_1.90s	_{p=0.451 n=6}
_{Check Time}	_{34.66s (± 0.73%)}	_{34.78s (± 0.11%)}	_~	_34.71s	_34.82s	_{p=0.078 n=6}
_{Emit Time}	_{3.35s (± 1.27%)}	_{3.35s (± 0.96%)}	_~	_3.30s	_3.38s	_{p=0.936 n=6}
_{Total Time}	_{44.91s (± 0.65%)}	_{45.00s (± 0.20%)}	_~	_44.87s	_45.12s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,749	_1,231,749	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,525	_264,525	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,428,110k (± 0.06%)}	_{2,427,188k (± 0.03%)}	_~	_2,426,682k	_2,427,994k	_{p=0.128 n=6}
_{Parse Time}	_{6.17s (± 1.44%)}	_{6.21s (± 0.48%)}	_~	_6.17s	_6.26s	_{p=0.810 n=6}
_{Bind Time}	_{2.02s (± 1.15%)}	_{2.01s (± 0.63%)}	_~	_2.00s	_2.03s	_{p=0.514 n=6}
_{Check Time}	_{41.55s (± 0.69%)}	_{41.43s (± 0.60%)}	_~	_41.20s	_41.76s	_{p=0.261 n=6}
_{Emit Time}	_{4.17s (± 5.44%)}	_{4.22s (± 4.38%)}	_~	_4.05s	_4.49s	_{p=0.470 n=6}
_{Total Time}	_{53.93s (± 0.59%)}	_{53.87s (± 0.39%)}	_~	_53.47s	_54.10s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,947	_256,947	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,643	_105,643	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,455k (± 0.01%)}	_{429,430k (± 0.01%)}	_~	_429,400k	_429,478k	_{p=0.298 n=6}
_{Parse Time}	_{4.16s (± 0.52%)}	_{4.15s (± 0.50%)}	_~	_4.12s	_4.17s	_{p=0.746 n=6}
_{Bind Time}	_{1.60s (± 1.55%)}	_{1.60s (± 0.65%)}	_~	_1.58s	_1.61s	_{p=0.935 n=6}
_{Check Time}	_{22.36s (± 0.32%)}	_{22.36s (± 0.52%)}	_~	_22.25s	_22.56s	_{p=0.688 n=6}
_{Emit Time}	_{2.06s (± 1.21%)}	_{2.05s (± 1.05%)}	_~	_2.02s	_2.08s	_{p=0.808 n=6}
_{Total Time}	_{30.18s (± 0.34%)}	_{30.17s (± 0.39%)}	_~	_30.06s	_30.38s	_{p=0.423 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,080k (± 0.01%)}	_{370,143k (± 0.04%)}	_~	_369,993k	_370,394k	_{p=0.378 n=6}
_{Parse Time}	_{2.75s (± 1.21%)}	_{2.77s (± 1.03%)}	_~	_2.73s	_2.81s	_{p=0.413 n=6}
_{Bind Time}	_{1.57s (± 0.52%)}	_{1.56s (± 0.66%)}	_~	_1.55s	_1.58s	_{p=0.546 n=6}
_{Check Time}	_{15.71s (± 0.22%)}	_{15.69s (± 0.32%)}	_~	_15.64s	_15.75s	_{p=0.285 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.02s (± 0.30%)}	_{20.02s (± 0.25%)}	_~	_19.97s	_20.10s	_{p=0.630 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,006,672	_3,006,672	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,035,540	_1,035,540	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,130,176k (± 0.00%)}	_{3,130,228k (± 0.00%)}	_~	_3,130,103k	_3,130,349k	_{p=0.423 n=6}
_{Parse Time}	_{17.21s (± 0.23%)}	_{17.18s (± 0.35%)}	_~	_17.09s	_17.26s	_{p=0.469 n=6}
_{Bind Time}	_{5.23s (± 0.23%)}	_{5.23s (± 0.26%)}	_~	_5.21s	_5.25s	_{p=0.410 n=6}
_{Check Time}	_{96.78s (± 0.41%)}	_{96.69s (± 0.43%)}	_~	_96.28s	_97.34s	_{p=0.810 n=6}
_{Emit Time}	_{25.04s (± 0.98%)}	_{24.97s (± 0.51%)}	_~	_24.83s	_25.12s	_{p=0.575 n=6}
_{Total Time}	_{144.27s (± 0.35%)}	_{144.07s (± 0.29%)}	_~	_143.43s	_144.62s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_275,352	_275,352	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,436	_112,436	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{424,141k (± 0.01%)}	_{424,090k (± 0.02%)}	_~	_423,961k	_424,233k	_{p=0.298 n=6}
_{Parse Time}	_{3.98s (± 0.39%)}	_{3.98s (± 0.58%)}	_~	_3.95s	_4.02s	_{p=0.803 n=6}
_{Bind Time}	_{1.74s (± 0.60%)}	_{1.71s (± 0.71%)}	_{-0.02s (- 1.25%)}	_1.70s	_1.73s	_{p=0.018 n=6}
_{Check Time}	_{17.43s (± 0.52%)}	_{17.41s (± 0.75%)}	_~	_17.24s	_17.60s	_{p=0.574 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.14s (± 0.42%)}	_{23.11s (± 0.53%)}	_~	_22.93s	_23.25s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_534,239	_534,239	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,225	_176,225	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{479,376k (± 0.01%)}	_{479,349k (± 0.01%)}	_~	_479,310k	_479,411k	_{p=0.298 n=6}
_{Parse Time}	_{3.41s (± 0.86%)}	_{3.41s (± 0.43%)}	_~	_3.39s	_3.43s	_{p=0.872 n=6}
_{Bind Time}	_{1.25s (± 0.88%)}	_{1.26s (± 0.50%)}	_~	_1.25s	_1.27s	_{p=0.126 n=6}
_{Check Time}	_{18.00s (± 0.31%)}	_{17.98s (± 0.33%)}	_~	_17.90s	_18.04s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.66s (± 0.28%)}	_{22.64s (± 0.28%)}	_~	_22.55s	_22.72s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-19T08:24:21Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59673/merge:

Everything looks good!

make destructured discriminated union narrowing work

a37a9d3

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 18, 2024

MichalMarsalek mentioned this pull request Aug 18, 2024

Variables (extracted from a discriminated union object) lose narrowed types after being exported #59652

Open

MichalMarsalek changed the title ~~make destructured discriminated union narrowing work~~ make exported destructured discriminated union narrowing work Aug 18, 2024

Andarist reviewed Aug 18, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

use getExportSymbolOfValueSymbolIfExported

bed3d48

MichalMarsalek marked this pull request as ready for review August 19, 2024 05:43

jakebailey reviewed Aug 19, 2024

View reviewed changes

tests/cases/conformance/controlFlow/dependentDestructuredVariables.ts Outdated Show resolved Hide resolved

move new testcase to a new file

1ff6ab0

MichalMarsalek added 2 commits August 19, 2024 08:45

formatting

7c2adea

formatting

e33bc96

use testfile options

68c705a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make exported destructured discriminated union narrowing work #59673

make exported destructured discriminated union narrowing work #59673

MichalMarsalek commented Aug 18, 2024 •

edited

Loading

jakebailey commented Aug 19, 2024

typescript-bot commented Aug 19, 2024 •

edited

Loading

typescript-bot commented Aug 19, 2024

typescript-bot commented Aug 19, 2024

typescript-bot commented Aug 19, 2024

tsc

typescript-bot commented Aug 19, 2024

make exported destructured discriminated union narrowing work #59673

Are you sure you want to change the base?

make exported destructured discriminated union narrowing work #59673

Conversation

MichalMarsalek commented Aug 18, 2024 • edited Loading

jakebailey commented Aug 19, 2024

typescript-bot commented Aug 19, 2024 • edited Loading

typescript-bot commented Aug 19, 2024

typescript-bot commented Aug 19, 2024

typescript-bot commented Aug 19, 2024

tsc

typescript-bot commented Aug 19, 2024

MichalMarsalek commented Aug 18, 2024 •

edited

Loading

typescript-bot commented Aug 19, 2024 •

edited

Loading