devcontainer.json Updates #59694
Merged
devcontainer.json Updates #59694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Aug 20, 2024
jakebailey
reviewed
Aug 20, 2024
|
|
||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| "postCreateCommand": { | ||
| "Configure Build Tools": "sudo corepack enable npm; sudo npm install -g hereby; npm ci", |
There was a problem hiding this comment.
Wish this didn't need to be sudo :(
There was a problem hiding this comment.
Yeah, but this is the same as what was happening in the Dockerfile, so I don't really feel like there's anything wrong with it.
jakebailey
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
Dockerfileand relies just ondevcontainer.jsondevcontainer.jsondependabot scanning