DOM update 2024-09-25 #60061

sandersn · 2024-09-25T17:26:14Z

This update is almost all additions; the deprecated MutationEvent is removed, and some events have more specific types. I think this is a low-impact update.

new interface AddressErrors, PayerErrors, PaymentOptions, PaymentShippingOption, PaymentAddress, plus new properties in existing related types
new interfaces AudioData*, AudioDecoder*, AudioEncoder*, EncodedAudioChunk*, VideoEncoder*
various new properties in VideoConfiguration, VideoEncoder*
new interfaces AuthenticationExtensionPRFInputs/Outputs/Values, plus associated prf properties in AuthenticationExtensionsClientInputs/Outputs
new interface CarePositionFromPointOptions
delete interface IntersectionObserverEntryInit
various Media interfaces add backgroundBlur properties
PointerEventInit adds altitudeAngle and azimuthAngle
new interface CaretPosition
new interfaces PublicKeyCredential*, plus associated new methods
ARIAMixin adds properties ariaColIndexText, ariaRowIndexText
AnimationEventMap's remove event now has type AnimationPlaybackEvent, not just Event
AudioWorkletNodeEventMap's error event now has type ErrorEvent, not just Event
HTMLVideoElementEventMap's events now have specific type PictureInPictureEvent
MIDIAccessEventMap's event now have specific type MIDIConnectionEvent
MediaRecorderEventMap's error event now has type ErrorEvent
RTCDataChannelEventMap's error event now has type RTCErrorEvent
De/CompressionStream is no longer an empty subtype of GenericTransformStream; adds ReadableStream and WriteableStream properties
Document adds properties fragmentDirective, caretPositionFromPoint, currentCSSZoom
deprecated interface MutationEvent is removed; Document.createEvent removes MutationEvent/s overloads.
FontFace's constructor takes source: BufferSource instead of source: BinaryData
FontFaceSet's contructor no longer has initialFaces: FontFace[] parameter.
HTMLDetailsElement adds a property writingSuggestions 🤖
IntersectionObserverEntry's constructor no longer has init parameter.
new interface ViewTransitionUpdateCallback

Fixes #59704

Overview list of changes still to come.

jakebailey · 2024-09-26T21:51:18Z

@typescript-bot test it

typescript-bot · 2024-09-26T21:51:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-26T22:11:59Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: rx-dom
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rx-dom/index.d.ts
  136:99  error  TypeScript@local compile error: 
Cannot find name 'MutationEvent'. Did you mean 'AnimationEvent'?  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: webrtc
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/webrtc/RTCPeerConnection.d.ts
  130:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property '"error"' must be of type 'RTCErrorEvent', but here has type 'Event'                                                                           @definitelytyped/expect
  140:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'onerror' must be of type '((this: RTCDtlsTransport, ev: RTCErrorEvent) => any) | null', but here has type 'DtlsTransportEventHandler<Event>'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: node
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/node/test/globals-dom.ts
  64:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<any>
got:
  ReadableStream<Uint8Array<ArrayBufferLike>>  @definitelytyped/expect
  65:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<any>
got:
  ReadableStream<Uint8Array<ArrayBufferLike>>  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-mediacapture-record
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-mediacapture-record/index.d.ts
  29:6  error  TypeScript@local compile error: 
Duplicate identifier 'BitrateMode'                                                                                                                                                                                              @definitelytyped/expect
  41:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'error' must be of type 'ErrorEvent', but here has type 'Event'                                                                                             @definitelytyped/expect
  57:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'onerror' must be of type '((this: MediaRecorder, ev: ErrorEvent) => any) | null', but here has type '((this: MediaRecorder, event: Event) => any) | null'  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: css-font-loading-module
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/css-font-loading-module/index.d.ts
  44:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'onloading' must be of type '(this: FontFaceSet, ev: FontFaceSetLoadEvent) => any', but here has type '(this: FontFaceSet, event: Event) => any'       @definitelytyped/expect
  45:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'onloadingdone' must be of type '(this: FontFaceSet, ev: FontFaceSetLoadEvent) => any', but here has type '(this: FontFaceSet, event: Event) => any'   @definitelytyped/expect
  46:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'onloadingerror' must be of type '(this: FontFaceSet, ev: FontFaceSetLoadEvent) => any', but here has type '(this: FontFaceSet, event: Event) => any'  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-webcodecs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
   77:5  error  TypeScript@local expected type to be:
  boolean
got:
  boolean | undefined                        @definitelytyped/expect
   79:5  error  TypeScript@local expected type to be:
  AudioDecoderConfig
got:
  AudioDecoderConfig | undefined  @definitelytyped/expect
  173:5  error  TypeScript@local expected type to be:
  boolean
got:
  boolean | undefined                        @definitelytyped/expect
  175:5  error  TypeScript@local expected type to be:
  AudioEncoderConfig
got:
  AudioEncoderConfig | undefined  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
   34:5   error  TypeScript@local compile error: 
All declarations of 'config' must have identical modifiers                                                                                                             @definitelytyped/expect
   34:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'config' must be of type 'AudioDecoderConfig | undefined', but here has type 'AudioDecoderConfig'  @definitelytyped/expect
   35:5   error  TypeScript@local compile error: 
All declarations of 'supported' must have identical modifiers                                                                                                          @definitelytyped/expect
   35:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'supported' must be of type 'boolean | undefined', but here has type 'boolean'                     @definitelytyped/expect
   51:5   error  TypeScript@local compile error: 
All declarations of 'config' must have identical modifiers                                                                                                             @definitelytyped/expect
   51:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'config' must be of type 'AudioEncoderConfig | undefined', but here has type 'AudioEncoderConfig'  @definitelytyped/expect
   52:5   error  TypeScript@local compile error: 
All declarations of 'supported' must have identical modifiers                                                                                                          @definitelytyped/expect
   52:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'supported' must be of type 'boolean | undefined', but here has type 'boolean'                     @definitelytyped/expect
  195:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'format' must be of type 'AudioSampleFormat | null', but here has type 'AudioSampleFormat'         @definitelytyped/expect
  407:6   error  TypeScript@local compile error: 
Duplicate identifier 'AudioSampleFormat'                                                                                                                               @definitelytyped/expect
  410:6   error  TypeScript@local compile error: 
Duplicate identifier 'EncodedAudioChunkType'                                                                                                                           @definitelytyped/expect

✖ 15 problems (15 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.23_typescript@5.7.0-dev.20240926/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2024-09-26T22:14:53Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60061/merge:

Everything looks good!

sandersn · 2024-09-26T22:27:05Z

DT errors:

Polyfills that need to be updated:

webrtc
dom-webcodecs
dom-mediacapture-record

A user of FontFaceSet that needs to update

css-font-loading-module

A user of MutationEvent that needs a shim now, I guess?

rx-dom

Node has a broken ExpectType: ReadableStream<Uint8Array<ArrayBufferLike>>

node

jakebailey · 2024-09-26T22:31:20Z

src/lib/dom.generated.d.ts

@@ -450,6 +540,18 @@ interface ElementDefinitionOptions {
    extends?: string;
 }

+interface EncodedAudioChunkInit {
+    data: AllowSharedBufferSource;
+    duration?: number;


Maybe this is generically wrong with the DOM types, but this is seemingly an options bag given to a constructor. Why don't all of these have | undefined?

I'd have to go read the code but I'm pretty sure it's an oversight that the generator never got updated for the missing/undefined distinction.

typescript-bot · 2024-09-26T22:37:37Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,734k (± 0.70%)}	_{195,536k (± 0.80%)}	_~	_192,360k	_196,436k	_{p=0.471 n=6}
_{Parse Time}	_{1.60s (± 1.29%)}	_{1.62s (± 0.84%)}	_~	_1.60s	_1.64s	_{p=0.328 n=6}
_{Bind Time}	_{0.87s (± 0.87%)}	_{0.87s (± 1.74%)}	_~	_0.85s	_0.89s	_{p=0.864 n=6}
_{Check Time}	_{11.69s (± 0.27%)}	_{11.71s (± 0.42%)}	_~	_11.64s	_11.79s	_{p=0.517 n=6}
_{Emit Time}	_{3.40s (± 5.43%)}	_{3.49s (± 4.09%)}	_~	_3.25s	_3.60s	_{p=0.688 n=6}
_{Total Time}	_{17.57s (± 1.11%)}	_{17.69s (± 0.79%)}	_~	_17.44s	_17.82s	_{p=0.229 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₃₃	_{🔻+26 (+371.43%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_947,102	_947,872	_{+770 (+ 0.08%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,738	_410,831	_{+93 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,158k (± 0.01%)}	_{1,224,103k (± 0.01%)}	_~	_1,224,021k	_1,224,177k	_{p=0.261 n=6}
_{Parse Time}	_{8.11s (± 1.00%)}	_{8.11s (± 0.52%)}	_~	_8.08s	_8.19s	_{p=0.936 n=6}
_{Bind Time}	_{2.27s (± 1.07%)}	_{2.28s (± 0.76%)}	_~	_2.25s	_2.30s	_{p=0.226 n=6}
_{Check Time}	_{37.85s (± 0.52%)}	_{37.84s (± 0.20%)}	_~	_37.71s	_37.92s	_{p=0.469 n=6}
_{Emit Time}	_{18.21s (± 0.74%)}	_{18.24s (± 0.67%)}	_~	_18.12s	_18.45s	_{p=0.470 n=6}
_{Total Time}	_{66.43s (± 0.37%)}	_{66.47s (± 0.22%)}	_~	_66.31s	_66.73s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,993	_{+342 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_936,037	_936,048	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,990k (± 0.00%)}	_{2,352,433k (± 0.01%)}	_{+443k (+ 0.02%)}	_2,352,230k	_2,352,661k	_{p=0.005 n=6}
_{Parse Time}	_{11.22s (± 0.47%)}	_{11.16s (± 0.51%)}	_~	_11.08s	_11.23s	_{p=0.091 n=6}
_{Bind Time}	_{2.61s (± 0.56%)}	_{2.63s (± 0.74%)}	_~	_2.60s	_2.66s	_{p=0.060 n=6}
_{Check Time}	_{90.71s (± 0.22%)}	_{91.62s (± 2.95%)}	_~	_89.86s	_97.07s	_{p=1.000 n=6}
_{Emit Time}	_{0.35s (± 3.32%)}	_{0.34s (± 3.98%)}	_~	_0.32s	_0.36s	_{p=0.406 n=6}
_{Total Time}	_{104.90s (± 0.22%)}	_{105.75s (± 2.60%)}	_~	_103.99s	_111.28s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,482	_1,250,482	_~	_~	_~	_{p=1.000 n=6}
_Types	_265,040	_265,040	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,129,069k (± 0.09%)}	_{3,128,348k (± 0.02%)}	_~	_3,127,507k	_3,129,568k	_{p=0.810 n=6}
_{Parse Time}	_{6.62s (± 1.32%)}	_{6.61s (± 0.71%)}	_~	_6.58s	_6.68s	_{p=0.575 n=6}
_{Bind Time}	_{2.33s (± 4.56%)}	_{2.35s (± 1.18%)}	_~	_2.32s	_2.38s	_{p=1.000 n=6}
_{Check Time}	_{42.90s (± 0.35%)}	_{42.94s (± 0.28%)}	_~	_42.82s	_43.12s	_{p=1.000 n=6}
_{Emit Time}	_{3.42s (± 1.93%)}	_{3.38s (± 1.73%)}	_~	_3.27s	_3.43s	_{p=0.520 n=6}
_{Total Time}	_{55.25s (± 0.39%)}	_{55.28s (± 0.32%)}	_~	_54.98s	_55.46s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,482	_1,250,482	_~	_~	_~	_{p=1.000 n=6}
_Types	_265,040	_265,040	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,867,576k (±13.42%)}	_{2,867,038k (±13.42%)}	_~	_2,484,946k	_3,247,315k	_{p=1.000 n=6}
_{Parse Time}	_{6.73s (± 2.08%)}	_{6.81s (± 3.07%)}	_~	_6.59s	_7.03s	_{p=0.471 n=6}
_{Bind Time}	_{2.19s (± 4.53%)}	_{2.16s (± 2.09%)}	_~	_2.09s	_2.22s	_{p=0.872 n=6}
_{Check Time}	_{43.00s (± 0.44%)}	_{42.87s (± 0.43%)}	_~	_42.63s	_43.04s	_{p=0.575 n=6}
_{Emit Time}	_{3.36s (± 1.82%)}	_{3.30s (± 0.70%)}	_~	_3.28s	_3.34s	_{p=0.090 n=6}
_{Total Time}	_{55.27s (± 0.45%)}	_{55.13s (± 0.36%)}	_~	_54.78s	_55.33s	_{p=0.261 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,980	_260,980	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,406	_106,406	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{436,855k (± 0.01%)}	_{436,837k (± 0.01%)}	_~	_436,777k	_436,908k	_{p=0.521 n=6}
_{Parse Time}	_{3.49s (± 0.62%)}	_{3.50s (± 0.86%)}	_~	_3.46s	_3.54s	_{p=0.935 n=6}
_{Bind Time}	_{1.29s (± 1.42%)}	_{1.30s (± 1.06%)}	_~	_1.29s	_1.33s	_{p=0.346 n=6}
_{Check Time}	_{18.83s (± 0.33%)}	_{18.81s (± 0.44%)}	_~	_18.72s	_18.91s	_{p=0.809 n=6}
_{Emit Time}	_{1.49s (± 1.18%)}	_{1.46s (± 1.96%)}	_~	_1.44s	_1.50s	_{p=0.157 n=6}
_{Total Time}	_{25.09s (± 0.24%)}	_{25.07s (± 0.48%)}	_~	_24.94s	_25.24s	_{p=0.575 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,916k (± 0.02%)}	_{370,944k (± 0.01%)}	_~	_370,909k	_371,014k	_{p=0.296 n=6}
_{Parse Time}	_{2.90s (± 1.61%)}	_{2.89s (± 0.89%)}	_~	_2.86s	_2.92s	_{p=0.872 n=6}
_{Bind Time}	_{1.60s (± 1.10%)}	_{1.59s (± 1.18%)}	_~	_1.57s	_1.62s	_{p=0.139 n=6}
_{Check Time}	_{16.34s (± 0.28%)}	_{16.36s (± 0.29%)}	_~	_16.31s	_16.42s	_{p=0.375 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.84s (± 0.30%)}	_{20.84s (± 0.18%)}	_~	_20.79s	_20.89s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,104,519	_3,105,038	_{+519 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,070,045	_1,070,237	_{+192 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,199,818k (± 0.00%)}	_{3,200,277k (± 0.01%)}	_{+459k (+ 0.01%)}	_3,200,048k	_3,200,487k	_{p=0.005 n=6}
_{Parse Time}	_{14.20s (± 0.42%)}	_{14.17s (± 0.21%)}	_~	_14.13s	_14.21s	_{p=0.336 n=6}
_{Bind Time}	_{4.41s (± 0.57%)}	_{4.41s (± 0.45%)}	_~	_4.39s	_4.44s	_{p=1.000 n=6}
_{Check Time}	_{87.31s (± 3.57%)}	_{86.12s (± 2.52%)}	_~	_84.13s	_89.12s	_{p=0.689 n=6}
_{Emit Time}	_{24.09s (± 9.35%)}	_{24.77s (± 9.91%)}	_~	_22.52s	_27.14s	_{p=0.689 n=6}
_{Total Time}	_{130.01s (± 3.47%)}	_{129.47s (± 2.68%)}	_~	_125.26s	_134.68s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_279,071	_279,481	_{+410 (+ 0.15%)}	_~	_~	_{p=0.001 n=6}
_Types	_113,893	_114,023	_{+130 (+ 0.11%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,661k (± 0.02%)}	_{429,423k (± 0.03%)}	_{+761k (+ 0.18%)}	_429,272k	_429,631k	_{p=0.005 n=6}
_{Parse Time}	_{4.04s (± 0.72%)}	_{4.06s (± 1.06%)}	_~	_4.00s	_4.11s	_{p=0.332 n=6}
_{Bind Time}	_{1.73s (± 1.19%)}	_{1.74s (± 1.85%)}	_~	_1.70s	_1.78s	_{p=0.808 n=6}
_{Check Time}	_{18.07s (± 0.37%)}	_{18.15s (± 0.35%)}	_{+0.08s (+ 0.42%)}	_18.05s	_18.24s	_{p=0.045 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.84s (± 0.28%)}	_{23.95s (± 0.29%)}	_{+0.11s (+ 0.45%)}	_23.86s	_24.05s	_{p=0.037 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,378	_{+351 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_181,292	_181,305	_{+13 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{483,565k (± 0.01%)}	_{484,135k (± 0.01%)}	_{+570k (+ 0.12%)}	_484,090k	_484,179k	_{p=0.005 n=6}
_{Parse Time}	_{2.73s (± 0.45%)}	_{2.74s (± 0.36%)}	_~	_2.72s	_2.75s	_{p=0.097 n=6}
_{Bind Time}	_0.98s	_{0.98s (± 0.64%)}	_~	_0.97s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{15.94s (± 0.49%)}	_{15.94s (± 0.34%)}	_~	_15.88s	_16.01s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.65s (± 0.44%)}	_{19.66s (± 0.30%)}	_~	_19.58s	_19.72s	_{p=0.572 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-09-26T22:39:32Z

Hm, 26 new errors in the angular benchmark. Maybe that will show in the top tests, but it sounds like I should add that as a user test.

typescript-bot · 2024-09-26T23:32:54Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60061/merge:

Something interesting changed - please have a look.

Details

pixijs/pixijs

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.types.json

error TS2352: Conversion of type 'FederatedPointerEvent' to type 'PointerEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- src/events/EventTicker.ts#L105
error TS2420: Class 'FederatedPointerEvent' incorrectly implements interface 'PointerEvent'.
- src/events/FederatedPointerEvent.ts#L7
error TS2322: Type 'this' is not assignable to type 'PointerEvent'.
- src/events/FederatedPointerEvent.ts#L81

slab/quill

tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/quill/src/modules/uploader.ts#L22
- packages/quill/src/modules/uploader.ts#L24
error TS18047: 'position' is possibly 'null'.

packages/quill/tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/quill/src/modules/uploader.ts#L22
- packages/quill/src/modules/uploader.ts#L24
error TS18047: 'position' is possibly 'null'.

jakebailey · 2024-09-26T23:57:24Z

Retesting user tests now that I added angular there explicitly:

@typescript-bot user test this

typescript-bot · 2024-09-26T23:57:27Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	✅ Results

typescript-bot · 2024-09-27T00:16:05Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60061/merge:

Everything looks good!

sandersn · 2024-09-27T15:32:20Z

I'll send PRs for the DT failures later today.

The angular result for the most recent user test run says 36 errors before, 36 after.

CompressionStream.readable is now generic: ReadableStream<Uint8Array>. microsoft/TypeScript#60061

Required by the TS 5.7 PR: microsoft/TypeScript#60061

Required by the TS 5.7 PR: microsoft/TypeScript#60061 Note that this won't pass tests until TS 5.7 is available as a version on DT.

Required by the TS 5.7 PR: microsoft/TypeScript#60061

Required by the TS 5.7 PR: microsoft/TypeScript#60061 Note that this won't pass tests until TS 5.7 is available as a version on DT.

DOM update 2024-09-25

36f1d00

Overview list of changes still to come.

typescript-bot assigned sandersn Sep 25, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 25, 2024

sandersn requested a review from DanielRosenwasser September 25, 2024 17:26

sandersn enabled auto-merge (squash) September 26, 2024 21:46

jakebailey reviewed Sep 26, 2024

View reviewed changes

sandersn added a commit to sandersn/DefinitelyTyped that referenced this pull request Sep 27, 2024

Update node tests for TS5.7

4d92bb2

CompressionStream.readable is now generic: ReadableStream<Uint8Array>. microsoft/TypeScript#60061

sandersn mentioned this pull request Sep 27, 2024

Update node tests for TS5.7 DefinitelyTyped/DefinitelyTyped#70710

Merged

sandersn added a commit to sandersn/DefinitelyTyped that referenced this pull request Sep 27, 2024

Update css-font-loading-module for TS 5.7

5683356

Required by the TS 5.7 PR: microsoft/TypeScript#60061

sandersn mentioned this pull request Sep 27, 2024

Update css-font-loading-module for TS 5.7 DefinitelyTyped/DefinitelyTyped#70713

Merged

sandersn added a commit to sandersn/DefinitelyTyped that referenced this pull request Sep 27, 2024

Update dom-mediacapture-record for TS 5.7

6920cf6

Required by the TS 5.7 PR: microsoft/TypeScript#60061 Note that this won't pass tests until TS 5.7 is available as a version on DT.

sandersn mentioned this pull request Sep 27, 2024

Update dom-mediacapture-record for TS 5.7 DefinitelyTyped/DefinitelyTyped#70714

Merged

sandersn added a commit to sandersn/DefinitelyTyped that referenced this pull request Sep 27, 2024

Update dom-webcodecs for TS5.7

b876476

Required by the TS 5.7 PR: microsoft/TypeScript#60061 Note that this won't pass tests until TS 5.7 is available as a version on DT.

sandersn mentioned this pull request Sep 27, 2024

Update dom-webcodecs for TS5.7 DefinitelyTyped/DefinitelyTyped#70715

Merged

sandersn added a commit to sandersn/DefinitelyTyped that referenced this pull request Sep 27, 2024

Update rx-dom for TS 5.7

0f3d59c

Required by the TS 5.7 PR: microsoft/TypeScript#60061

sandersn mentioned this pull request Sep 27, 2024

Update rx-dom for TS 5.7 DefinitelyTyped/DefinitelyTyped#70716

Merged

sandersn added a commit to sandersn/DefinitelyTyped that referenced this pull request Sep 27, 2024

Update webrtc for TS 5.7

936331e

Required by the TS 5.7 PR: microsoft/TypeScript#60061 Note that this won't pass tests until TS 5.7 is available as a version on DT.

sandersn mentioned this pull request Sep 27, 2024

Update webrtc for TS 5.7 DefinitelyTyped/DefinitelyTyped#70717

Merged

jakebailey approved these changes Sep 27, 2024

View reviewed changes

sandersn merged commit 2c23bea into microsoft:main Sep 27, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOM update 2024-09-25 #60061

DOM update 2024-09-25 #60061

sandersn commented Sep 25, 2024 •

edited

Loading

jakebailey commented Sep 26, 2024

typescript-bot commented Sep 26, 2024 •

edited

Loading

typescript-bot commented Sep 26, 2024

typescript-bot commented Sep 26, 2024

sandersn commented Sep 26, 2024

jakebailey Sep 26, 2024

sandersn Sep 27, 2024

typescript-bot commented Sep 26, 2024

tsc

jakebailey commented Sep 26, 2024

typescript-bot commented Sep 26, 2024

pixijs/pixijs

tsconfig.types.json

slab/quill

tsconfig.json

packages/quill/tsconfig.json

jakebailey commented Sep 26, 2024

typescript-bot commented Sep 26, 2024 •

edited

Loading

typescript-bot commented Sep 27, 2024

sandersn commented Sep 27, 2024

DOM update 2024-09-25 #60061

DOM update 2024-09-25 #60061

Conversation

sandersn commented Sep 25, 2024 • edited Loading

jakebailey commented Sep 26, 2024

typescript-bot commented Sep 26, 2024 • edited Loading

typescript-bot commented Sep 26, 2024

typescript-bot commented Sep 26, 2024

sandersn commented Sep 26, 2024

jakebailey Sep 26, 2024

Choose a reason for hiding this comment

sandersn Sep 27, 2024

Choose a reason for hiding this comment

typescript-bot commented Sep 26, 2024

tsc

jakebailey commented Sep 26, 2024

typescript-bot commented Sep 26, 2024

pixijs/pixijs

tsconfig.types.json

slab/quill

tsconfig.json

packages/quill/tsconfig.json

jakebailey commented Sep 26, 2024

typescript-bot commented Sep 26, 2024 • edited Loading

typescript-bot commented Sep 27, 2024

sandersn commented Sep 27, 2024

sandersn commented Sep 25, 2024 •

edited

Loading

typescript-bot commented Sep 26, 2024 •

edited

Loading

typescript-bot commented Sep 26, 2024 •

edited

Loading