Mark the inherited any-based index signature so it can be elided in declaration emit #60680

weswigham · 2024-12-04T20:12:14Z

So they're not mistaken for late-bound index infos. Including them in the emit is functionally harmless in normal checking modes, since they are actually on the type, but under partial/single-file modes there may be extra anys from things imported from missing files and including these would spoil the emit.

Fixed #60383.

…eclaration emit

weswigham · 2024-12-04T20:12:50Z

@typescript-bot test it

typescript-bot · 2024-12-04T20:12:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-12-04T20:36:31Z

Hey @weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-04T20:54:32Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,767k (± 0.04%)}	_{195,518k (± 0.94%)}	_~	_193,145k	_196,901k	_{p=0.230 n=6}
_{Parse Time}	_{1.60s (± 2.42%)}	_{1.60s (± 0.85%)}	_~	_1.59s	_1.63s	_{p=0.870 n=6}
_{Bind Time}	_{0.86s (± 1.20%)}	_{0.86s (± 1.55%)}	_~	_0.84s	_0.88s	_{p=0.492 n=6}
_{Check Time}	_{11.74s (± 0.60%)}	_{11.77s (± 0.58%)}	_~	_11.66s	_11.84s	_{p=0.574 n=6}
_{Emit Time}	_{3.31s (± 0.75%)}	_{3.33s (± 3.54%)}	_~	_3.26s	_3.57s	_{p=0.469 n=6}
_{Total Time}	_{17.51s (± 0.31%)}	_{17.56s (± 0.50%)}	_~	_17.44s	_17.69s	_{p=0.296 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,185k (± 0.00%)}	_{1,226,189k (± 0.01%)}	_~	_1,226,078k	_1,226,315k	_{p=1.000 n=6}
_{Parse Time}	_{8.15s (± 0.53%)}	_{8.07s (± 0.49%)}	_{-0.08s (- 0.98%)}	_8.03s	_8.11s	_{p=0.020 n=6}
_{Bind Time}	_{2.27s (± 0.67%)}	_{2.30s (± 1.05%)}	_~	_2.26s	_2.33s	_{p=0.107 n=6}
_{Check Time}	_{38.34s (± 0.47%)}	_{38.40s (± 0.54%)}	_~	_38.13s	_38.68s	_{p=0.689 n=6}
_{Emit Time}	_{18.37s (± 0.50%)}	_{18.30s (± 0.33%)}	_~	_18.21s	_18.37s	_{p=0.230 n=6}
_{Total Time}	_{67.14s (± 0.32%)}	_{67.06s (± 0.29%)}	_~	_66.86s	_67.34s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,501,823	_2,501,823	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,645	_909,645	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,319,511k (± 0.01%)}	_{2,319,409k (± 0.01%)}	_~	_2,319,199k	_2,319,571k	_{p=0.173 n=6}
_{Parse Time}	_{11.20s (± 0.29%)}	_{11.22s (± 0.36%)}	_~	_11.16s	_11.28s	_{p=0.748 n=6}
_{Bind Time}	_{2.64s (± 1.09%)}	_{2.63s (± 0.52%)}	_~	_2.60s	_2.64s	_{p=0.743 n=6}
_{Check Time}	_{90.75s (± 2.03%)}	_{91.87s (± 2.00%)}	_~	_89.30s	_94.93s	_{p=0.230 n=6}
_{Emit Time}	_{0.34s (± 3.04%)}	_{0.35s (± 2.35%)}	_~	_0.35s	_0.37s	_{p=0.122 n=6}
_{Total Time}	_{104.95s (± 1.78%)}	_{106.06s (± 1.72%)}	_~	_103.53s	_109.13s	_{p=0.229 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,287	_1,225,288	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,555	_266,555	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,720,478k (±14.65%)}	_{2,841,944k (±13.21%)}	_~	_2,355,841k	_3,085,234k	_{p=0.471 n=6}
_{Parse Time}	_{6.73s (± 2.12%)}	_{6.74s (± 1.71%)}	_~	_6.59s	_6.84s	_{p=1.000 n=6}
_{Bind Time}	_{2.17s (± 1.84%)}	_{2.14s (± 2.39%)}	_~	_2.07s	_2.19s	_{p=0.261 n=6}
_{Check Time}	_{42.90s (± 0.29%)}	_{42.76s (± 0.33%)}	_~	_42.62s	_42.98s	_{p=0.173 n=6}
_{Emit Time}	_{3.55s (± 2.65%)}	_{3.50s (± 4.11%)}	_~	_3.35s	_3.73s	_{p=0.471 n=6}
_{Total Time}	_{55.35s (± 0.33%)}	_{55.15s (± 0.31%)}	_~	_54.98s	_55.45s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,287	_1,225,288	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,555	_266,555	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,908,243k (±12.86%)}	_{3,029,284k (± 9.77%)}	_~	_2,424,768k	_3,151,002k	_{p=0.575 n=6}
_{Parse Time}	_{6.94s (± 1.77%)}	_{6.98s (± 1.15%)}	_~	_6.85s	_7.09s	_{p=0.810 n=6}
_{Bind Time}	_{2.13s (± 2.07%)}	_{2.14s (± 1.63%)}	_~	_2.08s	_2.18s	_{p=0.521 n=6}
_{Check Time}	_{42.77s (± 0.48%)}	_{42.78s (± 0.44%)}	_~	_42.40s	_42.89s	_{p=0.471 n=6}
_{Emit Time}	_{3.49s (± 1.81%)}	_{3.47s (± 1.78%)}	_~	_3.38s	_3.53s	_{p=0.809 n=6}
_{Total Time}	_{55.34s (± 0.59%)}	_{55.36s (± 0.40%)}	_~	_54.95s	_55.55s	_{p=0.574 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,259	_262,260	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,616	_106,616	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,871k (± 0.01%)}	_{439,869k (± 0.01%)}	_~	_439,808k	_439,948k	_{p=0.873 n=6}
_{Parse Time}	_{3.50s (± 0.66%)}	_{3.55s (± 0.90%)}	_{+0.05s (+ 1.43%)}	_3.51s	_3.58s	_{p=0.028 n=6}
_{Bind Time}	_{1.32s (± 1.21%)}	_{1.32s (± 0.88%)}	_~	_1.31s	_1.34s	_{p=1.000 n=6}
_{Check Time}	_{18.89s (± 0.36%)}	_{18.89s (± 0.77%)}	_~	_18.72s	_19.13s	_{p=0.873 n=6}
_{Emit Time}	_{1.51s (± 0.88%)}	_{1.53s (± 0.89%)}	_{+0.02s (+ 1.43%)}	_1.52s	_1.55s	_{p=0.027 n=6}
_{Total Time}	_{25.22s (± 0.35%)}	_{25.29s (± 0.51%)}	_~	_25.14s	_25.49s	_{p=0.471 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,786k (± 0.06%)}	_{371,637k (± 0.03%)}	_~	_371,508k	_371,865k	_{p=0.173 n=6}
_{Parse Time}	_{2.90s (± 1.01%)}	_{2.90s (± 0.86%)}	_~	_2.86s	_2.93s	_{p=0.806 n=6}
_{Bind Time}	_{1.58s (± 0.62%)}	_{1.60s (± 0.32%)}	_{+0.01s (+ 0.95%)}	_1.59s	_1.60s	_{p=0.014 n=6}
_{Check Time}	_{16.53s (± 0.34%)}	_{16.45s (± 0.23%)}	_{-0.08s (- 0.49%)}	_16.39s	_16.50s	_{p=0.037 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_0.00s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{21.02s (± 0.22%)}	_{20.95s (± 0.20%)}	_{-0.06s (- 0.29%)}	_20.92s	_21.02s	_{p=0.036 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,197,670	_3,197,670	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,099,167	_1,099,167	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,271,376k (± 0.01%)}	_{3,271,794k (± 0.01%)}	_~	_3,270,997k	_3,272,079k	_{p=0.229 n=6}
_{Parse Time}	_{14.12s (± 0.45%)}	_{14.06s (± 0.62%)}	_~	_13.91s	_14.17s	_{p=0.173 n=6}
_{Bind Time}	_{4.52s (± 0.62%)}	_{4.51s (± 0.96%)}	_~	_4.47s	_4.58s	_{p=0.687 n=6}
_{Check Time}	_{86.88s (± 1.75%)}	_{88.55s (± 2.04%)}	_~	_85.60s	_90.17s	_{p=0.229 n=6}
_{Emit Time}	_{28.32s (± 2.28%)}	_{27.72s (± 1.67%)}	_~	_27.33s	_28.62s	_{p=0.173 n=6}
_{Total Time}	_{133.84s (± 0.96%)}	_{134.84s (± 1.28%)}	_~	_131.68s	_136.50s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,751	_288,751	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,157	_117,157	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,999k (± 0.02%)}	_{441,003k (± 0.02%)}	_~	_440,878k	_441,126k	_{p=0.810 n=6}
_{Parse Time}	_{4.06s (± 0.63%)}	_{4.05s (± 0.75%)}	_~	_4.00s	_4.09s	_{p=0.573 n=6}
_{Bind Time}	_{1.75s (± 0.79%)}	_{1.76s (± 1.64%)}	_~	_1.71s	_1.78s	_{p=0.371 n=6}
_{Check Time}	_{18.83s (± 0.35%)}	_{18.79s (± 0.72%)}	_~	_18.63s	_19.00s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.64s (± 0.25%)}	_{24.60s (± 0.51%)}	_~	_24.41s	_24.76s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,390	_552,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_185,096	_185,096	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,470k (± 0.03%)}	_{492,459k (± 0.01%)}	_~	_492,392k	_492,491k	_{p=0.173 n=6}
_{Parse Time}	_{3.43s (± 1.04%)}	_{3.41s (± 0.60%)}	_~	_3.38s	_3.43s	_{p=0.420 n=6}
_{Bind Time}	_{1.18s (± 0.88%)}	_{1.18s (± 1.65%)}	_~	_1.15s	_1.20s	_{p=0.681 n=6}
_{Check Time}	_{19.55s (± 1.12%)}	_{19.45s (± 0.49%)}	_~	_19.33s	_19.56s	_{p=0.574 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.15s (± 0.85%)}	_{24.04s (± 0.40%)}	_~	_23.93s	_24.16s	_{p=0.470 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-12-16T19:34:19Z

@typescript-bot cherry-pick this to release-5.7

typescript-bot · 2024-12-16T19:34:23Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.7`	✅ Started	✅ Results

…eclaration emit (#60680)

typescript-bot · 2024-12-16T19:36:11Z

Hey, @jakebailey! I've created #60776 for you.

…e-5.7 (#60776) Co-authored-by: Wesley Wigham <wewigham@microsoft.com>

Mark the inherited any-based index signature so it can be elided in d…

2051428

…eclaration emit

weswigham requested review from sandersn and jakebailey December 4, 2024 20:12

typescript-bot assigned weswigham Dec 4, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 4, 2024

jakebailey approved these changes Dec 4, 2024

View reviewed changes

weswigham merged commit 42f893f into microsoft:main Dec 4, 2024
32 checks passed

weswigham deleted the any-inherited-index-info branch December 4, 2024 21:21

typescript-bot pushed a commit that referenced this pull request Dec 16, 2024

Mark the inherited any-based index signature so it can be elided in d…

3a23fc2

…eclaration emit (#60680)

typescript-bot mentioned this pull request Dec 16, 2024

🤖 Pick PR #60680 (Mark the inherited any-based index ...) into release-5.7 #60776

Merged

DanielRosenwasser pushed a commit that referenced this pull request Dec 17, 2024

🤖 Pick PR #60680 (Mark the inherited any-based index ...) into releas…

4b7441a

…e-5.7 (#60776) Co-authored-by: Wesley Wigham <wewigham@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark the inherited any-based index signature so it can be elided in declaration emit #60680

Mark the inherited any-based index signature so it can be elided in declaration emit #60680

weswigham commented Dec 4, 2024

weswigham commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

tsc

jakebailey commented Dec 16, 2024

typescript-bot commented Dec 16, 2024 •

edited

Loading

typescript-bot commented Dec 16, 2024

Mark the inherited any-based index signature so it can be elided in declaration emit #60680

Mark the inherited any-based index signature so it can be elided in declaration emit #60680

Conversation

weswigham commented Dec 4, 2024

weswigham commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

tsc

jakebailey commented Dec 16, 2024

typescript-bot commented Dec 16, 2024 • edited Loading

typescript-bot commented Dec 16, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 16, 2024 •

edited

Loading