Harden sanitizeLog against incorrect matches on TypeScript versions.
#60794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested review from
weswigham,
andrewbranch,
jakebailey and
gabritto
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
approved these changes
Dec 17, 2024
andrewbranch
approved these changes
Dec 17, 2024
andrewbranch
requested changes
Dec 17, 2024
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
|
@typescript-bot cherry-pick to release-5.7 |
typescript-bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
#60794) Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
|
Hey, @DanielRosenwasser! I've created #60798 for you. |
DanielRosenwasser
added a commit
that referenced
this pull request
Dec 17, 2024
…e-5.7 (#60798) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com> Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Because we don't want to update every server log baseline on every TypeScript version change, we sanitize server logs based on the current TypeScript version. Specifically, we replace occurrences of the full version with
FakeVersion, and replace occurrences of the major.minor version withtsFakeMajor.Minor.Problem
When TypeScript updating to
5.7.3, the baselines were incorrectly updated because we have a server test with a package at the version15.7.3. This is not the first time we hit this issue, and historically we have gotten around it by just changing the version of the test package.Proposed Fix
@andrewbranch's suggestion was to switch to a regex and add boundaries to the beginning/end. This doesn't entirely fix the issue, but it does harden the test runner by avoiding a match of
5.7.3within15.7.3.