Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer string literals at comparison locations #6196

Closed
wants to merge 31 commits into from
Closed

Infer string literals at comparison locations #6196

wants to merge 31 commits into from

Commits on Dec 21, 2015

  1. Added tests.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 21, 2015
    Configuration menu
    Copy the full SHA
    0d2fb26 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2015

  1. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    639d9bf View commit details
    Browse the repository at this point in the history

  2. Infer string literal types at comparison locations.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    13ec5d7 View commit details
    Browse the repository at this point in the history

  3. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    e109b17 View commit details
    Browse the repository at this point in the history

  4. Removed ad-hoc string-like checking for type assertions, switch/cases… 

    …, and equality comparisons.
    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    de9789a View commit details
    Browse the repository at this point in the history

  5. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    d0a8573 View commit details
    Browse the repository at this point in the history

  6. Amended tests.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    e452955 View commit details
    Browse the repository at this point in the history

  7. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    ced65ac View commit details
    Browse the repository at this point in the history

  8. Separated logic out to 'shouldAcquireLiteralType'.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    881b52d View commit details
    Browse the repository at this point in the history

  9. Amended comment.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    8365410 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2015

  1. Rewrote loop, amended comment.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    58580ed View commit details
    Browse the repository at this point in the history

  2. Add conditional expressions, be more conservative in checks for '||'.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    069ff33 View commit details
    Browse the repository at this point in the history

  3. Added more to test.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    2874156 View commit details
    Browse the repository at this point in the history

  4. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    e2ddb29 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2016

  1. Merge branch 'master' into literalTypeLocations

    @DanielRosenwasser
    DanielRosenwasser committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    f7e9135 View commit details
    Browse the repository at this point in the history

  2. Added test.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    e6bd7ad View commit details
    Browse the repository at this point in the history

  3. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    16fe01b View commit details
    Browse the repository at this point in the history

  4. Added RHS operands of '&&' and ',' as match locations.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    bc34ebb View commit details
    Browse the repository at this point in the history

  5. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    4eced90 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2016

  1. Added tests for type assertions in match locations.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    01cc2f1 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    259a3cf View commit details
    Browse the repository at this point in the history

  3. Factored out operand detection logic and made it recursive.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    cc2ab55 View commit details
    Browse the repository at this point in the history

  4. Included type assertions in operand detection logic.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    5b9e5d1 View commit details
    Browse the repository at this point in the history

  5. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    fdd7fde View commit details
    Browse the repository at this point in the history

  6. Fix lint issues.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    09d1762 View commit details
    Browse the repository at this point in the history

  7. Added scenario to tests.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    dec70f1 View commit details
    Browse the repository at this point in the history

  8. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    1dd43fa View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into literalTypeLocations

    @DanielRosenwasser
    DanielRosenwasser committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    ab25584 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2016

  1. Merge branch 'master' into literalTypeLocations

    @DanielRosenwasser
    DanielRosenwasser committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    9673152 View commit details
    Browse the repository at this point in the history

  2. Accepted other baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Apr 5, 2016
    Configuration menu
    Copy the full SHA
    6b8bac3 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2016

  1. Merge branch 'master' into literalTypeLocations

    @DanielRosenwasser
    DanielRosenwasser committed Jun 10, 2016
    Configuration menu
    Copy the full SHA
    740792c View commit details
    Browse the repository at this point in the history