Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clear method in WeakSet and WeakMap #6583

Merged

Conversation

falsandtru
Copy link
Contributor

Fixes #6500

@msftclas
Copy link

Hi @falsandtru, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@DanielRosenwasser
Copy link
Member

@falsandtru as mentioned in the README, you shouldn't be editing files in lib. These changes need to be applied in src/lib, and no changes should be made in lib itself.

@falsandtru
Copy link
Contributor Author

All right, I fixed it.

@DanielRosenwasser
Copy link
Member

👍

DanielRosenwasser added a commit that referenced this pull request Jan 24, 2016
Remove `clear` method in `WeakSet` and `WeakMap`
@DanielRosenwasser DanielRosenwasser merged commit 239695f into microsoft:master Jan 24, 2016
@falsandtru falsandtru deleted the fixWeakSetWeakMapClear branch January 25, 2016 01:27
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants