UMD support #7264
UMD support #7264
Conversation
| @@ -4604,6 +4609,7 @@ namespace ts { | |||
| case SyntaxKind.EnumKeyword: | |||
| return parseEnumDeclaration(fullStart, decorators, modifiers); | |||
| case SyntaxKind.GlobalKeyword: | |||
| return parseModuleDeclaration(fullStart, decorators, modifiers); | |||
There was a problem hiding this comment.
You can let this fall through again.
| if (parent.externalModuleIndicator && !parent.isDeclarationFile) { | ||
| error(node, Diagnostics.Global_module_exports_may_only_appear_in_declaration_files); | ||
| } | ||
| } |
There was a problem hiding this comment.
Spoke offline with @vladima. Add all of this to the binder.
|
Any other comments? |
| @@ -981,6 +981,10 @@ namespace ts { | |||
| return getExternalModuleMember(<ImportDeclaration>node.parent.parent.parent, node); | |||
| } | |||
|
|
|||
| function getTargetOfGlobalModuleExportDeclaration(node: GlobalModuleExportDeclaration): Symbol { | |||
| return node.parent.symbol; | |||
There was a problem hiding this comment.
can this symbol be merged with anything?
There was a problem hiding this comment.
Hrm, yes. You could have a module jquery.d.ts and then an augmentation of it in another file. I assume that has some impact here?
|
@vladima added support for |
| function getTargetOfGlobalModuleExportDeclaration(node: GlobalModuleExportDeclaration): Symbol { | ||
| const moduleSymbol = node.parent.symbol; | ||
| if (moduleSymbol && moduleSymbol.exports && moduleSymbol.exports["export="]) { | ||
| return moduleSymbol.exports["export="].exportSymbol; |
There was a problem hiding this comment.
Does this account for module augmentations? Will you need to get the "merged" symbol in that case?
There was a problem hiding this comment.
I don't think it does, but I don't know how to make it work either. Any ideas?
|
Added tests for module augmentation; any other comments? |
| else { | ||
| const parent = node.parent as SourceFile; | ||
|
|
||
| if (!isExternalModule(<SourceFile>node.parent)) { |
|
Can you add a test that uses an |
|
✔️ |
|
@RyanCavanaugh TL;DR: Can you add an example that uses |
Fixes #7125