Tuple conformance #822
Merged
Tuple conformance #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // error | ||
| numArray = numStrTuple; | ||
| ~~~~~~~~ | ||
| !!! error TS2322: Type '[number, string]' is not assignable to type 'number[]': |
There was a problem hiding this comment.
heyYui, can you file a bug on having us provide a better error message here. Here we're giving an error about 'pop' being wrong (where pop is a method on Array), where it would probably be better to indicate that the type of the tuple array isn't assignable to number.
This is all about improving the error message and providing more directed, useful, information to the person who runs into this.
Thanks!
| @@ -0,0 +1,15 @@ | |||
| var strNumTuple: [string, number] = ["foo", 10]; | |||
There was a problem hiding this comment.
is this file names ' ? or is this a github issue?
if it is the earlier, please fix it.
There was a problem hiding this comment.
oh i see.. this seems to be the same as indexerWithTuple.ts, so delete it then.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformance test for tuple feature (PR #428)