Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make this in object literal always of type any #8389

Merged
merged 2 commits into from
Apr 30, 2016
Merged

Make this in object literal always of type any #8389

merged 2 commits into from
Apr 30, 2016

Commits on Apr 29, 2016

  1. Make this in object literal always of type any 

    Previously, `this` was implicitly typed by the shape of its containing object literal.
This is not correct for JavaScript-style inheritance uses of object literals, and the previous fix was not correct either.
So we're going back to `this: any` in object literals for now.
    @sandersn
    sandersn committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    0a2ba0c View commit details
    Browse the repository at this point in the history

  2. Add --noImplicitThis test for object literals

    @sandersn
    sandersn committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    8d45a73 View commit details
    Browse the repository at this point in the history