-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pvb/discover code actions #9304
Closed
Closed
Changes from 3 commits
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
49ac6e4
Initial work to get CodeFixes and make them work in fourslash
a985041
Initial work to get CodeFixes and make them work in fourslash
5b0b310
Move things around
617b819
Code changes to update references of the Identifiers
sarangan12 a8bc8b4
Added code for handling function, method and coonstructor level local…
sarangan12 01966ba
Rebased with origin master
sarangan12 1e5ca92
Code changes to handle unused private variables, private methods and …
sarangan12 890d178
Code changes to handle namespace level elements
sarangan12 69dbeea
Code changes to handle unimplemented interfaces
sarangan12 c78d0e2
Code to optimize the d.ts check
sarangan12 107b369
Correct Code change to handle the parameters for methods inside inter…
sarangan12 481baa3
Fix for lint error
sarangan12 cd1ce0f
Remove Trailing whitespace
sarangan12 4e36add
Support multiple errorcodes per fix
3994bfc
Implement making making super call the first call fix.
a38149d
Code changes to handle interface implementations
sarangan12 0571c19
Changes to display the error position correctly
sarangan12 e17ed58
Compiler Test Cases
sarangan12 2b7f3a7
Merge remote-tracking branch 'origin' into UpdateReferences
sarangan12 efa1543
Merge remote-tracking branch 'origin' into pvb/discoverCodeActions
sarangan12 d2ff079
Code change that was missed in merge
sarangan12 ee083ef
Merge branch 'pvb/discoverCodeActions' into UpdateReferences
sarangan12 a3818ba
stash
c619cab
First Commit for API Changes for Tracking Unused Identifiers
sarangan12 0a592c8
Removed unnecessary change in superfix and add one more test case
sarangan12 adfb73d
Additional Fourslash test cases
sarangan12 c102c3a
Added error message
sarangan12 eb7fa70
Fix tests
a1fa10d
Quick fix for implementing interfaces
sarangan12 37e25df
Changes the signature and error message
sarangan12 2e48281
Modified the test case and expected results
sarangan12 3d25daf
Additional scenarios for handling the Interface Implementation
sarangan12 5a34352
Adding condition to ignore constructor parameters
sarangan12 93b7490
Removing unnecessary tests
sarangan12 7aba626
Additional changes for compiler code
sarangan12 ed5052d
Additional changes to handle constructor scenario
sarangan12 f5cdc9c
Fixing the consolidated case
sarangan12 8c3c7b1
Changed logic to search for private instead of public
sarangan12 dfad7cc
Response to PR Comments
sarangan12 c325625
Merge remote-tracking branch 'origin' into UnusedIdentifiersCompilerCode
sarangan12 6a711bc
Changed the error code in test cases as result of merge with master
sarangan12 d62a43f
Adding the missing file
sarangan12 043a625
Adding the missing file II
sarangan12 6d4020b
Rename QuickFix to CodeFix
7792e18
Bunch of renames
e57e628
Make provider work with multiple fixes
32e5787
Adding code for handling classes implemented by other classes
sarangan12 394a4d1
Optimizing code Part I
sarangan12 dca1263
Optimizing code Part II
sarangan12 03e2037
Verify the code changes result in the expected new code.
8f9d4ae
Response to PR comments
sarangan12 f15448a
Merge remote-tracking branch 'origin' into UnusedIdentifiersCompilerCode
sarangan12 972ed40
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 1d3a888
Fixing the error code
sarangan12 c82453f
Code changes for checking unused imports
sarangan12 bcd6fc4
Test Cases for Unused Imports
sarangan12 49385f4
Response to PR comments
sarangan12 0a30933
Merge branch 'pvb/discoverCodeActions' of https://github.com/Microsof…
sarangan12 b198d69
Merge branch 'pvb/discoverCodeActions', remote-tracking branch 'origi…
sarangan12 f58e8ca
Modified the test code based on the changes in DiscoverActions branch
sarangan12 d08f1b1
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 bdf444c
Add fix for moving the super call to be the first call in the constru…
b807487
Merge branch 'master' into pvb/discoverCodeActions
e077dde
Code changes for unused imports - Part I
sarangan12 5993015
Code change specific to position of Import Declaration
sarangan12 5c656a7
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 45d449f
Additional code changes for unused imports
sarangan12 f464f92
Code change for handling the position for unused import
sarangan12 e096d39
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 817091c
Code changes to handle For statements
sarangan12 5b32e91
Merge branch 'pvb/discoverCodeActions' of https://github.com/Microsof…
sarangan12 3f559ae
Merge branch 'pvb/discoverCodeActions' into UnusedIdentifiersApi
sarangan12 3b5f8d2
New scenarios for handling parameters in lambda function, type parame…
sarangan12 ed282d7
Additional scenarios based on PR comments
sarangan12 e502ba0
Removing a redundant check
sarangan12 7dda03e
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 082c6de
Additional scenarios added
sarangan12 0e2e43d
Added ambient check to imports and typeparatmeter reporting
sarangan12 dd04af5
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 73375c0
Code changes and test cases to handle enums
sarangan12 754034d
Added Debug Statement instead of throwing error.
sarangan12 d6c2bcd
Merge remote-tracking branch 'origin' into UnusedIdentifiersCompilerCode
sarangan12 33f4a6b
CR feedback, and add the ability to have fixes which span files.
42bc9c5
fix typo
0516e91
Don't throw
37cb001
More typo fixes
f93c6c8
Added one more scenario to handle type parameters
sarangan12 5d61c43
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 97a3d90
Added test for another scenario involving type parameters
sarangan12 4521058
Added new scenario for TypeParameter on Interface
sarangan12 5b861eb
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 ab0fdd4
Additional test cases
sarangan12 5eb7153
Refactoring the code
sarangan12 1401506
Merge remote-tracking branch 'origin' into UnusedIdentifiersCompilerCode
sarangan12 5361e5f
Added scenario to handle private class elements declared in constructor.
sarangan12 7fc4616
Minor change to erro reporting
sarangan12 9753d09
Merge remote-tracking branch 'origin' into UnusedIdentifiersCompilerCode
sarangan12 4c8d399
Merge branch 'UnusedIdentifiersCompilerCode' into UnusedIdentifiersApi
sarangan12 00d84d4
Merge branch 'master' into pvb/discoverCodeActions
7238991
Additional scenarios
sarangan12 537e065
Code changes for abstract class extends
sarangan12 2dd1361
Merge remote-tracking branch 'origin' into UnusedIdentifiersApi
sarangan12 db4838f
Code changes for changing extends keyword to implements keyword
sarangan12 f0a5a6b
Merge branch 'master' into pvb/discoverCodeActions
bf6e045
Change to use CodeActionContext instead of a bunch of arguments, so it's
23ea06b
CR Feedback. Turn CodeActionContext into interface
15d71eb
Improve Fourslash support
aacb834
Merge remote-tracking branch 'sarangan/UnusedIdentifiersApi' into pvb…
d6e81c3
Merge remote-tracking branch 'sarangan/ImplementInterfacesQUickFix' i…
0260fca
Merge remote-tracking branch 'sarangan/ChangeExtendsToImplementsFix' …
d9f9baa
linter fixes
7397f6d
Add codefixes to tsconfig and jake
8e2cdac
Each 'CodeFix' can now return more than one action which implements a…
81a5901
code cleanup
49c0965
Merge branch 'master' into pvb/discoverCodeActions
35fcbb8
Code clean up after renaming
8871c18
Merge branch 'master' into pvb/discoverCodeActions
02fcf9f
Change API and fix FourSlash
d4f0e13
Change FourSlash API
79375f8
Merge branch 'master' into pvb/discoverCodeActions
62c4bad
Linter fixes
5bd7458
Fixes due to API Changes
sarangan12 79fb29e
Merge branch 'master' into pvb/discoverCodeActions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems more Javascripty to use an interface instead of a class for
CodeActionContext
and saysince CodeActionContext doesn't use any class features except the constructor.