Use index.lock and move writes to head and refs to the end of the run to make interrupted fastfetch operations less bad #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in the comments, FastFetch is pretty far away from the ideal way of handling .git/index and .git/index.lock. I had a go at fixing that, but after getting a ways into it, I decided that the value just wasn't really there and the risk was pretty high. So I hacked around the problem. |
GVFS/FastFetch/CheckoutPrefetcher.cs
Outdated
| @@ -72,87 +72,104 @@ public override void Prefetch(string branchOrCommit, bool isBranch) | |||
| commitToFetch = branchOrCommit; | |||
| } | |||
|
|
|||
| this.DownloadMissingCommit(commitToFetch, this.GitObjects); | |||
| if (!IndexLock.TryGetLock(this.Enlistment.EnlistmentRoot, this.Tracer, out var indexLock)) | |||
There was a problem hiding this comment.
Not to any other reviewers: this diff looks a lot better if you change the diff options to "Hide Whitespace".
…ng to pass on pass-fail information to future instances
SteveBenz
changed the title
derrickstolee
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.