Building VFS for Git in 2024 #1804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to run functional tests for a locally-build version, I got the following error: Cannot clone @ C:\Repos\GVFSFunctionalTests\enlistment\29fd71cb642b4523bc0a: System.FormatException: Input string was not in a correct format. at System.Version.VersionResult.SetFailure(ParseFailureKind failure, String argument) at System.Version.TryParseComponent(String component, String componentName, VersionResult& result, Int32& parsedComponent) at System.Version.TryParseVersion(String version, VersionResult& result) at System.Version.Parse(String input) at System.Version..ctor(String version) at GVFS.CommandLine.GVFSVerb.TryValidateGVFSVersion(GVFSEnlistment enlistment, ITracer tracer, ServerGVFSConfig config, String& errorMessage, Boolean& errorIsFatal) at GVFS.CommandLine.GVFSVerb.ValidateClientVersions(ITracer tracer, GVFSEnlistment enlistment, ServerGVFSConfig gvfsConfig, Boolean showWarnings) at GVFS.CommandLine.CloneVerb.Execute() The version string I was seeing was of the form "GVFS 0.2.XXX.Y+<id>" so my guess is that the "+<id>" portion is causing the System.Version logic to complain.
At some point, the config option was renamed from core.useBuiltinFSMonitor to simply core.fsmonitor=(true|false). The core.fsmonitor can also be used to specify a hook name, which led to the initial distinction. Without this update, the functional tests fail due to stderr differences including this warning: warning: virtual repository '...' is incompatible with fsmonitor This is due to core.fsmonitor=true being implied by default.
Fixing these tests will require changes to microsoft/git to reenable behavior that is more careful about broken objects.
derrickstolee
commented
Feb 15, 2024
| @@ -55,7 +55,7 @@ public void Initialize() | |||
| GitProcess.Invoke(this.RootPath, "config merge.renames false"); | |||
| GitProcess.Invoke(this.RootPath, "config advice.statusUoption false"); | |||
| GitProcess.Invoke(this.RootPath, "config core.abbrev 40"); | |||
| GitProcess.Invoke(this.RootPath, "config core.useBuiltinFSMonitor false"); | |||
| GitProcess.Invoke(this.RootPath, "config core.fsmonitor false"); | |||
There was a problem hiding this comment.
@jeffhostetler: Perhaps the old line should stay here, and we just add the core.fsmonitor line, too. Keeping the old config won't hurt, and might help for users still on an older version of Git.
There was a problem hiding this comment.
Yeah, leave both. It won't hurt anything. I haven't checked recently to see how many users are still using very old versions of Git, but let's assume we have some...
| @@ -311,7 +311,7 @@ public static bool TrySetRequiredGitConfigSettings(Enlistment enlistment) | |||
| { "commitGraph.generationVersion", "1" }, | |||
|
|
|||
| // Disable the builtin FS Monitor in case it was enabled globally. | |||
| { "core.useBuiltinFSMonitor", "false" }, | |||
| { "core.fsmonitor", "false" }, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to evaluate the merit of other changes, such as #1803, I needed these changes locally in order to get a clean functional test run. Each change is isolated to its own commit, so review commit-by-commit.
Generally, there are a few categories of problems: