Centralize business logic for starting background prefetch. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbriggs
force-pushed
the
centralize-background-prefetch-enablement
branch
from
f858bca
to
4d7a1d7
Compare
derrickstolee
approved these changes
Aug 17, 2018
sanoursa
approved these changes
Aug 17, 2018
| { | ||
| this.prefetchJobTimer = new Timer((state) => this.LaunchPrefetchJobIfIdle(), null, this.timerPeriod, this.timerPeriod); | ||
| this.tracer.RelatedInfo(nameof(BackgroundPrefetcher) + ": starting background prefetch timer"); | ||
| } | ||
| else | ||
| { | ||
| this.tracer.RelatedInfo(nameof(BackgroundPrefetcher) + ": no configured cache server, not starting background prefetch timer"); | ||
| this.tracer.RelatedInfo(nameof(BackgroundPrefetcher) + ": no configured cache server or enlistment is unattended, not starting background prefetch timer"); |
There was a problem hiding this comment.
For diagnosing issues, it would be nice to keep these as two separate trace statements, so we know which reason caused it to be disabled.
There was a problem hiding this comment.
@sanoursa I considered that, but it added some complexity to this logging path for little value, because just a few lines prior to this statement in the mount process log file is "GVFS_UNATTENDED" if the enlistment is running in unattend mode, and at the head of the mount process log we log the remote url and objects endpoint url. I think that should give us the information we would need to diagnose.
Thoughts?
There was a problem hiding this comment.
Got it, yea that makes sense
wilbaker
approved these changes
Aug 17, 2018
Move the check for unattended enlistment from InProcessMount to BackgroundPrefetcher.
jrbriggs
force-pushed
the
centralize-background-prefetch-enablement
branch
from
4d7a1d7
to
553615d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for unattended enlistment from
InProcessMounttoBackgroundPrefetcher.