Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait for background operations to complete in modified paths test #310

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Add wait for background operations to complete in modified paths test #310

merged 1 commit into from
Sep 28, 2018

Conversation

kewillford
Copy link
Member

This test would sometimes fail if the test opened the modified paths files before the background operations were completed.

wilbaker
wilbaker approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@wilbaker wilbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@kewillford kewillford merged commit 0465c34 into microsoft:master Sep 28, 2018
@kewillford kewillford deleted the fix_flaky_modifiedpaths_test branch September 28, 2018 04:20
@jrbriggs jrbriggs mentioned this pull request Oct 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilbaker wilbaker wilbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kewillford @wilbaker