Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating all thrrows of platform and arch to logging #171

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

psingla1210
Copy link
Contributor

@psingla1210 psingla1210 commented Sep 13, 2023

In Virtual Client, we used to throw error if workload is not supported for current platform and architecture but if we have multiple workloads in single profile and workloads are meant to run for different permutations and combinations of platform and architecture support, it makes sense that we go on with profile and not throw error if one of the intermediate workload is not supported.

Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a large set that I will trust you on this. You don't need to do this for our internal repo. I will have another PR to change these checks to an attribute. Thanks!

@psingla1210 psingla1210 merged commit 620253b into main Sep 19, 2023
@psingla1210 psingla1210 deleted the users/prachisingla/ConvertThrowingToLogging branch September 19, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants