removing existing compiler alternatives prior to adding them #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Nov 9, 2023
src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Nov 9, 2023
yangpanMS
reviewed
Nov 10, 2023
src/VirtualClient/VirtualClient.Dependencies.UnitTests/CompilerInstallationTests.cs
Show resolved
Hide resolved
…com/microsoft/VirtualClient into users/evellanoweth/remove-compilers
yangpanMS
approved these changes
Nov 10, 2023
muskankhedia
pushed a commit
to muskankhedia/VirtualClient
that referenced
this pull request
Nov 24, 2023
…ng new ones (microsoft#206) Co-authored-by: Erica Vellanoweth <evellanoweth@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Cedar Crest validation, we ran into a bug that would not allow us to get past the CompilerInstallation dependency on the linux-arm64 system.
By removing all alternatives before adding new ones, this error is avoided.
This change was also tested on fresh linux-x64 and -arm64 systems to assure the change is non-breaking, as well as the original CC machine.