Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to GB6 #224

Merged
merged 19 commits into from
Dec 5, 2023
Merged

migrate to GB6 #224

merged 19 commits into from
Dec 5, 2023

Conversation

kayvontadj
Copy link
Contributor

No description provided.

yangpanMS
yangpanMS reviewed Nov 30, 2023
View reviewed changes
DRI duties.txt Outdated Show resolved Hide resolved
yangpanMS
yangpanMS reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Please help test both on new machines if you haven't

yangpanMS
yangpanMS approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's remove the GeekBenchResult class if it's not referenced anywhere

Kayvon Tadj added 9 commits November 30, 2023 14:37
@kayvontadj kayvontadj merged commit 0df5be0 into main Dec 5, 2023
4 checks passed
@kayvontadj kayvontadj deleted the users/kayvontadj/MigrateToGB6 branch December 5, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangpanMS yangpanMS yangpanMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayvontadj @yangpanMS