Fix for double quotes appearing in csv log #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Dec 1, 2023
yangpanMS
approved these changes
Dec 1, 2023
As per online documents, it should be sufficient to escape the double quotes and enclose the full content within double quotes, which we are doing in VC now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual Client logs the produced metrics locally in csv format. If any of the fields appearing in the csv has quotes ("), it can potentially break the csv.
As a standard way of handling writing to csv, double quote appearing in the field should be escaped by preceding it with another double quote.
Reference: https://stackoverflow.com/questions/17808511/how-to-properly-escape-a-double-quote-in-csv
Modifying one the existing Unit Tests as well to have this unit tested.